Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1de95f0bf3abc9f6f9ebd96814fab2dae042f410.1657169009.git.baruch@tkos.co.il>
In-Reply-To: <1de95f0bf3abc9f6f9ebd96814fab2dae042f410.1657169009.git.baruch@tkos.co.il>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Mon, 11 Jul 2022 14:00:10 +0900
Message-ID: <CAK7LNAQhLFAG31k5Dy+z8kvm62cZQYziJ8tEVAuVsX-D8PRXng@mail.gmail.com>
Subject: Re: [PATCH] init/Kconfig: update KALLSYMS_ALL help text
To:     Baruch Siach <baruch@tkos.co.il>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        live-patching@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jul 7, 2022 at 1:45 PM Baruch Siach <baruch@tkos.co.il> wrote:
>
> CONFIG_KALLSYMS_ALL is required for kernel live patching which is a
> common use case that is enabled in some major distros. Update the
> Kconfig help text to reflect that.
>
> While at it, s/e.g./i.e./ to match the text intention.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---


Applied to linux-kbuild.
Thanks.


>  init/Kconfig | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index c7900e8975f1..20ef72dd6f44 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1722,16 +1722,17 @@ config KALLSYMS_ALL
>         help
>           Normally kallsyms only contains the symbols of functions for nicer
>           OOPS messages and backtraces (i.e., symbols from the text and inittext
> -         sections). This is sufficient for most cases. And only in very rare
> -         cases (e.g., when a debugger is used) all symbols are required (e.g.,
> -         names of variables from the data sections, etc).
> +         sections). This is sufficient for most cases. And only if you want to
> +         enable kernel live patching, or other less common use cases (e.g.,
> +         when a debugger is used) all symbols are required (i.e., names of
> +         variables from the data sections, etc).
>
>           This option makes sure that all symbols are loaded into the kernel
>           image (i.e., symbols from all sections) in cost of increased kernel
>           size (depending on the kernel configuration, it may be 300KiB or
>           something like this).
>
> -         Say N unless you really need all symbols.
> +         Say N unless you really need all symbols, or kernel live patching.
>
>  config KALLSYMS_ABSOLUTE_PERCPU
>         bool
> --
> 2.35.1
>


-- 
Best Regards
Masahiro Yamada