Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220705123705.764-1-xuewen.yan@unisoc.com> <CAB8ipk8w1=cMJV2_ZjWuX6T9RH9VXCMdUaZhLEkCziarhpy-5w@mail.gmail.com>
 <9ade9d43-3ed1-1239-f26e-73145856275a@arm.com>
In-Reply-To: <9ade9d43-3ed1-1239-f26e-73145856275a@arm.com>
From:   Xuewen Yan <xuewen.yan94@gmail.com>
Date:   Mon, 11 Jul 2022 15:43:17 +0800
Message-ID: <CAB8ipk_Y5vaUMnRQVJsbHUue_J00qqy0E1ifu3W_hFSspL1r1w@mail.gmail.com>
Subject: Re: [PATCH] sched/schedutil: Fix deadlock between cpuset and cpu
 hotplug when using schedutil
To:     Lukasz Luba <lukasz.luba@arm.com>
Cc:     Xuewen Yan <xuewen.yan@unisoc.com>, rafael@kernel.org,
        viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org,
        juri.lelli@redhat.com, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org,
        ke.wang@unisoc.com, xuewyan@foxmail.com, linux-pm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jul 11, 2022 at 3:32 PM Lukasz Luba <lukasz.luba@arm.com> wrote:
>
> Hi Xuewen,
>
> On 7/11/22 08:21, Xuewen Yan wrote:
> > Hi all
> >
> > This deadlock is inevitable, any comment?
>
> Could you tell me how to reproduce this?
> Is there a need of special cgroup setup?

This deadlock occurs when we run the monkey test on an Android phone,
at the same time, randomly put online or offline a cpu core.
Indeed the thread-A which get the cgroup_threadgroup_rwsem and waiting
for the cpu_hotplug_lock is the thread whose name is "OomAdjuster" in
android.

And I see the cpu_hotplug_lock is added by the patch:
https://lore.kernel.org/all/20220121101210.84926-1-zhangqiao22@huawei.com/

Thanks!

>
> Regards,
> Lukasz