Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760524AbXEaEmg (ORCPT ); Thu, 31 May 2007 00:42:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758045AbXEaEmR (ORCPT ); Thu, 31 May 2007 00:42:17 -0400 Received: from wa-out-1112.google.com ([209.85.146.181]:1492 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757807AbXEaEmQ (ORCPT ); Thu, 31 May 2007 00:42:16 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=F5U43T4ytNUMDspaHUd09nAezJXJm5U1LzkdV2WtH+tTnRTfwY+HLK/VHVa1GCfjWDMIkH8ghn3cJj1dUJEBWRfZmED3l4GhS/YHdxkkZKEVIOwPlER9ojCu3wvQBMEwJCCCZZBzN8ynx8P6P3Tbp1BIuOvnG7jKZzghGBSxp/U= Message-ID: <86802c440705302142n666e6488oa8f1222218d6989@mail.gmail.com> Date: Wed, 30 May 2007 21:42:15 -0700 From: "Yinghai Lu" To: "Andrew Morton" Subject: Re: [PATCH 4/5] serial: convert early_uart to earlycon for 8250 Cc: "Andi Kleen" , "Russell King" , "Bjorn Helgaas" , "Linux Kernel Mailing List" In-Reply-To: <20070530213934.0a55d86f.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200705291844.00308.yinghai.lu@sun.com> <20070530201335.94f73eb9.akpm@linux-foundation.org> <86802c440705302134l637df0fbm9a3b99eff19201@mail.gmail.com> <20070530213934.0a55d86f.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 44 On 5/30/07, Andrew Morton wrote: > On Wed, 30 May 2007 21:34:35 -0700 "Yinghai Lu" wrote: > > > they will need > > diff --git a/include/asm-x86_64/io.h b/include/asm-x86_64/io.h > > index de2cd9a..e2d66de 100644 > > --- a/include/asm-x86_64/io.h > > +++ b/include/asm-x86_64/io.h > > @@ -145,6 +145,19 @@ extern void early_iounmap(void *addr, unsigned long size); > > extern void __iomem * ioremap_nocache (unsigned long offset, unsigned > > long size); > > extern void iounmap(volatile void __iomem *addr); > > > > +#include > > +#include > > + > > +static inline void __iomem * fix_ioremap (unsigned idx, unsigned long phys) > > +{ > > + void __iomem * vaddr; > > + set_fixmap_nocache(idx, phys & PAGE_MASK); > > + vaddr = (void __iomem *)__fix_to_virt(idx); > > + vaddr += phys & ~PAGE_MASK; > > + > > + return vaddr; > > +} > > + > > I hope not - I just removed that inlined function. It's too large and the > inclusion of pgtable.h in io.h causes all sorts of problems. > > This function should go into arch/.../mm/ioremap.c > agree, but need to keep #include and will create dummy fixmap.h for arch that doesn't support fixmap YH - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/