Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0db981a4-9519-ca7d-b6ce-ff498070bf8e@amd.com>
Date:   Mon, 11 Jul 2022 11:50:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 5.15 138/230] drm/amdgpu: bind to any 0x1002 PCI diplay
 class device
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Sasha Levin <sashal@kernel.org>
References: <20220711090604.055883544@linuxfoundation.org>
 <20220711090607.978575207@linuxfoundation.org>
 <8c73c2b5-f70e-f343-7ca4-e1db420d5419@amd.com> <YsvvXmH9DpMMIIiK@kroah.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <YsvvXmH9DpMMIIiK@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkRMa05CWkE4REF3cnBMMlRYcTB4SUFscHpGTWZwMkE2b0Y5dEJpY0V4Mjg3?=
 =?utf-8?B?MGtxV0k2MWZXdlAvK0IvNjhvU0Q5b2JVaWJzZExBZVU2QkwwbktwRmdRZnZz?=
 =?utf-8?B?YWIrZC80ajRoMDhVdlZYaXAwZXEwMkZBVysvdWN6akMxZDFsOTg1eVlqY21C?=
 =?utf-8?B?aEhXM3dyUHh2bWFHeEJldDJtOFdmN1FQc0VZOHRuYlg4czFjUkNxQjNTTjB4?=
 =?utf-8?B?emVYbldSSXBEcW1ucllNL21pL09IdzJKWWhRSGoxTkZlaFcrS1VKY1B2dVZs?=
 =?utf-8?B?UGNqNlE1d2NPVDUwT2ExemZ0MlBPaHMydFpaTjZyNGhDdG5hQmd6ZzZaajVV?=
 =?utf-8?B?bE5SdkZQZjQvS09hMGkvOFlSOE9SaFkvb1hsRE9nMHFacEw2T3FmOVhaL05h?=
 =?utf-8?B?bUg1YmNRTnRWN0k0eERENGxLbHZXdWxscDQvcGNoZm00c1lVdmFSbkxRWFgv?=
 =?utf-8?B?KzVQUktiWjNiMStndGZyZm5DanE0dVJUWStaVTNGWFJhUFA5RlJ3dVYrdVlG?=
 =?utf-8?B?UGNrMGpwNTRubDc1NzB5RnFKbk5yRkkwQ2ZKSGlXTUJUTUpEVVUvLzhwTTZt?=
 =?utf-8?B?YVZtSS8zNWpRWWpoNE9lczh5L2k1U2psQjl0VmxhcXFPVGJXVHcrbXAyV0ho?=
 =?utf-8?B?SHN1RC9oOVRYSFRMdko5aXE0UnZHU2JySnRleTlrODM1MkpoQ3N4ajNSbUgw?=
 =?utf-8?B?c25kTmtyTjAwNG9HTmk0OVkzaWJSSlZ6d2hXeTNKZnR3L2JMaHV0c1p6VXJK?=
 =?utf-8?B?dmttNExLUU5XUHMxSHQxN1NnaWgxNTkvMU5NMkg4T3F6dkltSUhmZWNZaXYy?=
 =?utf-8?B?WHR5T29qQXlWNHhkRXpYR0xZbXRMeTRudU9rNjlrR2wzRzhNR2FDTlFmYmk3?=
 =?utf-8?B?djRYcHBvSXBsNW5SSmFha0cvRVpUZjl0V3RHQ2xEdUJxbDNGeVFmNUwrbkdL?=
 =?utf-8?B?OGcxQkRZck1qaWR2V1VRMDVsU2lUNVI3SmU1eS93K0EzVElQa0lnd1I3VGQy?=
 =?utf-8?B?MDYxUFYwOG8xdEUycWlhdnVHZGkwWmYwSnh6ZnUvTVBEbTh4SDdEaHhPc2dl?=
 =?utf-8?B?M0ladEFST2pFbkFJU0pzcUlPUTdINWtMdkNvOCtSWWtrYkNZOVBORXJKSTlm?=
 =?utf-8?B?MXpUb3RWMkxwR2xJTHFRZVRSVXE1dVpCK0JhVkl4clN3YUNFaUZKbDZCK0ZY?=
 =?utf-8?B?OFF4M0FRTG5odTFTSzArNlFxNVZoaEZlUzZUWFBqZUZmT3o1alZWQzJDNkhC?=
 =?utf-8?B?UTVTWWZLT2hzWldaMmhnT0hQd1FEaEoxYVcxZzkzTzV4Qmxnd2hxL0crelZH?=
 =?utf-8?B?NGFoZzJRU2VCYVYwdnRIWkpFUWdmQ0haeFExUWxLbGtoK0lFZVB3cVNQOWRT?=
 =?utf-8?B?YVdMWG9SY1FHdXpCZGZXejYyS1pSRVlxR0MvZXo1cEZKRWcxQ2pmTVpsb2Zt?=
 =?utf-8?B?YlZ1OU5ETnJxSTk0cUVjLzI0MnFqYmNXTUxubUp2QUNRc2pFUXcyY0o0Wnpr?=
 =?utf-8?B?MG5HY3Eza3MrN0U0YWVEc3FINVVUbkNueWFHZjNDYm1kL1lnZkVlRFBHSXl4?=
 =?utf-8?B?U3ZSSUlyTEF3UzR2S3NmN0pmc05reTVDdi9wTkc2MGtmb0lMWUpPdWtqdVBr?=
 =?utf-8?B?RWt1NkJCTGNJNzgzL3IwTlRON0t4YjVmaHVGU3VvNERQQUthT2hQcVNVVzNJ?=
 =?utf-8?B?WVFyaGdtNTl2cmQxWW5TZFNwRWdTRjVZa3RET3JlUkZiaVlHNFRpaDNSZThD?=
 =?utf-8?B?M0FDUzZ0Y0JkbjhPUEl6dUtHdFRHdHBNZTZOQXduaHVCV2N1WDBxRzJjSEdU?=
 =?utf-8?B?V1dzenBuVjZGWVA5OWU4U1JXYWNWSlh2RGVOZFIyYWVuZTJnYWdwQmRHNlZo?=
 =?utf-8?B?alBqQmZTaHhVWFpjWXA4TzBURmtSc3dLZFEwYXdtellXbmdoc201dUkvTmxs?=
 =?utf-8?B?ZkZPR2kyR2k4YUJmODl0Vm5NUG1MZC9CTFgwUWVhbVczVWY2YWdFZ2J0Z1RH?=
 =?utf-8?B?VUx4czJqdWRjTkhSUmxEV2htaStlYzJTU2YzMW1ZY0ZiNytQdFAxSzVDejZl?=
 =?utf-8?B?Q1BLSDRkZEV5bWdLVXI4eDlJSUU5ZWNEVnFrL3UzT3N4SlZmaTBlMGNJVEVX?=
 =?utf-8?Q?8Fn9ErDSPxT0zYfl4m1RvCn7h?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bc9ec34-b4bf-411a-f6df-08da6322d010
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 09:50:40.0594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tPe8nFSjbf14l1/LybhYbfQPmgjTSBRayjGaWQP4mvlXeWPxPiNdBmRueMZijvV8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0191
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 11.07.22 um 11:37 schrieb Greg Kroah-Hartman:
> On Mon, Jul 11, 2022 at 11:29:53AM +0200, Christian König wrote:
>> Hi Greg & Alex
>>
>> why is that patch picked up for stable? Or are we backporting IP based
>> discovery?
> New device ids are usually added to stable trees as they are "trivial".

Ah! Ok, sounds like a misunderstanding.

For the background this is *not* a new device id, but rather changes the 
way the existing device ids are discovered.

Instead of a table with device ids and hard coded list of hw blocks 
inside a device, we now look at a VBIOS table to determine which hw 
version/blocks are present.

So yes, this might enable new hardware but it's most likely not trivial 
enough to be backported.

>> If yes, is that wise? IIRC we had quite a number of typos etc.. in the
>> initial patches.
> If this commit is incorrect, we will be glad to drop it, or add any
> needed add-on commits.  Which do you want to see happen here?

Alex, that is mostly a question for you.

Thanks,
Christian.

>
> thanks,
>
> greg k-h