Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <459bb032c68be7c5be682d90462becfbb17ccda8.camel@mediatek.com>
Subject: Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
From:   Johnson Wang <johnson.wang@mediatek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <ulf.hansson@linaro.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>
CC:     <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>,
        <Project_Global_Chrome_Upstream_Group@mediatek.com>
Date:   Mon, 11 Jul 2022 20:03:46 +0800
In-Reply-To: <c8f8f5f4-173e-797d-e060-e5eaac7ca822@linaro.org>
References: <20220707054710.1396-1-johnson.wang@mediatek.com>
         <41e17a56-5cb0-8e90-c7ae-a7a56de986d0@linaro.org>
         <3216ec92952c7d722feaeb76986e0a6a54340646.camel@mediatek.com>
         <c8f8f5f4-173e-797d-e060-e5eaac7ca822@linaro.org>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2022-07-11 at 13:02 +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 09:30, Johnson Wang wrote:
> > On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
> > > On 07/07/2022 07:47, Johnson Wang wrote:
> > > > This commit adds dt-binding documentation of mmc for MediaTek
> > > > MT8188 SoC
> > > > platform.
> > > > 
> > > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > index 2a2e9fa8c188..3fbf33ad4f7c 100644
> > > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > > > @@ -32,6 +32,9 @@ properties:
> > > >        - items:
> > > >            - const: mediatek,mt8186-mmc
> > > >            - const: mediatek,mt8183-mmc
> > > > +      - items:
> > > > +          - const: mediatek,mt8188-mmc
> > > 
> > > You duplicate quite a lot. Use enum.
> > > 
> > > Best regards,
> > > Krzysztof
> > 
> > Hi Krzysztof,
> > 
> > Thanks for you suggestion.
> > 
> > I will use 'enum' to place this compatible strings.
> > 
> > Just like this:
> > - items:
> >     - enum:
> >         - mediatek,mt8186-mmc
> >         - mediatek,mt8188-mmc
> >         - mediatek,mt8192-mmc
> >         - mediatek,mt8195-mmc
> >     - const: mediatek,mt8183-mmc
> > 
> > Moreover, it seems that missing an "items:" between oneOf and enum
> > in
> > the compatible property.
> > Is my understanding wrong?
> 
> I did not propose to remove items, so where are they missing? Not
> sure
> what you are asking about...
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

Sorry for the confusion.
That was my misunderstanding. Please ignore it...

BRs,
Johnson Wang