Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <81ea189fd671947efc61000a745599a4b0573370.camel@linux.ibm.com>
Subject: Re: [PATCH] ima/evm: Fix potential memory leak in ima_init_crypto()
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Jianglei Nie <niejianglei2021@163.com>, dmitry.kasatkin@gmail.com,
        jmorris@namei.org, serge@hallyn.com
Cc:     linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 11 Jul 2022 08:04:01 -0400
In-Reply-To: <20220711072202.2319030-1-niejianglei2021@163.com>
References: <20220711072202.2319030-1-niejianglei2021@163.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2022-07-11 at 15:22 +0800, Jianglei Nie wrote:
> This patch adds the missing kfree() for ima_algo_array allocated by
> kcalloc() to avoid potential memory leak.

Missing is the reason that ima_algo_array is being freed.

Perhaps something like, 
"On failure to allocate the SHA1 tfm, IMA fails to initialize and exits
without freeing the ima_algo_array.   Add the missing kfree() for
ima_algo_array to avoid the potential memory leak."

thanks,

Mimi