Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3295739imw; Mon, 11 Jul 2022 06:04:32 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uIWaHQrQILlFalk+pRh47J9Z2xhLWmKnESVOMRP6NHr8ZFQIzFAx2wJ0USqoj4A15KiqmC X-Received: by 2002:a63:5a4f:0:b0:412:f69c:8762 with SMTP id k15-20020a635a4f000000b00412f69c8762mr15691782pgm.506.1657544672164; Mon, 11 Jul 2022 06:04:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657544672; cv=none; d=google.com; s=arc-20160816; b=XIwzxjkRc2k8LJb598ro5vj+Gx9xJlnvhJYkJNmzYAnnpNznEu0JigX0WSwHn47JJX qh2pK5lldv3KeYhBPcBaCEksD/pjB1GPnjXDfwjwV91a0INioU9bjt0O30SnJ71Epo8n ZmSyI4eKkXkrfxwIJnjEI97q+F955lrBSWP4zNAgzFF1Z5MYVzY+7wpwadZuvlkh0Nwj U9xyImQ5sIFy2ijcv4xltH64dYHHwWFAzyG3Vxu9Rs4hmXcgxN7kwdJWk36RTH3kx20N I1s5zLEWJlPV6axKZQXm7ujvZyNrO/GiYtE04S1ziCrx9uyxx2YzeUqu536dEG2Ofti0 IX5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=N1Au1sCNeLEVzE5yuJiy6D1CMqGqOEhc0JaB3fgl/XE=; b=t09LWneQF6sdQVekR74Ixz1Mv5jdHaCG+43wjDYIFhvGwcoKH6J66u/G+UMz7jCJJ2 H4eD5qIYpWlJNjK/wt8QEkleo5QoMHxwAHdYU/zg7GtMg9zNybM9qfzSMUcjluO16bIw 1+tgcsYE89oqQiFyvdhoYU64NPPB8pmksJETFy1F2MOxcOsaeNInihcbc4b4DIywyrYJ wy39Fv5pvP1bBBq8/aEjrqJGEqKhbwrBFedgs4LnfJru9dMCU5enxVC2q0O4KAFtZMae DwDIKLcmynYulCjuMQ04i4uWzXYh5C9CjWZAC2W3uLNKOi3Q7Q8IO25ys5TTgBL5hSvf qT4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=sDiKyS7A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f21-20020a056a0022d500b0051c44065606si11095425pfj.357.2022.07.11.06.04.19; Mon, 11 Jul 2022 06:04:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=sDiKyS7A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230100AbiGKM6Y (ORCPT + 99 others); Mon, 11 Jul 2022 08:58:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232203AbiGKM5l (ORCPT ); Mon, 11 Jul 2022 08:57:41 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC2D05B051; Mon, 11 Jul 2022 05:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657544259; x=1689080259; h=from:to:cc:subject:date:message-id; bh=N1Au1sCNeLEVzE5yuJiy6D1CMqGqOEhc0JaB3fgl/XE=; b=sDiKyS7AYiYlKi5iudkdb0ePSbL0Af3IPoiOwohelsW1ZjbREA4aH3fS pwQecMjP8qVbLMnwLj3c2nqZHqKk8KDSSCqiUTnTy7UpA1sMO/tX5GWQ4 /KuUh1S7eH3f42bLUdTWTa87ji6MxP2LtZh9WQ2oLa7YCwHoyaeMPdex1 Y=; Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 11 Jul 2022 05:57:38 -0700 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 11 Jul 2022 05:57:37 -0700 X-QCInternal: smtphost Received: from vpolimer-linux.qualcomm.com ([10.204.67.235]) by ironmsg02-blr.qualcomm.com with ESMTP; 11 Jul 2022 18:27:08 +0530 Received: by vpolimer-linux.qualcomm.com (Postfix, from userid 463814) id B9AAD3E38; Mon, 11 Jul 2022 18:27:06 +0530 (IST) From: Vinod Polimera To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: Vinod Polimera , linux-kernel@vger.kernel.org, robdclark@gmail.com, dianders@chromium.org, swboyd@chromium.org, quic_kalyant@quicinc.com, dmitry.baryshkov@linaro.org, quic_khsieh@quicinc.com, quic_vproddut@quicinc.com, bjorn.andersson@linaro.org, quic_aravindh@quicinc.com, quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com Subject: [PATCH v6 00/10] Add PSR support for eDP Date: Mon, 11 Jul 2022 18:26:54 +0530 Message-Id: <1657544224-10680-1-git-send-email-quic_vpolimer@quicinc.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes in v2: - Use dp bridge to set psr entry/exit instead of dpu_enocder. - Don't modify whitespaces. - Set self refresh aware from atomic_check. - Set self refresh aware only if psr is supported. - Provide a stub for msm_dp_display_set_psr. - Move dp functions to bridge code. Changes in v3: - Change callback names to reflect atomic interfaces. - Move bridge callback change to separate patch as suggested by Dmitry. - Remove psr function declaration from msm_drv.h. - Set self_refresh_aware flag only if psr is supported. - Modify the variable names to simpler form. - Define bit fields for PSR settings. - Add comments explaining the steps to enter/exit psr. - Change DRM_INFO to drm_dbg_db. Changes in v4: - Move the get crtc functions to drm_atomic. - Add atomic functions for DP bridge too. - Add ternary operator to choose eDP or DP ops. - Return true/false instead of 1/0. - mode_valid missing in the eDP bridge ops. - Move the functions to get crtc into drm_atomic.c. - Fix compilation issues. - Remove dpu_assign_crtc and get crtc from drm_enc instead of dpu_enc. - Check for crtc state enable while reserving resources. Changes in v5: - Move the mode_valid changes into a different patch. - Complete psr_op_comp only when isr is set. - Move the DP atomic callback changes to a different patch. - Get crtc from drm connector state crtc. - Move to separate patch for check for crtc state enable while reserving resources. Changes in v6: - Remove crtc from dpu_encoder_virt struct. - fix crtc check during vblank toggle crtc. - Misc changes. Signed-off-by: Sankeerth Billakanti Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Vinod Polimera (10): drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc drm: add helper functions to retrieve old and new crtc drm/msm/dp: use atomic callbacks for DP bridge ops drm/msm/dp: Add basic PSR support for eDP drm/msm/dp: use the eDP bridge ops to validate eDP modes drm/bridge: use atomic enable/disable callbacks for panel bridge drm/bridge: add psr support for panel bridge callbacks drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources drivers/gpu/drm/bridge/panel.c | 68 ++++++++-- drivers/gpu/drm/drm_atomic.c | 60 +++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 17 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 56 +++++---- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 8 -- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- drivers/gpu/drm/msm/dp/dp_catalog.c | 81 ++++++++++++ drivers/gpu/drm/msm/dp/dp_catalog.h | 4 + drivers/gpu/drm/msm/dp/dp_ctrl.c | 73 +++++++++++ drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 + drivers/gpu/drm/msm/dp/dp_display.c | 31 +++-- drivers/gpu/drm/msm/dp/dp_display.h | 2 + drivers/gpu/drm/msm/dp/dp_drm.c | 184 ++++++++++++++++++++++++++-- drivers/gpu/drm/msm/dp/dp_drm.h | 9 +- drivers/gpu/drm/msm/dp/dp_link.c | 36 ++++++ drivers/gpu/drm/msm/dp/dp_panel.c | 22 ++++ drivers/gpu/drm/msm/dp/dp_panel.h | 6 + drivers/gpu/drm/msm/dp/dp_reg.h | 27 ++++ include/drm/drm_atomic.h | 7 ++ 19 files changed, 631 insertions(+), 65 deletions(-) -- 2.7.4