Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3296384imw; Mon, 11 Jul 2022 06:05:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sZK7r6PCIETL0hPMQjD/NBeAJjJHUR0pbv+ku0LPfpP5UD2ewewH7GDz3Nq6Ue5bXWWxzC X-Received: by 2002:aa7:8e17:0:b0:528:9f8d:ad38 with SMTP id c23-20020aa78e17000000b005289f8dad38mr18588188pfr.4.1657544703102; Mon, 11 Jul 2022 06:05:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657544703; cv=none; d=google.com; s=arc-20160816; b=Dw/CHtxcxAj92Z57+B6wyvniKWy81uDyPEjG6nZalxwa3MX2ME7ecyoDM4vV5EL1vg CoSAw1jLd6quUDxX+LyIXf2mqWB2+Wgjrr4FhwxePUWNCabu+HVU+VX50ufgInAkPPBq +v6YAs6ZmreRY9S3pJXwgjAwkaGv/Z0FNhEFCTeHGrMarQfr9CMNMS+xMv7cxXbdaJoJ 6FWPEDcL99sY9t6oimu4Tl9VSr5VA8Gjy21qh0QHlJ+W1s7A5Fn5lhb3tGoZD0OyF7ST ODYeXK73ayT8jpq6SUC+/ywBoo/OxMuftmjg9Rhw9MiKrx5LIjYDA8Jai7mldDD1sJsg c0Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=eluVtVV6YxZiX9IA4reDOwHLCow6fgP8gJauEX5eTDs=; b=eoYVG8K6C4vb9bGqLw3eh/K1D5AIeRvaSBdnl4cjxu561VKuy7zLAGQhKu8jppgewW 9FDIcl+oLZX+SFukxYR9J9fOy3U1LlVPRBWUW4wmbQdmC5srBh9frYToE4lUP0lFUwmB pOViQz60GoFBQ15cn7umFUG6MWcwgK6+qyqxFIgSL/vwd2lkEbs/ak1czTSTOMSRKE7T f6bYx2pYCv4qja8y/PLkdjdk1uoYriPVAaDuGTpYzIbJvGHTXY6bTnxXSfinZRaZMN5X +VR2hynVWCyfLDu87gmvhsAZCW+QnMP6ct57Esam9b9PxXQu/EItBdNY4Irp+GHTSN/Q Wyug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=aJt3Q60G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z25-20020a056a001d9900b00524cfcbae7csi8468025pfw.41.2022.07.11.06.04.50; Mon, 11 Jul 2022 06:05:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=aJt3Q60G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230464AbiGKM5v (ORCPT + 99 others); Mon, 11 Jul 2022 08:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232187AbiGKM5i (ORCPT ); Mon, 11 Jul 2022 08:57:38 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6F5E5508E; Mon, 11 Jul 2022 05:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657544257; x=1689080257; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=eluVtVV6YxZiX9IA4reDOwHLCow6fgP8gJauEX5eTDs=; b=aJt3Q60GorfD3CFTpNRXzxgbwczWhg0fcKklGoZjRQ9xQaaFmv28do/I X0Vt4YNynQIZauviNxeZ62Lp8QSN/9EXAPH3fwLk44/TgspFGpLZvGZFy 4eScd5Tn7uPqRdnI3OmLJSF52gNeCCQ89Bsw+EfnyxofD6DzxdScXI6Uk Y=; Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 11 Jul 2022 05:57:36 -0700 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 11 Jul 2022 05:57:35 -0700 X-QCInternal: smtphost Received: from vpolimer-linux.qualcomm.com ([10.204.67.235]) by ironmsg02-blr.qualcomm.com with ESMTP; 11 Jul 2022 18:27:11 +0530 Received: by vpolimer-linux.qualcomm.com (Postfix, from userid 463814) id 8E15A3E51; Mon, 11 Jul 2022 18:27:07 +0530 (IST) From: Vinod Polimera To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: Vinod Polimera , linux-kernel@vger.kernel.org, robdclark@gmail.com, dianders@chromium.org, swboyd@chromium.org, quic_kalyant@quicinc.com, dmitry.baryshkov@linaro.org, quic_khsieh@quicinc.com, quic_vproddut@quicinc.com, bjorn.andersson@linaro.org, quic_aravindh@quicinc.com, quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com Subject: [PATCH v6 10/10] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources Date: Mon, 11 Jul 2022 18:27:04 +0530 Message-Id: <1657544224-10680-11-git-send-email-quic_vpolimer@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1657544224-10680-1-git-send-email-quic_vpolimer@quicinc.com> References: <1657544224-10680-1-git-send-email-quic_vpolimer@quicinc.com> X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to KMS documentation, The driver must not release any shared resources if active is set to false but enable still true. Fixes: ccc862b957c6 ("drm/msm/dpu: Fix reservation failures in modeset") Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 5dfb56a..02a71d1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -592,7 +592,7 @@ static int dpu_encoder_virt_atomic_check( if (drm_atomic_crtc_needs_modeset(crtc_state)) { dpu_rm_release(global_state, drm_enc); - if (!crtc_state->active_changed || crtc_state->active) + if (!crtc_state->active_changed || crtc_state->enable) ret = dpu_rm_reserve(&dpu_kms->rm, global_state, drm_enc, crtc_state, topology); } -- 2.7.4