Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <YrShFXRLtRt6T/j+@risky> <CAJfpegvH1EMS_469yOyUP9f=eCAEqzhyngm7h=YLRExeRdPEaw@mail.gmail.com>
In-Reply-To: <CAJfpegvH1EMS_469yOyUP9f=eCAEqzhyngm7h=YLRExeRdPEaw@mail.gmail.com>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Mon, 11 Jul 2022 15:59:15 +0200
Message-ID: <CAJfpegurW7==LEp2yXWMYdBYXTZN4HCMMVJPu-f8yvHVbu79xQ@mail.gmail.com>
Subject: Re: strange interaction between fuse + pidns
To:     Tycho Andersen <tycho@tycho.pizza>
Cc:     Eric Biederman <ebiederm@xmission.com>,
        Christian Brauner <brauner@kernel.org>,
        fuse-devel <fuse-devel@lists.sourceforge.net>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: multipart/mixed; boundary="000000000000be1cf105e387f5bd"
Precedence: bulk

--000000000000be1cf105e387f5bd
Content-Type: text/plain; charset="UTF-8"

On Mon, 11 Jul 2022 at 12:35, Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> Can you try the attached untested patch?

Updated patch to avoid use after free on req->args.

Still mostly untested.

Thanks,
Miklos

--000000000000be1cf105e387f5bd
Content-Type: text/x-patch; charset="US-ASCII"; name="fuse-allow-flush-to-be-killed-v2.patch"
Content-Disposition: attachment; 
	filename="fuse-allow-flush-to-be-killed-v2.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_l5gt93xl0>
X-Attachment-Id: f_l5gt93xl0

LS0tCiBmcy9mdXNlL2Rldi5jICAgIHwgICAyMyArKysrKysrKysrKysrKysrKy0tLS0tLQogZnMv
ZnVzZS9maWxlLmMgICB8ICAgIDEgKwogZnMvZnVzZS9mdXNlX2kuaCB8ICAgIDMgKysrCiAzIGZp
bGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgotLS0gYS9mcy9m
dXNlL2Rldi5jCisrKyBiL2ZzL2Z1c2UvZGV2LmMKQEAgLTM5Nyw2ICszOTcsMTIgQEAgc3RhdGlj
IHZvaWQgcmVxdWVzdF93YWl0X2Fuc3dlcihzdHJ1Y3QgZgogCQkJcmVxLT5vdXQuaC5lcnJvciA9
IC1FSU5UUjsKIAkJCXJldHVybjsKIAkJfQorCQlpZiAocmVxLT5hcmdzLT5raWxsYWJsZSkgewor
CQkJcmVxLT5vdXQuaC5lcnJvciA9IC1FSU5UUjsKKwkJCS8qIGZ1c2VfcmVxdWVzdF9lbmQoKSB3
aWxsIGRyb3AgZmluYWwgcmVmICovCisJCQlzcGluX3VubG9jaygmZmlxLT5sb2NrKTsKKwkJCXJl
dHVybjsKKwkJfQogCQlzcGluX3VubG9jaygmZmlxLT5sb2NrKTsKIAl9CiAKQEAgLTQ3OCw2ICs0
ODQsOCBAQCBzdGF0aWMgdm9pZCBmdXNlX2FyZ3NfdG9fcmVxKHN0cnVjdCBmdXNlCiAJcmVxLT5h
cmdzID0gYXJnczsKIAlpZiAoYXJncy0+ZW5kKQogCQlfX3NldF9iaXQoRlJfQVNZTkMsICZyZXEt
PmZsYWdzKTsKKwlpZiAoIWFyZ3MtPm91dF9udW1hcmdzKQorCQlfX3NldF9iaXQoRlJfTk9PVVRB
UkcsICZyZXEtPmZsYWdzKTsKIH0KIAogc3NpemVfdCBmdXNlX3NpbXBsZV9yZXF1ZXN0KHN0cnVj
dCBmdXNlX21vdW50ICpmbSwgc3RydWN0IGZ1c2VfYXJncyAqYXJncykKQEAgLTQ4Niw2ICs0OTQs
OCBAQCBzc2l6ZV90IGZ1c2Vfc2ltcGxlX3JlcXVlc3Qoc3RydWN0IGZ1c2VfCiAJc3RydWN0IGZ1
c2VfcmVxICpyZXE7CiAJc3NpemVfdCByZXQ7CiAKKwlXQVJOX09OKGFyZ3MtPmtpbGxhYmxlICYm
IGFyZ3MtPm91dF9udW1hcmdzKTsKKwogCWlmIChhcmdzLT5mb3JjZSkgewogCQlhdG9taWNfaW5j
KCZmYy0+bnVtX3dhaXRpbmcpOwogCQlyZXEgPSBmdXNlX3JlcXVlc3RfYWxsb2MoZm0sIEdGUF9L
RVJORUwgfCBfX0dGUF9OT0ZBSUwpOwpAQCAtNDk0LDcgKzUwNCw4IEBAIHNzaXplX3QgZnVzZV9z
aW1wbGVfcmVxdWVzdChzdHJ1Y3QgZnVzZV8KIAkJCWZ1c2VfZm9yY2VfY3JlZHMocmVxKTsKIAog
CQlfX3NldF9iaXQoRlJfV0FJVElORywgJnJlcS0+ZmxhZ3MpOwotCQlfX3NldF9iaXQoRlJfRk9S
Q0UsICZyZXEtPmZsYWdzKTsKKwkJaWYgKCFhcmdzLT5raWxsYWJsZSkKKwkJCV9fc2V0X2JpdChG
Ul9GT1JDRSwgJnJlcS0+ZmxhZ3MpOwogCX0gZWxzZSB7CiAJCVdBUk5fT04oYXJncy0+bm9jcmVk
cyk7CiAJCXJlcSA9IGZ1c2VfZ2V0X3JlcShmbSwgZmFsc2UpOwpAQCAtMTkxMywxMyArMTkyNCwx
MyBAQCBzdGF0aWMgc3NpemVfdCBmdXNlX2Rldl9kb193cml0ZShzdHJ1Y3QKIAlzZXRfYml0KEZS
X0xPQ0tFRCwgJnJlcS0+ZmxhZ3MpOwogCXNwaW5fdW5sb2NrKCZmcHEtPmxvY2spOwogCWNzLT5y
ZXEgPSByZXE7Ci0JaWYgKCFyZXEtPmFyZ3MtPnBhZ2VfcmVwbGFjZSkKLQkJY3MtPm1vdmVfcGFn
ZXMgPSAwOwotCi0JaWYgKG9oLmVycm9yKQorCWlmIChvaC5lcnJvciB8fCB0ZXN0X2JpdChGUl9O
T09VVEFSRywgJnJlcS0+ZmxhZ3MpKSB7CiAJCWVyciA9IG5ieXRlcyAhPSBzaXplb2Yob2gpID8g
LUVJTlZBTCA6IDA7Ci0JZWxzZQorCX0gZWxzZSB7CisJCWlmICghcmVxLT5hcmdzLT5wYWdlX3Jl
cGxhY2UpCisJCQljcy0+bW92ZV9wYWdlcyA9IDA7CiAJCWVyciA9IGNvcHlfb3V0X2FyZ3MoY3Ms
IHJlcS0+YXJncywgbmJ5dGVzKTsKKwl9CiAJZnVzZV9jb3B5X2ZpbmlzaChjcyk7CiAKIAlzcGlu
X2xvY2soJmZwcS0+bG9jayk7Ci0tLSBhL2ZzL2Z1c2UvZmlsZS5jCisrKyBiL2ZzL2Z1c2UvZmls
ZS5jCkBAIC01MDQsNiArNTA0LDcgQEAgc3RhdGljIGludCBmdXNlX2ZsdXNoKHN0cnVjdCBmaWxl
ICpmaWxlLAogCWFyZ3MuaW5fYXJnc1swXS5zaXplID0gc2l6ZW9mKGluYXJnKTsKIAlhcmdzLmlu
X2FyZ3NbMF0udmFsdWUgPSAmaW5hcmc7CiAJYXJncy5mb3JjZSA9IHRydWU7CisJYXJncy5raWxs
YWJsZSA9IHRydWU7CiAKIAllcnIgPSBmdXNlX3NpbXBsZV9yZXF1ZXN0KGZtLCAmYXJncyk7CiAJ
aWYgKGVyciA9PSAtRU5PU1lTKSB7Ci0tLSBhL2ZzL2Z1c2UvZnVzZV9pLmgKKysrIGIvZnMvZnVz
ZS9mdXNlX2kuaApAQCAtMjYxLDYgKzI2MSw3IEBAIHN0cnVjdCBmdXNlX2FyZ3MgewogCWJvb2wg
cGFnZV96ZXJvaW5nOjE7CiAJYm9vbCBwYWdlX3JlcGxhY2U6MTsKIAlib29sIG1heV9ibG9jazox
OworCWJvb2wga2lsbGFibGU6MTsKIAlzdHJ1Y3QgZnVzZV9pbl9hcmcgaW5fYXJnc1szXTsKIAlz
dHJ1Y3QgZnVzZV9hcmcgb3V0X2FyZ3NbMl07CiAJdm9pZCAoKmVuZCkoc3RydWN0IGZ1c2VfbW91
bnQgKmZtLCBzdHJ1Y3QgZnVzZV9hcmdzICphcmdzLCBpbnQgZXJyb3IpOwpAQCAtMzE0LDYgKzMx
NSw3IEBAIHN0cnVjdCBmdXNlX2lvX3ByaXYgewogICogRlJfRklOSVNIRUQ6CQlyZXF1ZXN0IGlz
IGZpbmlzaGVkCiAgKiBGUl9QUklWQVRFOgkJcmVxdWVzdCBpcyBvbiBwcml2YXRlIGxpc3QKICAq
IEZSX0FTWU5DOgkJcmVxdWVzdCBpcyBhc3luY2hyb25vdXMKKyAqIEZSX05PT1VUQVJHOgkJcmVw
bHkgaXMgb25seSBoZWFkZXIKICAqLwogZW51bSBmdXNlX3JlcV9mbGFnIHsKIAlGUl9JU1JFUExZ
LApAQCAtMzI4LDYgKzMzMCw3IEBAIGVudW0gZnVzZV9yZXFfZmxhZyB7CiAJRlJfRklOSVNIRUQs
CiAJRlJfUFJJVkFURSwKIAlGUl9BU1lOQywKKwlGUl9OT09VVEFSRywKIH07CiAKIC8qKgo=
--000000000000be1cf105e387f5bd--