Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e87feac9-e00e-1c83-79fe-c790e2f99e15@allwinnertech.com>
Date:   Mon, 11 Jul 2022 22:22:57 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] extcon: Add EXTCON_DISP_CVBS and EXTCON_DISP_EDP
Content-Language: en-US
To:     Chanwoo Choi <cwchoi00@gmail.com>, myungjoo.ham@samsung.com,
        cw00.choi@samsung.com
Cc:     linux-kernel@vger.kernel.org,
        allwinner-opensource-support@allwinnertech.com
References: <20220708095714.127736-1-michael@allwinnertech.com>
 <0cef31e4-7e07-087a-1d4b-241cdce76970@gmail.com>
From:   Michael Wu <michael@allwinnertech.com>
In-Reply-To: <0cef31e4-7e07-087a-1d4b-241cdce76970@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/9/2022 9:03 AM, Chanwoo Choi wrote:
> On 22. 7. 8. 18:57, Michael Wu wrote:
>> Add EXTCON_DISP_CVBS for Composite Video Broadcast Signal.
>> Add EXTCON_DISP_EDP for Embedded Display Port
>>
>> [1] https://en.wikipedia.org/wiki/Composite_video
>> [2] https://en.wikipedia.org/wiki/DisplayPort#eDP
>>
>> Signed-off-by: Michael Wu <michael@allwinnertech.com>
>> ---
>>   drivers/extcon/extcon.c | 10 ++++++++++
>>   include/linux/extcon.h  |  2 ++
>>   2 files changed, 12 insertions(+)
>>
>> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
>> index d3a32b8064994..774607a616f7b 100644
>> --- a/drivers/extcon/extcon.c
>> +++ b/drivers/extcon/extcon.c
>> @@ -167,6 +167,16 @@ static const struct __extcon_info {
>>   		.id = EXTCON_DISP_HMD,
>>   		.name = "HMD",
>>   	},
>> +	[EXTCON_DISP_CVBS] = {
>> +		.type = EXTCON_TYPE_DISP,
>> +		.id = EXTCON_DISP_CVBS,
>> +		.name = "CVBS",
>> +	},
>> +	[EXTCON_DISP_EDP] = {
>> +		.type = EXTCON_TYPE_DISP,
>> +		.id = EXTCON_DISP_EDP,
>> +		.name = "EDP",
>> +	},
>>   
>>   	/* Miscellaneous external connector */
>>   	[EXTCON_DOCK] = {
>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
>> index 685401d94d398..3c45c3846fe94 100644
>> --- a/include/linux/extcon.h
>> +++ b/include/linux/extcon.h
>> @@ -76,6 +76,8 @@
>>   #define EXTCON_DISP_VGA		43	/* Video Graphics Array */
>>   #define EXTCON_DISP_DP		44	/* Display Port */
>>   #define EXTCON_DISP_HMD		45	/* Head-Mounted Display */
>> +#define EXTCON_DISP_CVBS	46	/* Composite Video Broadcast Signal */
>> +#define EXTCON_DISP_EDP		47	/* Embedded Display Port */
>>   
>>   /* Miscellaneous external connector */
>>   #define EXTCON_DOCK		60
> 
> Applied it. Thanks.
> 
> Do you have a plan to send extcon driver with newly added connector type?
> 

Hi Chanwoo,
Thank you for the inviting. I'd like to send more patches for extcon, 
unfortunately the SoCs I'm using only covers CVBS and EDP among the new 
connector types. Once I had a chance to verify a new type, I'll surely 
send it here.
BTW, should I send a patch-v2 with 'Reviewed-by Chanwoo Choi 
<cwchoi00@gmail.com>' or 'Acked-by Chanwoo Choi <cwchoi00@gmail.com>', 
or should I just wait?
Thanks again.

-- 
Regards,
Michael Wu