Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 08:38:42 -0600
From:   Rob Herring <robh@kernel.org>
To:     Vidya Sagar <vidyas@nvidia.com>
Cc:     kthota@nvidia.com, sagar.tv@gmail.com, lpieralisi@kernel.org,
        bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org,
        kishon@ti.com, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, jonathanh@nvidia.com,
        gustavo.pimentel@synopsys.com, linux-tegra@vger.kernel.org,
        thierry.reding@gmail.com, mmaddireddy@nvidia.com,
        jingoohan1@gmail.com, kw@linux.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 3/9] dt-bindings: PCI: tegra234: Add schema for
 tegra234 endpoint mode
Message-ID: <20220711143842.GA3840001-robh@kernel.org>
References: <20220707081301.29961-1-vidyas@nvidia.com>
 <20220707081301.29961-4-vidyas@nvidia.com>
 <1657196871.476299.1454231.nullmailer@robh.at.kernel.org>
 <afc9cd15-a895-792f-3f49-1dca3694b0f3@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <afc9cd15-a895-792f-3f49-1dca3694b0f3@nvidia.com>
Precedence: bulk

On Sat, Jul 09, 2022 at 08:03:45AM +0530, Vidya Sagar wrote:
> 
> 
> On 7/7/2022 5:57 PM, Rob Herring wrote:
> > External email: Use caution opening links or attachments
> > 
> > 
> > On Thu, 07 Jul 2022 13:42:55 +0530, Vidya Sagar wrote:
> > > Add support for PCIe controllers that operate in the endpoint mode
> > > in tegra234 chipset.
> > > 
> > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> > > ---
> > > V4:
> > > * Rebased on top of previous patch
> > > 
> > > V3:
> > > * New patch in this series
> > > 
> > >   .../bindings/pci/nvidia,tegra194-pcie-ep.yaml | 123 +++++++++++++++++-
> > >   1 file changed, 117 insertions(+), 6 deletions(-)
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.example.dtb: pcie-ep@141a0000: Unevaluated properties are not allowed ('nvidia,enable-ext-refclk' was unexpected)
> >          From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
> > 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://patchwork.ozlabs.org/patch/
> > 
> > This check can fail if there are any dependencies. The base for a patch
> > series is generally the most recent rc1.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit.
> 
> I did run 'make dt_binding_check' before sending the patches for review and
> didn't observe any issue. Just to make sure that I observe the same issue
> locally, I updated dtschema and gave DT_CHECKER_FLAGS=-m and yet didn't
> observe the tool reporting any issue.
> FWIW, I think I missed adding the documentation for
> 'nvidia,enable-ext-refclk' property. I'll add it and send again, but before
> that, I would like to see if my change addresses the issue correctly and
> also there are no other issues. Could you please help me with why I'm not
> observing the issue locally?

There's a fix for unevaluatedProperties that's only in the dtschema main 
branch and not yet in a release.

Rob