Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3396239imw; Mon, 11 Jul 2022 07:55:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s2Z1zuBCLICNrJxVvrxSjvXCE6JVXwLpNlx/6IoOhw9HstsjHNALujQNR0+73F6TDiILtA X-Received: by 2002:a17:907:3f1d:b0:726:c927:769b with SMTP id hq29-20020a1709073f1d00b00726c927769bmr18846226ejc.754.1657551357917; Mon, 11 Jul 2022 07:55:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657551357; cv=none; d=google.com; s=arc-20160816; b=uyxSXD3uv0v1Qsr1/h45oLFUfMoHpAU/s2rJLpHGrt+v0kvZ6MKXgxVqe8C7QjR+hg cRULJ6+mL37detCFfd2nyu/dn4RNa1eoiJkslQOuughWoqf4m7QZCgjpBRvuEguKk3wT xMoxcSGvbBGVxsVc/APbAfAX8ICV7xRBncsB5Edll8pXnFYg1dslqYV11puYFjvcoiyd 46yjinmm4WXnQxoMMq3HRVksFiEi2JqGlOa5ePOHyZcCC1FpG06GzVZJBRAeqklTSmzt iL2sfkF2Yy5SP2xXYsVtzmuV2OOA4f4HpNGpHbzs4eYtU/cEz4dG+0sEgglApcLJUG4u 6e9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=oYQhe+ipyu6UYMsRF8IIvAx/ixqfbYZKpt5fQb8dYu4=; b=kb16ffeTr0FfYbVdvvhvPSWdNbIEBPuDeNtHV4U6HXDVJ7NhEO5rufoUN4jddcmxoG j0dIqcS2FFyT16XsZ9b80Ihsw9o/3/GEXy27nogff+TJerGQM8WpVKdbxwmZXK8+KKww Tx8d5rR8WdaL+Kh0BTmL0byXMPVEw7O9B+p69n2Di51RHYW1QJ3RVfgrFJ/TBhe7jGIk w5CzFoTnLGXmZWeq6hNyARiikR9xhKNstgDhscpRr8MpiKTcZZNjvA7s1jmmd+8ipvmk QPfN7QoeOnEw7r4iVGtldlQlA5BJpLhtl74U8NbqXzaqwHPVQRrq5Rdmjqr2SAhuuTEj n+4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b63-20020a509f45000000b0043a9ecde711si11870826edf.388.2022.07.11.07.55.33; Mon, 11 Jul 2022 07:55:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbiGKOli (ORCPT + 99 others); Mon, 11 Jul 2022 10:41:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231519AbiGKOlc (ORCPT ); Mon, 11 Jul 2022 10:41:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D52FC6556C for ; Mon, 11 Jul 2022 07:41:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 906E3B80FE4 for ; Mon, 11 Jul 2022 14:41:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63BF9C341C8; Mon, 11 Jul 2022 14:41:27 +0000 (UTC) Date: Mon, 11 Jul 2022 10:41:25 -0400 From: Steven Rostedt To: "XueBing Chen" Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: use strscpy to replace strlcpy Message-ID: <20220711104125.1d9ba146@gandalf.local.home> In-Reply-To: <49ec0969.e32.181eda74871.Coremail.chenxuebing@jari.cn> References: <49ec0969.e32.181eda74871.Coremail.chenxuebing@jari.cn> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Jul 2022 22:26:12 +0800 (GMT+08:00) "XueBing Chen" wrote: > The strlcpy should not be used because it doesn't limit the source > length. Preferred is strscpy. That's not enough justification to make the switch. These calls are done at boot up. If there's a bug in the source, I rather have it crash. -- Steve > > Signed-off-by: XueBing Chen