Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Mon, 11 Jul 2022 17:50:05 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Daniel Latypov <dlatypov@google.com>
Cc:     brendanhiggins@google.com, davidgow@google.com,
        linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
        =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>,
        Mike Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3] kunit: tool: Enable virtio/PCI by default on UML
Message-ID: <20220711155005.lnebdh534ntmf4sv@houat>
References: <20220708162711.1309633-1-dlatypov@google.com>
 <20220711144651.yekrivauz3phkuvm@houat>
 <CAGS_qxp=UAJ19zQOZKP8ywPiNAj4wT80ubH2YW060mmADoqBcw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="62a7ggmdoypgfr4x"
Content-Disposition: inline
In-Reply-To: <CAGS_qxp=UAJ19zQOZKP8ywPiNAj4wT80ubH2YW060mmADoqBcw@mail.gmail.com>
Precedence: bulk


--62a7ggmdoypgfr4x
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 11, 2022 at 08:10:36AM -0700, Daniel Latypov wrote:
> On Mon, Jul 11, 2022 at 7:46 AM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > Unfortunately, this breaks the clock tests in next-20220711:
> > $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/clk/.kunit=
config  --raw_output
>=20
> Thanks, this is indeed an issue.
>=20
> I remember noticing this in early April.
> I incorrectly remembered that a fix had been sent.
>=20
> A more minimal reproducer:
> $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/clk
> 'clk-gate-test.clk_gate_test_enable'
>=20
> The part of the test that becomes problematic with this patch (i.e.
> enabling logic iomem) is the cast on line 143.
>=20
>    130  struct clk_gate_test_context {
>    131          void __iomem *fake_mem;
>    132          struct clk_hw *hw;
>    133          struct clk_hw *parent;
>    134          u32 fake_reg; /* Keep at end, KASAN can detect out of bou=
nds */
>    135  };
>    136
>    137  static struct clk_gate_test_context
> *clk_gate_test_alloc_ctx(struct kunit *test)
>    138  {
>    139          struct clk_gate_test_context *ctx;
>    140
>    141          test->priv =3D ctx =3D kunit_kzalloc(test, sizeof(*ctx),
> GFP_KERNEL);
>    142          KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx);
>    143          ctx->fake_mem =3D (void __force __iomem *)&ctx->fake_reg;
>    144
>    145          return ctx;
>    146  }
>=20
> A simple fix we could carry in the KUnit branch is this:
>=20
> diff --git a/drivers/clk/.kunitconfig b/drivers/clk/.kunitconfig
> index cdbc7d7deba9..2fbeb71316f8 100644
> --- a/drivers/clk/.kunitconfig
> +++ b/drivers/clk/.kunitconfig
> @@ -2,3 +2,4 @@ CONFIG_KUNIT=3Dy
>  CONFIG_COMMON_CLK=3Dy
>  CONFIG_CLK_KUNIT_TEST=3Dy
>  CONFIG_CLK_GATE_KUNIT_TEST=3Dy
> +CONFIG_UML_PCI_OVER_VIRTIO=3Dn

It works for me now thanks

Feel free to add my Tested-by

Maxime

--62a7ggmdoypgfr4x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYsxGrQAKCRDj7w1vZxhR
xZyqAQC4NkZsJpoYeowyQIVO4BfNLIn0HRfUGFWT5pUN6QP/MAD+NTf3aEmdrypM
+IdKY8hTsxBVo3BWv7sMzCpsAtqprgI=
=CyaJ
-----END PGP SIGNATURE-----

--62a7ggmdoypgfr4x--