Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 17:31:41 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        tony.luck@intel.com, x86@kernel.org,
        Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH 1/3] x86/MCE, EDAC/mce_amd: Add support for new
 MCA_SYND{1,2} registers
Message-ID: <YsxefXQDCiJ1zxLG@yaz-fattaah>
References: <20220418174440.334336-1-yazen.ghannam@amd.com>
 <20220418174440.334336-2-yazen.ghannam@amd.com>
 <Yr2CpuL+JHWblJMD@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yr2CpuL+JHWblJMD@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nf8SOul5FG/wB22N1aFIiiCQEM3uZZ5Gb7nTzNt+wWYPOzNcMiGE2mrV5v9A?=
 =?us-ascii?Q?bvBHru46909t/Cc1kXw1o84Sjp9f5pap3gJjCmS0NWO8xxAxJ7WXgKpClPnX?=
 =?us-ascii?Q?0W5PD8wVvBHjEjBXtrmrwW4afzj3kN3jw7wvwe8RnJtu8a8T4j+LXJQ2F9yX?=
 =?us-ascii?Q?gcSkFnow50je0970vkDXjEhEGaPWbN7LSDXQ2s93crqHyUGAWCZOkML2FX+h?=
 =?us-ascii?Q?QzSpfjlLhdT5L+YqP/MYCD8SpHMvHtrW0hrP9M/3na/+qUHx7dn8hfMiPFyi?=
 =?us-ascii?Q?KGF4cAeyyDxdEjibFZ0BMstukgoj8JiHhELK/bLYyUlF59Po09fcmnORWcoV?=
 =?us-ascii?Q?C+Gb+DlBzl8a7nAHQHZd3NMjGBEaIj5+ps5t6ndP5pSbzyM+sWkhiXhDjWsZ?=
 =?us-ascii?Q?9cM0gdfwTXLdp+oqwqubhtDmEvKS2OxNiiEuoR71ONF1v18Snqu7z9ToBJG9?=
 =?us-ascii?Q?ixz/YeoU+FIEJ27NLt5vQgcFtK4eVdSUEMDU8eYff2W2X31FQu1/mOWXEV4R?=
 =?us-ascii?Q?N6HMScfD7ZRVemgGzjqy6kMMF337PA/y7rqN/G6tYBxZ1AeV4lhAwKvyj+zT?=
 =?us-ascii?Q?qmCVQm3xR5V+MPAFxI9LlyU6T1mMV8mvzt8WjDZebkU8nRWghaDYnRZpmJGu?=
 =?us-ascii?Q?iFOU0KLHiJdcXGijFJF/80fiPeAwf/qyYwJfiTZ+IE6bX8qrdYPt39R2wl7k?=
 =?us-ascii?Q?KaEXB+M8CCQpimqLlPJpn+c0CmGye01jR/fMF8TXhx525clr1kA7DNB373y2?=
 =?us-ascii?Q?M1hNdLLmlJjD5nOtfYKNgFAd3bQjAb9Zy3BeJxy6oV1AFxVSwE3AL5fTybg3?=
 =?us-ascii?Q?b/P5qujsR2wY5ZXCIBlDOrzEZokkB/3Ru+jaEudUR9J1f5BqOU4BWJHTbl2r?=
 =?us-ascii?Q?yLd19UCQfNEXdmxcpDxe9BZzNScKtvoNi8jSb8fy1ujVPz8b2HnO92HY3hx4?=
 =?us-ascii?Q?6Pw+SL9W0WT5kRU1ycpb5KyKwZi2p4Zs5Ay7SSZJRE7tStoUZjf7Qzb/rL8A?=
 =?us-ascii?Q?k5enyJnyGt8fqWSTsSNT64mGIQumMIGsibq/rj5yvrH5L+Dix9e2allHjVB4?=
 =?us-ascii?Q?1bpzHhwUMGwgkrkFEsGQS7lSTMXjteTUz6nJXMiWgmInlmtQIg+Qg4yktjwJ?=
 =?us-ascii?Q?ozDohMM2d4xytZS1BmMOIvq5lhouTDFJrlo8srXIatg/ha1s7T/fqGy1TRKA?=
 =?us-ascii?Q?Hu7zYaSYoUNPw93UQtVJeH49EnHbBalWD5T/l4X/5cCgEmr8QLOrwRadye3K?=
 =?us-ascii?Q?PEGoy715GfUvTT/nlf7MdbBq675b42AHBQu12esXZSV3SnbOYsWcjNKYygvR?=
 =?us-ascii?Q?9wRmY7PAMzA8nkxZ+9rdyyMnsjgQvKFh+ucW/APntdh47pk5Ljh2ub7HSc8K?=
 =?us-ascii?Q?icriDRuZQb9kY221SbcrEagD0FCJgw2lTfNRgh0NWFmma2qS72uGwQzNlpJu?=
 =?us-ascii?Q?aSrgua/aniXQNFbBFi9VX98wFWXCc6aU+8Oe2egGdkoVlAqbfTRP9BRsNdRy?=
 =?us-ascii?Q?C4e+Nx+ygw+4DBwpnN8+/RNCDI0E44payfGPMu5lgUIWut9eB/rFtmeg6bb1?=
 =?us-ascii?Q?HR1J7AXZvRrHL+dpKvYy4iIBUeV0EHdyCZyu3H3Y?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5775de66-5a2b-49b1-c16d-08da63633cab
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 17:31:50.4803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QdrZQmQiNyB422nCSATa0zLFd8DoJsKmRG2Xg4IVaYbJMm84ts9iTP2SAiQc71NTgUbqFyxumlwUdepCDr9RZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR12MB2834
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 30, 2022 at 01:01:58PM +0200, Borislav Petkov wrote:
> On Mon, Apr 18, 2022 at 05:44:38PM +0000, Yazen Ghannam wrote:
> > Future Scalable MCA systems will include two new registers: MCA_SYND1
> > and MCA_SYND2.
> > 
> > These registers will include supplemental error information in addition
> > to the existing MCA_SYND register. The data within the registers is
> > considered valid if MCA_STATUS[SyndV] is set.
> > 
> > Add fields for these registers in struct mce. Save and print these
> > registers wherever MCA_STATUS[SyndV]/MCA_SYND is currently used.
> 
> That's all fine and good but what kind of supplemental error information
> are we talking about here? Example?
> 
> And how is that error info going to be used in luserspace?
>

I think the general case will be more bank-specific information. For example,
if the bank is a cache type then the info one format and if the bank is a CPU
type then it'll be a different format, etc. So I think the new info will be
treated the same as the old info, i.e. collect all the raw data and share it
with a hardware debug person.

The one example where this is different is the "FRU Text" case covered in a
following patch in this set. 

> I don't want to increase struct mce record size by 16 bytes and those
> end up unused.
> 
> Can the information from MCA_SYND{,1,2} be synthesized into a smaller
> quantity an then fed to userspace?
>

I don't think so, at least not at the moment. There aren't any "architectural"
fields that can be interpreted the same accross multiple errors types and
banks.

Is your concern specifically on growing/changing struct mce, or is it more
about limiting info sent to userspace?

If it's the former, then I've been thinking it would be good to introduce a
new internal "struct mce_ext" that includes struct mce plus other things. This
way struct mce can still be uapi, and things like mcelog can use it. And at
the same time we can new data used in the kernel or shared through
tracepoints.

/* Extended MCE structure */
struct mce_ext {
	struct mce *m;
	/* new stuff here */
};

What do you think?

Thanks,
Yazen