Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 17:41:54 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        tony.luck@intel.com, x86@kernel.org,
        Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH 3/3] EDAC/mce_amd: Add support for FRU Text in MCA
Message-ID: <Ysxg4r1IAA2PasTC@yaz-fattaah>
References: <20220418174440.334336-1-yazen.ghannam@amd.com>
 <20220418174440.334336-4-yazen.ghannam@amd.com>
 <YsKvVI/t2svrib1L@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YsKvVI/t2svrib1L@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mqpKWIta+iIirGNwEnBbZWq55h99GMNm9NDtWlzut7u/CKP5mGLG1OD94joG?=
 =?us-ascii?Q?QRVO3yxh1XTuXqWIuypyApt+KbggtmiibNkPt/QE4w2Osp/HPrBhIBbANube?=
 =?us-ascii?Q?4qwlXM3UbjxyK7sfmptDhevB6No1YLvCwR7VsZqbPm3SLz4iZmBeWKh0/9BH?=
 =?us-ascii?Q?G6RXxIVW9aPQxbXVEl6zcDNhmRLyGjaW7nAvolZDLyiHqPY+XKEfVu53lBp8?=
 =?us-ascii?Q?Oh61Kz/LBfA6NYGnzqx4/rXBMdUF0rjCGxxyRU6HPIBnMFSgnysuW8nr7fK6?=
 =?us-ascii?Q?LCYh4+aEQOBxEuYrIxgctPG68wNIWSe1rY3LVidjqQKIWlU7BH47HmaWhFCt?=
 =?us-ascii?Q?Xv7LNXOoKPOf8iHciQlHwSm3e4UjVQwtAD7V/T1bM4blIJZQ85jGBy/jWXsr?=
 =?us-ascii?Q?eHbDz6b4fTpjMtmPUC2O+XgzFoyWsfhDraZ6TJjzejurjnrJVh6E9i+6ZcHg?=
 =?us-ascii?Q?dnibNHoKVOdffFKGnaKgEXR39RDXMFVAv+uBtZIUHCvcoLg4xeat4qzAG8RQ?=
 =?us-ascii?Q?k5Yo2R11C6yTIVOx4JKIoc4l/9koycWNTnF5sqpC4OFW/V4guzOh1X2YpPIO?=
 =?us-ascii?Q?6c9QXigbGt65w4rT4RBbmynRNgxrpYsxGcSRFFjamB+uAiAzTVOhCi0XzovF?=
 =?us-ascii?Q?Qq3EUK7Zu2WIxnnyDy49pk0q3LrhiQkhDsBJ/M1qlNwHkmwbGBoWfok9qsuO?=
 =?us-ascii?Q?u3vrzn+Ve06cqYxFs55UUn1MWhcmRQQPv/GmNjB0qlmqNuHj33DLvI1fhMIF?=
 =?us-ascii?Q?oFzDUPk59UXb9ElkYcwYVUSUdaZmbnLYqgTfQK/5583NO7bq+sfO8NrdYKP7?=
 =?us-ascii?Q?NNFn9qRIkXSkRKD9pfzA7mgzmYHpaDpH4iX8xQuwm1Bx1kcqa3nbdGIilMBz?=
 =?us-ascii?Q?yyrRXp2orhR6F62zIe5odrvjG+hBMTMy5ecgsZ87uku+z1mqSUg93sbxUG/T?=
 =?us-ascii?Q?UQ1Xh+a7PVlLFkZlHMqizblBg1mJ4SB6Q7qyYDAITUpmprxPx9jmEVpCUC+q?=
 =?us-ascii?Q?lk/B5QFpjWEVk2dAX0hxun4CHKnL8Is1c7jH1ulKZ/G1BSj8WGVQXODpRGH1?=
 =?us-ascii?Q?d1IBLUof72/hupYoiKsdlMDlOJK/OKPfGtQOJcxnKDAp/MbjFqsDEyTsY0eb?=
 =?us-ascii?Q?HJV+Znknu52LguJDbtc7vGln0+n2X5ZtjQhaY2DcFzUNhj/AYmu3eky+3Qw+?=
 =?us-ascii?Q?UFRFcSsnfi6WmSiDG2DUIN4Kqa+PetyRdJbvuV38wKieFMbmJZoS30ErfktO?=
 =?us-ascii?Q?AxpFheU1qY3BLLLDmY/PrOWrSpkHPrG7uf5uRiR7RTKIx5khylQkDDNBk4J/?=
 =?us-ascii?Q?LU9b/QSZ3STI4UbGQO7Z+ujIKKfyvfPa1k5SjN6MbqwpxgOKjH09WMzkaa/D?=
 =?us-ascii?Q?ERy1FKuVzXFOJexOJqyh9dn/jI0rnrqmzzESBoKmO4QR9MiRYzQGrnoxjVSG?=
 =?us-ascii?Q?0SqOoFixdkriyPo6EogtksoX0EPMdWRkgSEGveXP6MbOdngY1moeJFPULKo4?=
 =?us-ascii?Q?hL8R8CRkdwlZvcpKFhN57wUkwN0q3nA2zlWxklOIj+RpGahe6n3RtoqcnBQc?=
 =?us-ascii?Q?aqwbrg16Ky9K1DcdVlfKtPgRpEODSS0kbwQTf1J9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3e82dd1-e4ad-402e-fe9c-08da6364a6c9
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 17:41:57.7637
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WOlt4YKbOLOsBAuKMgPJa22uoYDIpeZQim0Gt9gV+5G5XvOfoJc1yv87O7/mzAShivHTQw6PGCmMOUHrrBbO4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1146
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 04, 2022 at 11:13:56AM +0200, Borislav Petkov wrote:
> On Mon, Apr 18, 2022 at 05:44:40PM +0000, Yazen Ghannam wrote:
> > @@ -1254,11 +1255,10 @@ amd_decode_mce(struct notifier_block *nb, unsigned long val, void *data)
> >  		((m->status & MCI_STATUS_PCC)	? "PCC"	  : "-"));
> >  
> >  	if (boot_cpu_has(X86_FEATURE_SMCA)) {
> > -		u32 low, high;
> >  		u32 addr = MSR_AMD64_SMCA_MCx_CONFIG(m->bank);
> >  
> > -		if (!rdmsr_safe(addr, &low, &high) &&
> > -		    (low & MCI_CONFIG_MCAX))
> > +		if (!rdmsrl_safe_on_cpu(m->extcpu, addr, &mca_config) &&
> 
> This change needs to be mentioned in the commit message.
>

Okay.

> > +		    (mca_config & MCI_CONFIG_MCAX))
> >  			pr_cont("|%s", ((m->status & MCI_STATUS_TCC) ? "TCC" : "-"));
> >  
> >  		pr_cont("|%s", ((m->status & MCI_STATUS_SYNDV) ? "SyndV" : "-"));
> > @@ -1300,6 +1300,17 @@ amd_decode_mce(struct notifier_block *nb, unsigned long val, void *data)
> >  		pr_cont("\n");
> 
> So here above the code prints SYND1 and SYND2.
> 
> If they contain FRU strings, then this printing should be an if-else by
> checking bit 9.
> 
> 	if (BIT(9))
> 		print fru text
> 	else
> 		print naked syndromes
> 
>

Okay, will change.

> >  		decode_smca_error(m);
> > +
> > +		if (mca_config & BIT(9)) {
> > +			char frutext[32];
> 
> Why 32?
>

I picked the next power of 2 after 16 in order to have some space for
terminating NULL in the string. I can't think of a good reason it needs to be
a power of 2, so I can change this to 17.

> > +			memset(frutext, 0, sizeof(frutext));
> > +			memcpy(&frutext[0], &m->synd1, 8);
> > +			memcpy(&frutext[8], &m->synd2, 8);
> > +
> > +			pr_emerg(HW_ERR "FRU Text: %s\n", frutext);
> > +		}
> > +
> >  		goto err_code;
> >  	}
>

Thanks,
Yazen