Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3575199imw; Mon, 11 Jul 2022 11:12:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tycggl03xtyVVSoIy2FaHOsSf+NcUqW/aPioMGQtmLBBkPEF6n7CZRuKfPKsBx7/dvZ7/u X-Received: by 2002:a17:90a:6383:b0:1ef:c181:3777 with SMTP id f3-20020a17090a638300b001efc1813777mr19716326pjj.50.1657563154873; Mon, 11 Jul 2022 11:12:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657563154; cv=none; d=google.com; s=arc-20160816; b=XGhnPr+TVZHhpmlvXuAQrRouBoq5aRW7UZ75zc3O7X79KvhrGLd/oGK/+wDthS2Mt2 O5bF4AfZjYMEGhE8gTB5x4ESnlrXQMrEhmH/N8NrwCYQyPQV9bKoLlWqqCjf3/emfZ18 yZdil9S86USq+hAegmmVHU1j1J98WL71acjTiBcE2w5TFaio0EtrO82yxWToNlhTR1es l+0NnW6lYjV3UoCyLnr1bBUfonqaz7rUU7sxiFkOpbwVuTG3QF5mUdmLa8b71A2XlWGS vxfpPcHeNaodOLxfDGJv8Zz3uatYhMLATeokakZx876Dl+vmE4HYe86zEjZ7xP2L8t2N pkdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=80ueYF1X9seGjhWsKsUzfkbum5Yd4QAkIEuqcxtdArY=; b=s4CIGhAHKiWk/cIqDm/sTdjXTclcF3SUVb4X+I46HxncHw5jYz1/oOpXBnHTIvd6s7 xIntOH4SwcMz+N2ht+5h6xMr73Neg/30t0vVkGGPiGD6JOmfhm99xqBl9MYOeC7TpEKR IPwQ4/flVzo2XOoFE+BED9HNUskaA46JdYtlWT8vT0cta6Xdglc6XfJhGYXqlUnbvCj7 Ycz60hNSgteoEq/cj76DKQmsmym3KnAKpu5yjV2LHB8LWK3yNAw1val1x9+7ZpAWsjUn BYpfJiM713HOfx2+ClJ8SJ8jrwDdt3csZ212q46MeR+ULtVXGyhzKsbXfLbMWB6g0KqS 3hsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MsCA4h4h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mq9-20020a17090b380900b001f027dd6560si10899265pjb.61.2022.07.11.11.12.21; Mon, 11 Jul 2022 11:12:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MsCA4h4h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231193AbiGKRuD (ORCPT + 99 others); Mon, 11 Jul 2022 13:50:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229641AbiGKRuA (ORCPT ); Mon, 11 Jul 2022 13:50:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CFA71707E; Mon, 11 Jul 2022 10:50:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CAD0C6147C; Mon, 11 Jul 2022 17:49:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFD7DC34115; Mon, 11 Jul 2022 17:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657561799; bh=TP/EcJV+sjjnlp/CRGatSWqAfclKvmMEZc4Huz5tlko=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MsCA4h4hUTIvzBgG9Ci8oxvGRXrMkXdpMuuTnPi6YlRl/uG56mpxOlPDwhjn4wt8a S3fMRh3KEMzRzcbxOisRkDHmrgRSwYasgZI7y5jRm9q+fg07WTYf/jyTAf2WNo87jh wbj42Ch6SMoRJvaC7WJB+TUYwfxcMw3ReBu65TS/Kbxg4FWxKm4MeL2U1A1P2nRtDo 8QD6BFpNJK87dX+5S98qM4Jqta3ajtiiKxjiM4BJgWypKEN2ULX9Dlb4yZRiJaUo6M ranLnctMmixiGIs8FDHbnAGeZ6FO+sBRt1pOh/uePOLjggNENetv9v2Z/xsjAJ4U+k MGk3FnkxY/kQw== Date: Mon, 11 Jul 2022 10:49:49 -0700 From: Jakub Kicinski To: duoming@zju.edu.cn Cc: linux-hams@vger.kernel.org, pabeni@redhat.com, ralf@linux-mips.org, davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v5] net: rose: fix null-ptr-deref caused by rose_kill_by_neigh Message-ID: <20220711104949.3de90fc5@kernel.org> In-Reply-To: <56319300.38660.181e861b71b.Coremail.duoming@zju.edu.cn> References: <56319300.38660.181e861b71b.Coremail.duoming@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Duoming! Unrelated to this particular patch, but it seems like you're working a lot on AF_ROSE, would you consider adding a good set of selftests for it? It'd be easier to you to validate the changes and much easier for us to trust the fixes seeing how they were validated.