Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 12:13:25 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "Li, Ming" <ming4.li@intel.com>, Lukas Wunner <lukas@wunner.de>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Dave Jiang" <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V13 3/9] PCI: Create PCIe library functions in support of
 DOE mailboxes.
Message-ID: <Ysx2VdJJQFWp1oC9@iweiny-desk3>
References: <20220705154932.2141021-4-ira.weiny@intel.com>
 <20220707162223.GA307520@bhelgaas>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220707162223.GA307520@bhelgaas>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ayo1Rhpw+niB5jRwmJqCfeAUPp52hvyzDFwsNnBlclcZjNZf056ZNlKdkK0q?=
 =?us-ascii?Q?WxValJK8qGy65hWTS3fcjqpDeHIqPzjZUAJE01KD55G38zMd7vLSQZhEjRbq?=
 =?us-ascii?Q?rsjKgW61KFirxdqqV+41R5bjfXKRS67woKzRgQuaZ/X/lhGspYegtFgJRRTI?=
 =?us-ascii?Q?CIatVqHnUTW2sYZIUUU6BhR8WfLVEe6f3JkuXTOCWEjSZAh6VKOVc5KEfhHC?=
 =?us-ascii?Q?YI5Y8CW9Qh+x1lMR1jQ5gg/hZQeXTUJwNzpoF0E5ihhxYKRFksH5E8gy0iK2?=
 =?us-ascii?Q?ksqmRz7IcdjWjC1Pacd6amQUq2qCHmd+2UaW6p5P6xh5BsZTPKYzIP+KEVbW?=
 =?us-ascii?Q?7FhrHlsNsa4yJ0GB2Lxx/eaHgVn8W6ulad42woOIYNO1NzfQov3eq0R+9Zl/?=
 =?us-ascii?Q?Sz4mzKmC9UM+uQPKd7nsjbW8ySwZNHYG3XwjrVb7SUuPLxUVlwdtysfeisTo?=
 =?us-ascii?Q?B8cTSsSU8HcSU5g8v+PpTgt8dY4f0w4j+4qDOhI3SxBz+vefgokKglefAT63?=
 =?us-ascii?Q?9yregkD/7MdqlmxsX8zF4BlZEFZZCEU3ObN3r+QRmZrDnHJNMfyaWZ7AEBwq?=
 =?us-ascii?Q?bS2yobOOgM7yMJ/Mq42Cp26l2oOT6rjm6igcZrg9lLDBLRuoQMhioe7kSAy3?=
 =?us-ascii?Q?McEikwznsHHkIlLWMhRAgF2pxjm87b2HY5EbMbGIRS+i/kD6PtEVHdbppzZs?=
 =?us-ascii?Q?mO2V5pYH5snnccL1Pkw0HcogCK7A4MbgUx+pSNJXS5fZBNPe2AIVXx881bRX?=
 =?us-ascii?Q?tXo+trr243VAvekXa2jshzYwKWfA9ah/s7TW/AlS8r8mELWjh5BkmcE2OK/e?=
 =?us-ascii?Q?88je9YKdZquw0XmtO+mjx1YLOahs+1asaA9Bq7McW0UqKXBNgRQYTSJ7Pig0?=
 =?us-ascii?Q?3dc3kHrDgvU/HE55EfK4AP0ed26AD5D2CQYn0Ya/sTAGUPJezHSL+DyNC//J?=
 =?us-ascii?Q?tP6RXZsi7yAQdoTO//zePYiFn8gi+1f8jRrKIJU7VR3NNyK9ku7O7BB27yAL?=
 =?us-ascii?Q?7VyiWg2KtiR0yYfohRDxgxTCxad31mmDFhtpSw9pyCyKKy3A25JohYvdSMKJ?=
 =?us-ascii?Q?pZ3aZXSbPSOoirBedx6q8LUyad2YSEN5mJgnF3SqquRO4ce2/qxwUpKdMIB7?=
 =?us-ascii?Q?m0gPTmGXiLSFuWCnO50Q749xbh4/o0l0QZdgGv1/t2Eh9XM+YCXlJd5UET1b?=
 =?us-ascii?Q?4giYf4jC3V7FVMPVMogmW2+7430NFCJKthm6m6+9bsqPZC83B7mfN6Be08J4?=
 =?us-ascii?Q?Y9Um+aGIzSSSL/PkS6IfZHcmFP5TJspH9g0KuHj+7x7l28AnF914HLBLz+8D?=
 =?us-ascii?Q?U/n/G53+eeIqQx/5wYIdDiASntrqCN1A87wrDjjLKsnPPgJuewkFj1/yUC5R?=
 =?us-ascii?Q?6l1SkoIvNQU15HWaZqsTFPHBp+EdbtJlUyHGv5aZA8mevycmJkCDyPasTkvd?=
 =?us-ascii?Q?1jrDFiH9pfkdwWgoVdrW8djNkMUUP202v1qU9OklzJPoe4vUuJ3zCrdYR09Q?=
 =?us-ascii?Q?eR5Z83GG8eOPJPYJo0+JfqmrStTwajDkFkbFyMF6MhzLC70b9RLZyH9jK8gq?=
 =?us-ascii?Q?giXSrl40Eg5TUmxd0q9Mz2MT4avjFzBoz9XQ0iE7A2xOtGvXycQo7rF7bE35?=
 =?us-ascii?Q?KJdrsJCv5Y1oVSBWfNJT7mUPCxWc+x2P/TMd9k6lYpJw?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a0be430-01b5-4e09-0a82-08da6371724d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 19:13:32.8014
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J2MqjJ1+78rrobB+gk10zR7JsTgYGKe2VZ4K/5bTgpPnUxAV1QPCNqycbqhibZN/AsxnWELZ8gjeM6UHPv15hw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1639
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 07, 2022 at 11:22:23AM -0500, Bjorn Helgaas wrote:
> On Tue, Jul 05, 2022 at 08:49:26AM -0700, ira.weiny@intel.com wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Possible subject:
> 
>   PCI/DOE: Add DOE mailbox support functions
> 
> (no trailing period required)
> 
> > Introduced in a PCIe r6.0, sec 6.30, DOE provides a config space based
> > mailbox with standard protocol discovery.  Each mailbox is accessed
> > through a DOE Extended Capability.
> > 
> > Each DOE mailbox must support the DOE discovery protocol in addition to
> > any number of additional protocols.
> > 
> > Define core PCIe functionality to manage a single PCIe DOE mailbox at a
> > defined config space offset.  Functionality includes iterating,
> > creating, query of supported protocol, and task submission.  Destruction
> > of the mailboxes is device managed.
> > 
> > Cc: "Li, Ming" <ming4.li@intel.com>
> > Cc: Bjorn Helgaas <helgaas@kernel.org>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Co-developed-by: Ira Weiny <ira.weiny@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> Whenever the CXL folks are happy with this:
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> > +static int pci_doe_recv_resp(struct pci_doe_mb *doe_mb, struct pci_doe_task *task)
> > ...
> > +		pci_err(pdev,
> > +			"[%x] expected [VID, Protocol] = [%04x, %02x], got [%04x, %02x]\n",
> 
> Since the string already wraps, I think there's no benefit to starting
> it on its own line.  Joining with "pci_err(pdev, "[%x] ..." improves
> greppability slightly.
> 
> > +			pci_err(pdev,
> > +				"[%x] busy detected; another entity is sending conflicting requests\n",
> > +				offset);
> 
> Ditto.
> 
> > + * pci_doe_submit_task() - Submit a task to be processed by the state machine
> > ...
> > + * RETURNS: 0 when task has been successful queued, -ERRNO on error
> 
> successfully
> 
> > +int pci_doe_submit_task(struct pci_doe_mb *doe_mb, struct pci_doe_task *task)
> > ...
> > +	 * DOE requests must be a whole number of DW
> > +	 * and the response needs to be big enough for at least 1 DW
> 
> Rewrap to fill 78 columns or so.

Thanks, I've fixed these up and will submit a 13.1 soon with Willy's change to
xa_mk_value() which he caught from the other thread.

Thanks again for all the review,
Ira