Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4df9485a-4947-6f2c-e3f3-89ff44e12113@amd.com>
Date:   Mon, 11 Jul 2022 14:29:42 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2 14/14] cpufreq: CPPC: remove the acpi_disabled check
Content-Language: en-US
To:     Perry Yuan <Perry.Yuan@amd.com>, rafael.j.wysocki@intel.com,
        viresh.kumar@linaro.org, Ray.Huang@amd.com
Cc:     Deepak.Sharma@amd.com, Mario.Limonciello@amd.com,
        Nathan.Fontenot@amd.com, Alexander.Deucher@amd.com,
        Jinzhou.Su@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
        Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220709142032.837089-1-Perry.Yuan@amd.com>
From:   Nathan Fontenot <nafonten@amd.com>
In-Reply-To: <20220709142032.837089-1-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHloTkFadFIzZUdYVFVzN2c4ZU5ZbkRyR2pOdUJMZU92YWdMMFEvZjN4ZzdK?=
 =?utf-8?B?d2JnNG5wVFJwanJPOWNJemxTMFJueTd5aDNyR0Y5dEdWZmlYcHBiWnBzS0pJ?=
 =?utf-8?B?bGNRS1lwc1h6TnI0RER1c1FzQVFacWdHVlA4dmpsN0dwVGtsRUpMUnYrVmVZ?=
 =?utf-8?B?WlV5aU9UdDBrTzlHWmZZNkQyTmEvd00zbDg3aDU5N3lQeE1wRzRHRUlRM2Nl?=
 =?utf-8?B?QnhNZDVoamJBSXpiSlVsVjdXZjYyS1o1OXN6eHBPOFN0WnJuTStCbGh3ZU9p?=
 =?utf-8?B?WE4zcDRBN2FyTzZmK010ZEladjFFM1pCUjFYY0I1NitKcW0zUDdhaFBEbFlJ?=
 =?utf-8?B?YndFUkZkc3ZMWXpzMzBaRWEvUitEM0Jud1F4czI4UHBkRDRGcStPQnlESWpu?=
 =?utf-8?B?UjlnaHRGZldxR3VRMTZSd0F1dlpVTGJhV2Z3VW9pbUFuTjVXN1BkdTFWTWp5?=
 =?utf-8?B?Tlo3WE9id0J2ZWhwVnNnbDU1Ry92Rzd6TVRwUG1uWjFTbG0rNkY2clFCd1k3?=
 =?utf-8?B?NTBNNmxwR29WS3JkM2ZXV25yL2o2Vm52dTZGUFZ5a0NaejJyQk1mTHdIeFpC?=
 =?utf-8?B?UlFXeEh4VHRHQm4zK1ZpR0pyWHJtNk44QzJ6Tm1LSjl4aGNGY2t1dTVrL2FY?=
 =?utf-8?B?ekE5N01NSEF0UytvendEeWRRVVNzeFpXSmx2ZEpKS0pnQi9ENVg3YllTMkpF?=
 =?utf-8?B?V3RrTHl0cncwQ2w4RWZSZXFWd3NYT2xwL3JkN3VkQ3BEZGJaSitNandnYWdl?=
 =?utf-8?B?UjdtN21UUmFJVUxLY3g5UG5qTHo5V2ZOc3hHbE4vV2ovSitvNFNmV05Wb3dX?=
 =?utf-8?B?a0d4ZE1tMlZmekFtNHhxYUl0SGFLNWt2MDl0M2xXY0J0RFJ0RWZzNk1ESHhG?=
 =?utf-8?B?SXpNMSsraHlFZXRieUtPOGJ1bGVtQVZpOW5NNWNCWHY3enptaTB3UVVSOWFr?=
 =?utf-8?B?UHFWQkprNVlLcWpEM1FHNU9rUmcySGoybjhnYWhPTjdPbGljbVV4Mmx1V2Vx?=
 =?utf-8?B?SFlnTGRSc29xUEwzSXIxYWRRNTZ1WFZEai9LTXkvTm1BVG5pTHpjUkUxOWd6?=
 =?utf-8?B?OUpiVFhzK1J0S09xbWxTd3ZOTHFXL2FUWklwT2RzMzF5VG5kbHNhWElCTS9O?=
 =?utf-8?B?N2VQUlBBU0lmOHFIbUxONkhhUzZWMC9hYktMZW9PWjBCUzlWYTJkLzdOTGQz?=
 =?utf-8?B?cm1UVlhXRW1EV09taUNiQTl4WnJIMklUZ2pLY2dLaUJleDBDckQ4cXpnODdh?=
 =?utf-8?B?Uk1VSUZROTJSaXFpM0RmMEU3bWRYaHlBK1p4TFNmYnlMVEZ0bE9hVHZZWlhv?=
 =?utf-8?B?WEJVN1FiSERwLzlRVzVPVXhQUDAyRVI5RnNCZjlzRGZzVTNMM21uMVRySEdY?=
 =?utf-8?B?VnVXRTd1T2RKTk0xVW9NS25rVFBsdjNNVm5MOHpXNlFFWXIvMW1kSVFpV1NS?=
 =?utf-8?B?U2RxY3g3OWZPYTlDSEZXb1YrcDBDem5mdjJ5d1ZmQ0xjdTVEbWZNMmtYdnFV?=
 =?utf-8?B?ZlNaOS9HRHlUZmgvNDRHdDNyNGx3YlFDSG9NVERlRjdGUVJUY3Fhdmw3SHA1?=
 =?utf-8?B?MFMyVHNDbnBRcEZHVDgxR3BRS0Q1RVdIZW43VnkrcURaRmlxNjJLWUR4ZHFF?=
 =?utf-8?B?TG5KOWE1K3ZUaFduTU1lWEcwM3pUTHpCdUJIdEwySEhiaUhsUEk0cnRxU1N2?=
 =?utf-8?B?bFY3YVVwTTFiM05vdDQwTUgyM29Hd1ZiZjRhdisxZ29Hd3FZNUhkZkppY0hq?=
 =?utf-8?B?cnk2MFN5WjgyYkJZajRQc0JYQ0F0V2Z0L0p6Ymg1UFJVbkMrK3pvaFF6aDdk?=
 =?utf-8?B?SkFyTm0vY1BLL0NsMFJxd2toZEpHQ2RleHpLTTFsR1djaElKU0NnVVdIeU4v?=
 =?utf-8?B?UjlVL0NFWGgvWjVybUg4NGs1dTRtOGZmazh3OXZvZHdZcTFiRlZlTEo2clJt?=
 =?utf-8?B?cmxlSXVZdktOZlV6RG1SczczZXNBTlovb3pyVXJLM0xQKzkvNE1xNlR0cHN6?=
 =?utf-8?B?UmlLRFZpYmdlOHViSXFaMUthL2JQMHlxc2YxK2RqYjdjN3pROHl4TzRkRjEy?=
 =?utf-8?B?bWZ6eVRBbzgzck9tc2IzczFkZ0pnK1VDMlNkamN2K3ZKR1VwUGg5dkUxMTF0?=
 =?utf-8?B?UlVBSlMvd3M5UVZNMEJlRC9zUDg4UHp5V25qekdrQUxoVnNsbloyWlc0eEFu?=
 =?utf-8?Q?Cqn3TAEVQ2gpIlu9MyPG+F7jCvJ0D2hnvW/4AikWVtQ9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf975f19-bb1c-4191-74a9-08da6373b53e
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6222.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 19:29:44.0610
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j3vG1m43izPQdyyNUGB0o9K8AdhtU2G6nrCftuRZgYhXop414NbPq6wwKTgAbCzKiF5jfJsd82ZgLWkBkoMUAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6004
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/9/22 09:20, Perry Yuan wrote:
> "acpi_cpc_valid" function already includes the acpi_disabled check and we can
> remove the duplicated check here
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>  drivers/cpufreq/cppc_cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 24eaf0ec344d..9adb7612993e 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void)
>  {
>  	int ret;
>  
> -	if ((acpi_disabled) || !acpi_cpc_valid())
> +	if (!acpi_cpc_valid())

Same comment here as for patch 13/14, this change should be part of patch 11/14.

-Nathan

>  		return -ENODEV;
>  
>  	cppc_check_hisi_workaround();