Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <359a0e0a-b118-450e-67d8-a784d1a43cca@amd.com>
Date:   Mon, 11 Jul 2022 14:33:48 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2 07/14] cpufreq: amd_pstate: map desired perf into
 pstate scope for powersave governor
Content-Language: en-US
To:     Perry Yuan <Perry.Yuan@amd.com>, rafael.j.wysocki@intel.com,
        viresh.kumar@linaro.org, Ray.Huang@amd.com
Cc:     Deepak.Sharma@amd.com, Mario.Limonciello@amd.com,
        Nathan.Fontenot@amd.com, Alexander.Deucher@amd.com,
        Jinzhou.Su@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
        Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220709141901.835903-1-Perry.Yuan@amd.com>
From:   Nathan Fontenot <nafonten@amd.com>
In-Reply-To: <20220709141901.835903-1-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUpSZU9tYmwvNll3Z3ZDOWo2b0w3Y0x1bUFmcG1yZ3RIZVRVc0JiOEVOUyt5?=
 =?utf-8?B?YjcrVTZDSkVDRW5TaHd5UUR5Z1J5aUVGYXF6VDVXK1p0VjVmYVZ1cFVycitj?=
 =?utf-8?B?eVJ2TGk3YTZjazdMWC9qOFpPWlhlU1FIOFRLeE9yRWt6TUFmRmEvQXIzeDZo?=
 =?utf-8?B?emZnbTJNekYvTG0vMnNDTXRQa2Zjc3BSTm1VT2Frc1BKN3FOWndmd0FRbkxE?=
 =?utf-8?B?UytYNEZIdHNXZ2ZzaHV4b0xhNkt6YVFSUEFwelJ3aFZWaG4yY090Ym4zT3Zs?=
 =?utf-8?B?anByM1d5eWNNVmJTZjdOK3BaN1RvbXQ5TG9rYUl2Sjg0ZTEvN3RGWDcwUmhB?=
 =?utf-8?B?am12c1lzWUdnTzY2OE91TDI2Sk42ekdtZnhLcGh2TGZKaW9QWGlWc2wrS2FH?=
 =?utf-8?B?SFBGN2xEWjNEcHphdkNhRmNJY2tnTGpSMHl2QnlvYVR3VXFrQTZTNUlwTE02?=
 =?utf-8?B?T2NOTjV3WmFwUnhHcmZrUCtDZGtpR1c2eHBIUkdiNXczcGNiNkFHTHIrOXRD?=
 =?utf-8?B?OTR6QUwvaUZweWpvVWNINVd6dG5kVkovZWxRaC93MlR0ZGY5SS9YYmtydTJJ?=
 =?utf-8?B?Y01OZ1BkUlNwd0xwRTdDSFBxbDBVRGtDUm9TRlc1dzhiUkNEbXNacHh3ajlQ?=
 =?utf-8?B?aFd6bWtKblJYbHhkN0l3ai9wVWVKTUw3Vi9yN3NVOTVXV0xWUEZ0YnBhWnMz?=
 =?utf-8?B?ZnhNYWRhY2wyU2d5VU5ycG9zTzhzcEhPMmIwZHEvdFhkSTdZbVU2VEVQWWt1?=
 =?utf-8?B?OHBEUTNTVXdBaEFrSWR2ODZCSTlnSGFsbjYvTmQzSVFjaUZvZ3I3R2EwOWFC?=
 =?utf-8?B?R1hrbkVOTld3QzlScExLYVlPcmFjSnhCQjVDN3ROMDByRjBVUUZKZEdiVWZM?=
 =?utf-8?B?cUEvQzFhb29vOXBlTWxkTUNUdFlSWC9ubDlYK2xObjJXdlp0dUpZQ0VNcXNZ?=
 =?utf-8?B?SitNbGVma1hMWE9CSTU1NkJDVHQwWWwzUmplMHo2SGlsNVZIcXRrRjFmczA5?=
 =?utf-8?B?YzRtK3VzdFRlUHFBYkIrQ3dJVXh5Z1ZpZGNaNTlIZ3FHVlkvR1ZKMDRyNFls?=
 =?utf-8?B?bE03Y3d4Tmg3QXdMc3JFYTEzVzJxeHY1cE5lQ3ZPR1U4SklCUjF4WXNDc3Uv?=
 =?utf-8?B?aUFpcjViSk1HWURwMHQxV09qbWttSENKQTBlUDByYjg2YzRoeVVLeFVDZ1pu?=
 =?utf-8?B?clBMd0pBUmJwNnFVNGlyaUJ0aEV2M0lJdzhQUElpT1JVMmFhTVZKakhjZDBD?=
 =?utf-8?B?RkpRVFZyTWxLZ2JoUUFNSWtoUE1RN1cySDd6S3BxZ1o5THkvZnJUMUlOZHNK?=
 =?utf-8?B?MCtXYWNiNmM0MDV3anQ3Uld5bS9HdnhJRWVqYkliUXhnRnA2WW51eFhIVmRO?=
 =?utf-8?B?QW01N2hFdVkweWYwaVY0Z25hZU9LVnN2QkxVOHNNZ2Z6VVYwRUF1Mkh1NGhL?=
 =?utf-8?B?ODFtZXBHTlhZV2FqVHB3bTlZb0I4U1E3UXJVTXQ5TFhXWUFtbzJmdGdpdnZ6?=
 =?utf-8?B?cW1FbzJEMG53b3dnSUUvMS9EM21UWk5lVDVoY0lSNldoQUlxYUZmcUtsSmtx?=
 =?utf-8?B?RVJMdDFzMkoxckFDR2JGd2Q2czVMMGh1Z0pZOGtwdldNajBOZmlCdGNwVlVk?=
 =?utf-8?B?SEtDQnNKQ2V3Qk5NSkRiRHM2a1dFb010Um54UEJwczBLbkpjUmJBTzVOcURQ?=
 =?utf-8?B?YWNYQzJ2YkpXQUFIVCtpellxRjdWOFZUK0x3NG92bkI1MCtpVkZYMXpDcFZP?=
 =?utf-8?B?TG91SzV2emNpakR1RFIxcDhFMEFyOW5aeGVxSjdnbEhsNWZYV2t1dm1mUVJX?=
 =?utf-8?B?VDdmNlpXSmlyOVFRYUN0aUdrd1hxU3M4bGg0Z21iQmloV21NQU9iL2Z0eEM5?=
 =?utf-8?B?YXZkbW42dDRDM3hNOUJYb0pBd3VDYlpkOUI5eGU2Ty9xdTlHMDV1cVJqT3ZZ?=
 =?utf-8?B?SHI0V01HdlMwVloxTDVLc1g3Zm9va2syL2RqVWVLQnZVNlpZbWlqdDBBQXB5?=
 =?utf-8?B?SG5nTjlSMXJHOFNKckUzZXVldGxjSDdiSHFrS0VHNUpyV3MxcndkQ0haTUpz?=
 =?utf-8?B?WjJvM3FsR3ZmOEhYQ245V0Q3Zzk4bGlXT05tNUEvSGo3M0crYU5vUTVWcnhl?=
 =?utf-8?B?NXphdkNpQzFySks3d1QxZ0toV2UvbUVSOFo3WWprT1cyREZLWFN5TWRQMFpJ?=
 =?utf-8?Q?skR4e/zL8DTKmIZFAq03VcyaknbDuiDyWgLU7ww0o5WX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c9194bb-80b0-405b-7965-08da63744827
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6222.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 19:33:50.5186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Muoc7Cz9VZRCYoKM+Y4kurIrvVQyrkp5Daa8IUDgr0z/qU/pnuuH6Q5YUN+PO/U0WtvozPRYZuyQm7KN4OCK6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5763
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/9/22 09:19, Perry Yuan wrote:
> The patch will fix the invalid desired perf value for powersave
> governor. This issue is found when testing on one AMD EPYC system, the
> actual des_perf is smaller than the min_perf value, that is invalid
> value. because the min_perf is the lowest_perf system can support in
> idle state.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 7c51f4125263..8a2b6ad9b8c0 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -265,6 +265,7 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
>  	u64 prev = READ_ONCE(cpudata->cppc_req_cached);
>  	u64 value = prev;
>  
> +	des_perf = clamp_t(unsigned long, des_perf, min_perf, max_perf);

You should also update amd_pstate_adjust_perf() to remove the clamp_t() call now
that it is done here.

-Nathan

>  	value &= ~AMD_CPPC_MIN_PERF(~0L);
>  	value |= AMD_CPPC_MIN_PERF(min_perf);
>