Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 16:10:37 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Schspa Shi <schspa@gmail.com>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
        vschneid@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] sched/rt: fix bad task migration for rt tasks
Message-ID: <20220711161037.06b8c1ea@gandalf.local.home>
In-Reply-To: <m2v8s7mg78.fsf@gmail.com>
References: <20220708211755.73637-1-schspa@gmail.com>
        <20220708172614.14191089@gandalf.local.home>
        <m2v8s7mg78.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 09 Jul 2022 05:32:25 +0800
Schspa Shi <schspa@gmail.com> wrote:

> >> +++ b/kernel/sched/rt.c
> >> @@ -1998,11 +1998,14 @@ static struct rq *find_lock_lowest_rq(struct task_struct *task, struct rq *rq)
> >>  			 * the mean time, task could have
> >>  			 * migrated already or had its affinity changed.
> >>  			 * Also make sure that it wasn't scheduled on its rq.
> >> +			 * It is possible the task has running for a while,  
> >
> > I don't understand the "running for a while" part. That doesn't make sense.
> >  
> 
> When I say "run for a while" I mean as long as the task has
> run capability, we should check the migrate disabled flag again.
> 
> > The only way this can happen is that it was scheduled, set
> > "migrate_disabled" and then got preempted where it's no longer on the run
> > queue.  
> 
> Yes, it is the only case.

Can we then change the comment, as the "running for a while" is not clear
to what the issue is, and honestly, sounds misleading.

-- Steve