Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3684317imw; Mon, 11 Jul 2022 13:37:32 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tZgTlZIXxv/iauqlEA6+dfeAL6/lCIJtgdSy/imu8KkyTuphFrJK5tpfLF3j4JLp7b+69o X-Received: by 2002:a05:6402:27ca:b0:43a:c342:b226 with SMTP id c10-20020a05640227ca00b0043ac342b226mr18511539ede.342.1657571852455; Mon, 11 Jul 2022 13:37:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657571852; cv=none; d=google.com; s=arc-20160816; b=Bki/7UJNq9heoj7g5H+qDTN7Ue0o663q/E0gMOWsOwj9OOLte2BGQEpeZCfnN97WoB Fv4GUMq9pcQPvGp1GUoInUzOOhOL+AhrOwhyWNWqz+plA0naguekKUP9+Qk0GE/OY+Ry 0qeQqI+R3zr7h1GRepwuAZqWrjSKHqgDnjBee88tY+xwQmOzOR4bHcpqgtybK+gvqd0s ZcpnqMS0pRbth+vzzwBqugKeGx/tB1lC7W+SxkUIEMJaVDBs8WR0nBdUeTv8T+xitWP3 5Vx7FBN0IJX8mFgamNRYc7E4sxdvS976N8F0pGfqBhLI6QhPrL2Q1cuYSXt3pKPHxM6I CGQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=MaqOIGg6xgZBfAmnDVAtLCB8oPOY5LSspAi0WrEqOzs=; b=O8am0dXt8npx8a1vz+VWF0rAtRhYjcKKESHFL1qDBzXJxPPp8P7FsRwQhz4uIYZU5D tbc/BAZh93HX60deiDfdkYFcQsnlk0LTg15zIGJi0G+Lzjb4A83wtSwuB8+gENjhGGRn tpFO96IBnMR0UNvXJ62/0oJewcweuqfZmEv/dFtpmYTYdMwLY6WUnCsD9OFSgG3ajzgj 8vzfcdZhShuZQ0pNdC/qYRR8Fgu+HCwdsMzDpFiCJyemDVb/a2z0UDG3ELKVSS7Y2JUT gEXtwahYJgOXDc9+O65WlUlyjtEO3O3MrNhB35m25KcOfec8hVTlOZhtJIxlaJWr6Ajo R2Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FMqGAEyS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lz14-20020a170906fb0e00b00722dbb75ae7si10407671ejb.450.2022.07.11.13.37.07; Mon, 11 Jul 2022 13:37:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FMqGAEyS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230383AbiGKUcp (ORCPT + 99 others); Mon, 11 Jul 2022 16:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230373AbiGKUcb (ORCPT ); Mon, 11 Jul 2022 16:32:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B00E28053C for ; Mon, 11 Jul 2022 13:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657571518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MaqOIGg6xgZBfAmnDVAtLCB8oPOY5LSspAi0WrEqOzs=; b=FMqGAEyS7C49ycMA7J9KcKwqCo4MajNnS5YvZGNsOVXcpD/W2fg1AlR7S3+ga6PtVh9whG 1Of8l2/owdTZWjaUOCqbttGkK3W+uQ6ZjIicLc9w/Ss7+v1X21pM4POfU+f0sPxx2LAFvI xqvtSUDhxBY9M2nhNczQpybXDfsSJOE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-59-PwhzJposNP--KzvI3NNIaw-1; Mon, 11 Jul 2022 16:31:52 -0400 X-MC-Unique: PwhzJposNP--KzvI3NNIaw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5CC1E2803025; Mon, 11 Jul 2022 20:31:52 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 529DCC15D58; Mon, 11 Jul 2022 20:31:52 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id 26BKVqfE005700; Mon, 11 Jul 2022 16:31:52 -0400 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id 26BKVqBw005696; Mon, 11 Jul 2022 16:31:52 -0400 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Mon, 11 Jul 2022 16:31:52 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Yu Kuai , Mike Snitzer cc: agk@redhat.com, dm-devel@redhat.com, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com Subject: [PATCH 4/4] dm-writecache: count the number of blocks discarded, not the number of discard bios In-Reply-To: Message-ID: References: <20220706093146.1961598-1-yukuai1@huaweicloud.com> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change dm-writecache, so that it counts the number of blocks discarded instead of the number of discard bios. Make it consistent with the read and write statistics counters that were changed to count the number of blocks instead of bios. Signed-off-by: Mikulas Patocka Index: linux-2.6/drivers/md/dm-writecache.c =================================================================== --- linux-2.6.orig/drivers/md/dm-writecache.c +++ linux-2.6/drivers/md/dm-writecache.c @@ -1514,7 +1514,7 @@ static enum wc_map_op writecache_map_flu static enum wc_map_op writecache_map_discard(struct dm_writecache *wc, struct bio *bio) { - wc->stats.discards++; + wc->stats.discards += bio->bi_iter.bi_size >> wc->block_size_bits; if (writecache_has_error(wc)) return WC_MAP_ERROR; Index: linux-2.6/Documentation/admin-guide/device-mapper/writecache.rst =================================================================== --- linux-2.6.orig/Documentation/admin-guide/device-mapper/writecache.rst +++ linux-2.6/Documentation/admin-guide/device-mapper/writecache.rst @@ -87,7 +87,7 @@ Status: 11. the number of write blocks that are allocated in the cache 12. the number of write requests that are blocked on the freelist 13. the number of flush requests -14. the number of discard requests +14. the number of discarded blocks Messages: flush