Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3695163imw; Mon, 11 Jul 2022 13:53:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vSLpZmU0pqN/43/sXjJjdSKKhBVT3b0/kkSZzbUGKbobpfx9bi1zXF9V7PrJOmNwCWxM7W X-Received: by 2002:a17:906:84fa:b0:72b:13ff:e938 with SMTP id zp26-20020a17090684fa00b0072b13ffe938mr19952240ejb.361.1657572825866; Mon, 11 Jul 2022 13:53:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657572825; cv=none; d=google.com; s=arc-20160816; b=qnv9UwiubXDZbmGLdcyVkVaJD3X3/VHuDcen6NQ2gtJ6RTteWCkYdVtd4w6RP3HfGI 5JydVmH239JmJ9Y2bmqqEvTTufWakMG3TGFk3VN998JwA09/zl9ltB2a54oz2NqjEVuA F88IW4KVpsiPE/vqq0VgxDIBqsrHul1C5oLw/SlcVbStqB00XVp98Gg4RtMmS97rwdHO vcs6bXRwtpbzJUdyMhJXGXAZDvf0UMGCUpjYQaohLol+uFs6s7cE3WoBuF2DCwUPVoBR Du7Eh5+Hp7wfANyLNeAT65CAdZoCw5hW1wDluhJuKJEabirBPVEddptdL/ox+0GKGMxU dTcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=ipzC8tfwTfF35IYSTRi5ja5zqvrJa1GQQ6ZhLMT1LfU=; b=LgMPlKicNSqIExFN/z3PdkHIUhY/cPrYc7w7Flo1XJXVnv2vO19YfEQiAffROxGzGp YAFxEQJY19slTuR0GN5MtUqKucEkgOp5gW6QIDM6XGSiUeVrl0mBx9yFdyZ6MKcHd8tT qAFVYBdQeEF+W7aqPujVUhWeQDWyMYH4G21ul2J1dWS/QZvkZ0aPmsfohohIo9QvSzgd KyVRwMP07b3uHcDwY4vz7YzIGHtpO2QWTS4hcdIeINhG1ORRSwb/NDXreGoDxyqFhkwW 6eUSNJyeEv8JNkM3xLbZ6sspEC1w5KQQiRPqVF7dHuI5JjDoNyUpIPHTaQ2fIMhKRpFL QDDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=LuT7CaQR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lg8-20020a170906f88800b0071fc6233a69si11294888ejb.770.2022.07.11.13.53.19; Mon, 11 Jul 2022 13:53:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=LuT7CaQR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbiGKU0v (ORCPT + 99 others); Mon, 11 Jul 2022 16:26:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbiGKUZa (ORCPT ); Mon, 11 Jul 2022 16:25:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D85ED4F6A3 for ; Mon, 11 Jul 2022 13:25:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B106C61657 for ; Mon, 11 Jul 2022 20:25:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E795C341D1; Mon, 11 Jul 2022 20:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657571125; bh=ijCPUHCQ+PvIvqv0lj0eAF28GMG83iZ88gPn2azWN00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LuT7CaQRkdWFb8J/EDSonrTwNrneFh4vQzZa34mfbf3abyiL9uJB0RNLTsPkHeCg9 Gvy/qehbvXma6MzykQXN6Q3bAWc9AgkVRyK737bGrBp4jccYBKwaoDhHHmVQ68qfkL QxNqwvTJi2HNVQLXX5pxdT9uId/imH0kHyPC4xg6F6hJ6PoR8puYgEKWx1mJr4pdTP xp4QpPXQmhDIu74KD0OzuNfbuv0W0qDQDEhsz7OshIbocDgDlNWJs/g9txY5KijQMz LEXa5jPSdb82yxhavdHFzgrH+8LNGXx1r4ih4RoBXA7oxqc2FReW+kwZEV2CdgUHhq 7aqWQhvXVAkKw== Received: from mchehab by mail.kernel.org with local (Exim 4.95) (envelope-from ) id 1oAzy3-004e8I-LS; Mon, 11 Jul 2022 21:25:19 +0100 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , =?UTF-8?q?Christian=20K=C3=B6nig?= , "Jani Nikula" , "Lucas De Marchi" , "Rodrigo Vivi" , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Daniel Vetter , David Airlie , Joonas Lahtinen , Maarten Lankhorst , Matthew Auld , Tvrtko Ursulin , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 17/32] drm/i915: i915_gem_wait.c: fix a kernel-doc markup Date: Mon, 11 Jul 2022 21:25:02 +0100 Message-Id: <54d781157866d7dc4f656b50500f228dca4070ed.1657565224.git.mchehab@kernel.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The return codes for i915_gem_wait_ioctl() have identation issues, and will be displayed on a very confusing way. Use lists to improve its output. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32] at: https://lore.kernel.org/all/cover.1657565224.git.mchehab@kernel.org/ drivers/gpu/drm/i915/gem/i915_gem_wait.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index bdba05492582..7b4e216a295b 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c @@ -176,23 +176,25 @@ static unsigned long to_wait_timeout(s64 timeout_ns) * @data: ioctl data blob * @file: drm file pointer * - * Returns 0 if successful, else an error is returned with the remaining time in - * the timeout parameter. - * -ETIME: object is still busy after timeout - * -ERESTARTSYS: signal interrupted the wait - * -ENONENT: object doesn't exist - * Also possible, but rare: - * -EAGAIN: incomplete, restart syscall - * -ENOMEM: damn - * -ENODEV: Internal IRQ fail - * -E?: The add request failed - * * The wait ioctl with a timeout of 0 reimplements the busy ioctl. With any * non-zero timeout parameter the wait ioctl will wait for the given number of * nanoseconds on an object becoming unbusy. Since the wait itself does so * without holding struct_mutex the object may become re-busied before this * function completes. A similar but shorter * race condition exists in the busy * ioctl + * + * Returns: + * 0 if successful, else an error is returned with the remaining time in + * the timeout parameter. + * * -ETIME: object is still busy after timeout + * * -ERESTARTSYS: signal interrupted the wait + * * -ENONENT: object doesn't exist + * + * Also possible, but rare: + * * -EAGAIN: incomplete, restart syscall + * * -ENOMEM: damn + * * -ENODEV: Internal IRQ fail + * * -E?: The add request failed */ int i915_gem_wait_ioctl(struct drm_device *dev, void *data, struct drm_file *file) -- 2.36.1