Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220711162713.2467476-1-dlatypov@google.com>
References: <20220711162713.2467476-1-dlatypov@google.com>
Subject: Re: [PATCH] clk: explicitly disable CONFIG_UML_PCI_OVER_VIRTIO in .kunitconfig
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
        linux-clk@vger.kernel.org, Daniel Latypov <dlatypov@google.com>,
        Maxime Ripard <maxime@cerno.tech>
To:     Daniel Latypov <dlatypov@google.com>, brendanhiggins@google.com,
        davidgow@google.com
Date:   Mon, 11 Jul 2022 13:48:57 -0700
User-Agent: alot/0.10
Message-Id: <20220711204859.3DDD5C34115@smtp.kernel.org>
Precedence: bulk

Quoting Daniel Latypov (2022-07-11 09:27:13)
> CONFIG_UML_PCI_OVER_VIRTIO=3Dy is needed to enable CONFIG_PCI=3Dy on UML.
> However, this causes test failures when running the clk tests, i.e.
> $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/clk
>=20
> A snippet of the particular error is:
> >     ok 1 - clk_gate_test_parent_rate
> > ------------[ cut here ]------------
> > WARNING: CPU: 0 PID: 45 at lib/logic_iomem.c:141 __raw_readl+0x9f/0xd0
>=20
> This is triggered by this cast in the test:
>    143          ctx->fake_mem =3D (void __force __iomem *)&ctx->fake_reg;
> this seems to work except when logic iomem is enabled, i.e.
> CONFIG_INDIRECT_IOMEM=3Dy.
>=20
> As a short-term fix, explicitly disable CONFIG_UML_PCI_OVER_VIRTIO in
> drivers/clk/.kunitconfig so we can enable it for everyone else by
> default in kunit.py.
>=20
> The long-term fix probably requires something more complicated, like
>   #ifdef CONFIG_INDIRECT_IOMEM
>     logic_iomem_add_region(...);
>   #endif

If this is how platform IO is mocked then yes we'll have to implement
that.

>=20
> Signed-off-by: Daniel Latypov <dlatypov@google.com>
> Reported-by: Maxime Ripard <maxime@cerno.tech>
> Tested-by: Maxime Ripard <maxime@cerno.tech>
> ---
> Note: this targeting the -kselftest kunit branch.
> There's a commit that triggers this by enabling logic iomem by default
> [1] and there's also a commit that lets disable it via kunitconfig file
> [2], which this fix relies on.
>=20
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest=
.git/commit/?h=3Dkunit&id=3D6fc3a8636a7b0f7dbd6d0a4e450e765dc17518d4
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest=
.git/commit/?h=3Dkunit&id=3D8a7c6f859a20ca36a9e3ce71662de697898c9ef5
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>