Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 14:02:18 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     akpm@linux-foundation.org, songmuchun@bytedance.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hugetlb: fix memoryleak in hugetlb_mcopy_atomic_pte
Message-ID: <YsyP2h/zIwJhp33s@monkey>
References: <20220709092629.54291-1-linmiaohe@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220709092629.54291-1-linmiaohe@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EVEkPRw4RuUksYyxVBtth/XL2zgGzuzftAwggkvuMs7v1xDPq9WAEwENDcvk?=
 =?us-ascii?Q?H/EjB9mqSVzhnFFVFHPcLbZe9XUDfyLeTs4k/5uxJ09py5UNayFBgsBYANlY?=
 =?us-ascii?Q?5/vHedbzV8Go9lle5OStx4dcyTnvLWQRAGz9ardUNaFgJrbnXwTdBCv192JT?=
 =?us-ascii?Q?z62x9n/jjyVf8VP9AexzkKPIjqTp/vhmpAuB4KFQYIc7TQbftRMtkU1WsSIG?=
 =?us-ascii?Q?a8lQHTwl8Ao2oH+broAnxxmGNnt84npqaM6FOCT8sMk9Jefl+X0sNJEjYarc?=
 =?us-ascii?Q?TwXzcMvjNXxsU99L4Boiu65pRGs7eqjzkqYPr1ZCyhOktVqpqZDQ7ygLJqvj?=
 =?us-ascii?Q?cr6CAPRztCjViZ3nd0ReW0CFJsPxHzVNEdK4sjzMcdHJsdK7HUidEVQtiACB?=
 =?us-ascii?Q?JkX83kNVTiRmJvHzb5///Af/5Fni8pc61kQ7NnLFF8i0X1nuSWb5oDCbsGKi?=
 =?us-ascii?Q?0fG4ibfKTku0IXm6CFvP2qjbVFOmHR3djXdY7eb+9X72Mu2Vy8quWtsdAnVs?=
 =?us-ascii?Q?MIaJltH2k/+5ZP5EIgfukPLDrpeEvxVFsRvJLbCFsDF7gaEotbJxBHRiLpjD?=
 =?us-ascii?Q?DZAobkKVmr8D+YRynr/fbV72uEIoWsAdLTo0ElPHc6kdbThEp1UYQeNrRbdz?=
 =?us-ascii?Q?CtSYbt9l18ZpKqP+JOQGDXPLmSYrsxSqyl1I0au47VdDmN83YztGnZUM55nT?=
 =?us-ascii?Q?Knm0GPGAKWuGkBrZj9A9bnD+aYSHRAtdlxM8Uoowi7q1xjgc6BOmwf0sHEAe?=
 =?us-ascii?Q?vokFfqVB5eFJ+axpPe17adAPS9R0nyBgShytnMF27mwUUnQomab7pba6BfCP?=
 =?us-ascii?Q?7pCNzCd/AXTmxBe08lw4xZOZJfNU1jhF+BdGo/cqbgvwGiOLhTabf0VDdYXg?=
 =?us-ascii?Q?7wdklV70lffWFLuCWDoW5350S2dhpgTyFnxdTNF94E8pBEUabF1P3dxMIOsM?=
 =?us-ascii?Q?wu770iqnWvVJDfIDme1DlDpeFrPqyzh2YEcxrdhkls9cn8qPCNN9bptlDJvz?=
 =?us-ascii?Q?nZf9P2eitK8Xwpfe2YtppW1vc+U1Vc/44YK62lfZ0VKTQcqEwUtLfVr2HugD?=
 =?us-ascii?Q?wpsU0hnDBNxSXB+AwEOwyi2g3C/zM9f+GwEsfZpCTz+9ZEoBfy4I87CznZ0K?=
 =?us-ascii?Q?YZNiwPm3ZwlBDHbtpt3QD1eFbU4yph7U/0iVKDwKnBW1MiP5t9jyDWHaNWi9?=
 =?us-ascii?Q?J14Enndjo0Od6r5n5SKaiJm2Gzjk2GpKAppnNhF7Nru1jHumIEQfD/wMbuHT?=
 =?us-ascii?Q?pYg1SWUmbWxL/7jexeH2gA1NPGcnXD+4BtQa4kHqmHrhfn1ixxhE/ljkkygq?=
 =?us-ascii?Q?zNZvmDB2MK6VnjpNwv4ST9Qbiu4a6xEu5YolPhY80kyPPuYzN/S6mraxslC9?=
 =?us-ascii?Q?dHiwWT5TGahzKEvsxtwiX82Xcl5KW8iVJN0+P+FgmTPmWk8mWnHMCdHJcvVI?=
 =?us-ascii?Q?BRItCYs35RCdWFdi4y+b+18q6t4c2FfnznwXXflMbMErNQzjnfxddNlzHlmA?=
 =?us-ascii?Q?eR6eryEHGzWnmORmnSm3E6s/j89kqjYn4+zhHyLCkDmUyBT6rXA6M+kyIlMS?=
 =?us-ascii?Q?E5xByUnfG+gz+kRSftEY0UdyNsgOhXPa555BrQ8spGx4WVijpuieQmjminx5?=
 =?us-ascii?Q?2Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01868f77-c4d1-483d-af53-08da6380a56f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 21:02:21.1994
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WYLzHHFHht/HLdVj+zMrlFU81++rH5aak//4p2JHqkO79J4MlIs40kk8/iG6s2mn3kpwGeYZRYdeI+2DM0d8Ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1562
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-11_25:2022-07-08,2022-07-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207110086
X-Proofpoint-ORIG-GUID: hlIesDrs0B9t7sfX2Rx-_3xKOIa165CU
X-Proofpoint-GUID: hlIesDrs0B9t7sfX2Rx-_3xKOIa165CU
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/09/22 17:26, Miaohe Lin wrote:
> When alloc_huge_page fails, *pagep is set to NULL without put_page first.
> So the hugepage indicated by *pagep is leaked.
> 
> Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY")
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  mm/hugetlb.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks for finding and fixing!

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz


> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 06c2d86b1ba3..598c37279fee 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5962,6 +5962,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm,
>  
>  		page = alloc_huge_page(dst_vma, dst_addr, 0);
>  		if (IS_ERR(page)) {
> +			put_page(*pagep);
>  			ret = -ENOMEM;
>  			*pagep = NULL;
>  			goto out;
> -- 
> 2.23.0
>