Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220515210048.483898-10-robimarko@gmail.com>
References: <20220515210048.483898-1-robimarko@gmail.com> <20220515210048.483898-10-robimarko@gmail.com>
Subject: Re: [PATCH v4 10/11] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Robert Marko <robimarko@gmail.com>
To:     Robert Marko <robimarko@gmail.com>, absahu@codeaurora.org,
        agross@kernel.org, bjorn.andersson@linaro.org,
        devicetree@vger.kernel.org, dmitry.baryshkov@linaro.org,
        krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        mturquette@baylibre.com, robh+dt@kernel.org, tdas@codeaurora.org
Date:   Mon, 11 Jul 2022 14:10:45 -0700
User-Agent: alot/0.10
Message-Id: <20220711211047.952F4C34115@smtp.kernel.org>
Precedence: bulk

Quoting Robert Marko (2022-05-15 14:00:47)
> diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq807=
4.c
> index 3204d550ff76..42d185fe19c8 100644
> --- a/drivers/clk/qcom/gcc-ipq8074.c
> +++ b/drivers/clk/qcom/gcc-ipq8074.c
> @@ -663,6 +663,7 @@ static struct clk_branch gcc_sleep_clk_src =3D {
>                         },
>                         .num_parents =3D 1,
>                         .ops =3D &clk_branch2_ops,
> +                       .flags =3D CLK_IS_CRITICAL,
>                 },

Why not just remove the clk from the driver? Is anything using it?