Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220515210048.483898-1-robimarko@gmail.com> <20220515210048.483898-10-robimarko@gmail.com>
 <20220711211047.952F4C34115@smtp.kernel.org>
In-Reply-To: <20220711211047.952F4C34115@smtp.kernel.org>
From:   Robert Marko <robimarko@gmail.com>
Date:   Mon, 11 Jul 2022 23:14:38 +0200
Message-ID: <CAOX2RU7NaJL5dTrjz26oiz0psvXKV8C-7HGMmJ-rfNJ3r=y2qg@mail.gmail.com>
Subject: Re: [PATCH v4 10/11] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src
To:     Stephen Boyd <sboyd@kernel.org>
Cc:     Abhishek Sahu <absahu@codeaurora.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Devicetree List <devicetree@vger.kernel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        linux-clk@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>, tdas@codeaurora.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 11 Jul 2022 at 23:10, Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Robert Marko (2022-05-15 14:00:47)
> > diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> > index 3204d550ff76..42d185fe19c8 100644
> > --- a/drivers/clk/qcom/gcc-ipq8074.c
> > +++ b/drivers/clk/qcom/gcc-ipq8074.c
> > @@ -663,6 +663,7 @@ static struct clk_branch gcc_sleep_clk_src = {
> >                         },
> >                         .num_parents = 1,
> >                         .ops = &clk_branch2_ops,
> > +                       .flags = CLK_IS_CRITICAL,
> >                 },
>
> Why not just remove the clk from the driver? Is anything using it?

Hi Stephen, USB sleep clocks are derived from it so it cant be dropped.

Regards,
Robert