Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220705163136.2278662-1-vincent.knecht@mailoo.org>
 <CAHp75VfwoSqLZVbsN3DduP=SEKvr=tSfmxF1MTnYma0zh-JsXQ@mail.gmail.com> <e17913649e255d91bc357d3ab3e70957d05493e6.camel@mailoo.org>
In-Reply-To: <e17913649e255d91bc357d3ab3e70957d05493e6.camel@mailoo.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 11 Jul 2022 23:39:53 +0200
Message-ID: <CAHp75VdcT4TRZU_w-cntTt3jYTnwADcUo055vWLM8xrkWTXChg@mail.gmail.com>
Subject: Re: [PATCH v3 0/6] leds: Fix/Add is31fl319{0,1,3} support
To:     Vincent Knecht <vincent.knecht@mailoo.org>
Cc:     Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        "H. Nikolaus Schaller" <hns@goldelico.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jul 9, 2022 at 11:51 AM Vincent Knecht
<vincent.knecht@mailoo.org> wrote:
> Le mardi 05 juillet 2022 =C3=A0 20:57 +0200, Andy Shevchenko a =C3=A9crit=
 :
> > On Tue, Jul 5, 2022 at 6:32 PM Vincent Knecht <vincent.knecht@mailoo.or=
g> wrote:
> > >
> > > v3:
> > > - pick up Rob's R-b for patches 1 and 2
> > > - reinstate bindings docs license and maintainer
> > >   changes with Nikolaus agreement
> > > - took Andy's comments on patch 4 into account
> >
> > Thanks for the update. Nothing serious, but a few comments.
> >
> > Also a question here. Do you have plans to convert it to use device pro=
perties?
>
> Hi Andy, and thank you for the reviews.
> Just sent a v4:
> https://lore.kernel.org/linux-leds/20220709094642.4078222-1-vincent.knech=
t@mailoo.org/
>
> As for converting to device properties, it will take me some more time
> since I'm not too familiar with the concepts and how to do it exactly.

I just sent a series [1] which is based on the top of yours. You can
rebase it (it fixes a couple of subtle bugs: 1) GPIO error messaging
during error probe, and 2) mutex destruction is out of order) or
handle it together with yours. It seems you possess hardware, so I
assume you at least can test it.

> Got some hints from git history, will look into that.
> Also I'd like to add blink support...

--=20
With Best Regards,
Andy Shevchenko