Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jane Chu <jane.chu@oracle.com>
To:     dan.j.williams@intel.com, hch@infradead.org,
        vishal.l.verma@intel.com, dave.jiang@intel.com,
        ira.weiny@intel.com, nvdimm@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: [PATCH] acpi/nfit: badrange report spill over to clean range
Date:   Mon, 11 Jul 2022 17:26:58 -0600
Message-Id: <20220711232658.536064-1-jane.chu@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lS4m8Sd3WYED6qxVFvs0Jcz8yXo5847XWErptuqpdHkGMpBc5B9LsBC0PO6n?=
 =?us-ascii?Q?Ou0dBrQSStMR0koDJdxAofnJptfkAX4hPdRsXGvWpM20aELRpqgYzW1eUlRR?=
 =?us-ascii?Q?SWbvbz1920iNydIo+Gkk/IMw4pw0etmSJ2cpYhPAl0FvUMRlkUWZhWi+CgJx?=
 =?us-ascii?Q?GbaVGVevGOpVdPqC/0Waa4CURQF0vEyt0G3y3oPpJFkztZuzUCvXnHn2Kl5h?=
 =?us-ascii?Q?gpjO1TJ7IFQbf5dz912BTcYBqIS6yxdl/8GitnL0Sb0AEY5i41RhLvpVLl3D?=
 =?us-ascii?Q?Xi8wYFkZlRgDIRzLLr0cfCAwDfQf/Yrwx0xmhnMDGP/TYoANub9cIFVODNac?=
 =?us-ascii?Q?9z91tgg5POn/g0wvQkMdskrABfIyeMjTPiygXnIhyZXUyvJpGOv5SHsRvmRO?=
 =?us-ascii?Q?O/3RqoFw/8/NiN7cEypF+ZtA0Dxglc7yMOT1L/hvvNV7VQYLEz9FaiPjpFYV?=
 =?us-ascii?Q?o0+X2bnVRjgr1iSMisKSTISs6PLO/XRA8+KC+ZsizczIhuDrv3Et0KYljFBe?=
 =?us-ascii?Q?hU0m087vZMG3WRLqcOrkIh4Oeoud+LZtedZ/s+IHM4ezIhqWyyqVpM4f0f1m?=
 =?us-ascii?Q?yqudNduNlQKloh2skHwaJSBm7QZFjzsnqA2AbTpRydBNdaOOk/ZkTT9/OPID?=
 =?us-ascii?Q?wTWFAbhBSmjCM+BzAqx0qcdAgP3ugTFyFoXNVPP9maT6u6s7wXlSDujQgZcU?=
 =?us-ascii?Q?W+jjrIIEeiKu7iq+9zIrfG5N3j87Zr4/gobU3GzY1SoKVPi7MqW1Ea1KiYe9?=
 =?us-ascii?Q?KNtaJi5q56RALEilWCB+vXppHPBZtd4sJB+TBCh6b+k6SVILiOItwjkcq6N6?=
 =?us-ascii?Q?xsBFhGqlmyTRVBQec9JrymXZWzswxU49vO26zup756L7cfThSZNczkackIOB?=
 =?us-ascii?Q?1DrotRFFp6vMb8H0iFnYBbk3ISpm++Ap/ODjcVx/a/8ezGfabm9sRsz2iaOm?=
 =?us-ascii?Q?aDF6xDE+3a620WTXwOJcGQICyWG05xItIfbj/xq4eQPEBR5N430ll/Jmsei6?=
 =?us-ascii?Q?khUhefuIO/onES3gpVD+1V1RHzGD92aTzrd+g79qS/hZ5xIzSsRYvEuOv1lQ?=
 =?us-ascii?Q?mEZe/YoIzEpflIFYeHO4YoAXF4nwuIvtE7Z0/5SBn8llW6FWd799rNrXzjt6?=
 =?us-ascii?Q?PVA9B6xdYSLBa8O1Ktq8sQmYz91lbg6jZaHi0eHs8NZAGlnaHMYh56upL5V6?=
 =?us-ascii?Q?BH0YG6VygDi31KazaOijUR07AfU93KRmaKDEA3zvPfNwflykiem/yBVBNZw1?=
 =?us-ascii?Q?uTnD3N4U5EYLrNs+dNx+tbM1oa0ux9l6Dry3lq/JJMnRzs2gQIqXboHQJnp/?=
 =?us-ascii?Q?+oChpImGWT5WzOT71Tw1WeZ/YNFvkRyxnaWRIBmlCNCzrRqePE3oRx/2SZt4?=
 =?us-ascii?Q?OyZHQsjraleZOrIa1WhBHgT5iSYAXnnvwbRmqJBrLEa+2y/7xtAJw8SGer0w?=
 =?us-ascii?Q?PTyPFv4ToCXiAGO+F1iV0CFONAN7QeRSJgvU514fAE2gMW0d2YRh5BJn7o5h?=
 =?us-ascii?Q?HBv2+/UHaw1ZBAAtElf7idntczOD63vAu7zZFHPbqp5fOPWFzIBOgW2q/jdb?=
 =?us-ascii?Q?mac3PKzM9wjlHMtDdzMHOLmZzeNKRaSQACchdveOqDMAxQASjQzFy7I6z91r?=
 =?us-ascii?Q?sQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 194abd2d-cbe7-42d0-c9eb-08da6394e9ed
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 23:27:25.8424
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HflaB7oLyEFHwtUqjWLrMaBpsZdho7SbQGsdwoOybySWC7SGLUSV9kqHaLdOv2kef0NX4VO6YM3CZFRSCG1uOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5819
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-11_25:2022-07-08,2022-07-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207110095
X-Proofpoint-GUID: D0zxFR2QtP6rZ653WSG5IVSQ-FO-6YJw
X-Proofpoint-ORIG-GUID: D0zxFR2QtP6rZ653WSG5IVSQ-FO-6YJw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Commit 7917f9cdb503 ("acpi/nfit: rely on mce->misc to determine poison
granularity") changed nfit_handle_mce() callback to report badrange for
each poison at an alignment indicated by 1ULL << MCI_MISC_ADDR_LSB(mce->misc)
instead of the hardcoded L1_CACHE_BYTES. However recently on a server
populated with Intel DCPMEM v2 dimms, it appears that
1UL << MCI_MISC_ADDR_LSB(mce->misc) turns out is 4KiB, or 8 512-byte blocks.
Consequently, injecting 2 back-to-back poisons via ndctl, and it reports
8 poisons.

[29076.590281] {3}[Hardware Error]:   physical_address: 0x00000040a0602400
[..]
[29076.619447] Memory failure: 0x40a0602: recovery action for dax page: Recovered
[29076.627519] mce: [Hardware Error]: Machine check events logged
[29076.634033] nfit ACPI0012:00: addr in SPA 1 (0x4080000000, 0x1f80000000)
[29076.648805] nd_bus ndbus0: XXX nvdimm_bus_add_badrange: (0x40a0602000, 0x1000)
[..]
[29078.634817] {4}[Hardware Error]:   physical_address: 0x00000040a0602600
[..]
[29079.595327] nfit ACPI0012:00: addr in SPA 1 (0x4080000000, 0x1f80000000)
[29079.610106] nd_bus ndbus0: XXX nvdimm_bus_add_badrange: (0x40a0602000, 0x1000)
[..]
{
  "dev":"namespace0.0",
  "mode":"fsdax",
  "map":"dev",
  "size":33820770304,
  "uuid":"a1b0f07f-747f-40a8-bcd4-de1560a1ef75",
  "sector_size":512,
  "align":2097152,
  "blockdev":"pmem0",
  "badblock_count":8,
  "badblocks":[
    {
      "offset":8208,
      "length":8,
      "dimms":[
        "nmem0"
      ]
    }
  ]
}

So, 1UL << MCI_MISC_ADDR_LSB(mce->misc) is an unreliable indicator for poison
radius and shouldn't be used.  More over, as each injected poison is being
reported independently, any alignment under 512-byte appear works:
L1_CACHE_BYTES (though inaccurate), or 256-bytes (as ars->length reports),
or 512-byte.

To get around this issue, 512-bytes is chosen as the alignment because
  a. it happens to be the badblock granularity,
  b. ndctl inject-error cannot inject more than one poison to a 512-byte block,
  c. architecture agnostic

Fixes: 7917f9cdb503 ("acpi/nfit: rely on mce->misc to determine poison granularity")
Signed-off-by: Jane Chu <jane.chu@oracle.com>
---
 drivers/acpi/nfit/mce.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/nfit/mce.c b/drivers/acpi/nfit/mce.c
index d48a388b796e..eeacc8eb807f 100644
--- a/drivers/acpi/nfit/mce.c
+++ b/drivers/acpi/nfit/mce.c
@@ -32,7 +32,6 @@ static int nfit_handle_mce(struct notifier_block *nb, unsigned long val,
 	 */
 	mutex_lock(&acpi_desc_lock);
 	list_for_each_entry(acpi_desc, &acpi_descs, list) {
-		unsigned int align = 1UL << MCI_MISC_ADDR_LSB(mce->misc);
 		struct device *dev = acpi_desc->dev;
 		int found_match = 0;
 
@@ -64,7 +63,8 @@ static int nfit_handle_mce(struct notifier_block *nb, unsigned long val,
 
 		/* If this fails due to an -ENOMEM, there is little we can do */
 		nvdimm_bus_add_badrange(acpi_desc->nvdimm_bus,
-				ALIGN_DOWN(mce->addr, align), align);
+				ALIGN(mce->addr, SECTOR_SIZE),
+				SECTOR_SIZE);
 		nvdimm_region_notify(nfit_spa->nd_region,
 				NVDIMM_REVALIDATE_POISON);
 

base-commit: e35e5b6f695d241ffb1d223207da58a1fbcdff4b
-- 
2.18.4