Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 16:41:07 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     James Houghton <jthoughton@google.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Jue Wang <juew@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 19/26] hugetlb: add HGM support for
 copy_hugetlb_page_range
Message-ID: <Ysy1EySRmjxl2TmQ@monkey>
References: <20220624173656.2033256-1-jthoughton@google.com>
 <20220624173656.2033256-20-jthoughton@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220624173656.2033256-20-jthoughton@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PmFDCcNlF8lgf4myshZYpD9CybvUMj8vIekqnOy3KThFi+dDLKVgtHGwxx8U?=
 =?us-ascii?Q?HbsA/J3PNZof83c/E19M8ngMxpvvAwtJZAMv1TijRx1Qe7IuS5GJ62joF0cE?=
 =?us-ascii?Q?cPSpmFgiTs9+f268yrPja2hqBVVh1HZdfn7CiTHI42ETHbpXVmj4MyUCu0Hm?=
 =?us-ascii?Q?SfT31BVEHpNsN2LaFKsSEyJriwWcPNPMa1ARC0FKhkcs+Lf/MnlEQs6L+/7f?=
 =?us-ascii?Q?yzTz6MWiujtbM2f96YpYXo3WQsF7xlRSFcNSnPKAbc0nwJuYn5nLynWVCIkF?=
 =?us-ascii?Q?ZpuBkwx9mkosOTcPiiTAL9NEyw9oRMw88WXatXjeVVP8qMpmv//cvhlRzYRG?=
 =?us-ascii?Q?W+9ge52ZU33a59oT65iDhm/dBqpATF3efGMi5Q82W7cuYY1RnimZRhWD0Wyi?=
 =?us-ascii?Q?CHkvPMwtZPT2Q7lJxXCur0C21GLoE2mrbOwohUXmrGVfS/gREfdBmSaI0R1Y?=
 =?us-ascii?Q?4TMLJ69GJ+MabMnx5iNBT74AQw2Wh9MEIuqSoQOkrXpvYkILAjlPP9Q4+bqc?=
 =?us-ascii?Q?y9IrChpqt8KXluhuu9O8zFCjJhkrFWUg/YyPOWLm7g83uJPiW3JFxK0n4dDh?=
 =?us-ascii?Q?vPHVoZDAO93eFK4NhV0zx5kCjAOMU4Kcij3QdJUw/ltMwntlgwFfrNqm9Jbw?=
 =?us-ascii?Q?rPeDDp2sDISS0NOD2GHeh71qPA0sifNcqyi2E6eIcQqCrX7B5ch61vDp4ZrL?=
 =?us-ascii?Q?qdcCkwEHDNCMSv9lj6xspTAmkeah82ru3M0vRIxHBuRrtWch2tpxiIxIndzw?=
 =?us-ascii?Q?Qbjxs7fRZ34eJjkcq0MWbtVXc+18ZgfQ2w3AxAARQbg5JEr5eWPXFsqdv2rG?=
 =?us-ascii?Q?VErSEl0dUymM81tucFoocdAUSzMN1CoNP0CsdG4qg5KU816jFGH3h6npCriW?=
 =?us-ascii?Q?H8rkg4PX19nd2oMVcHhHayDA8S9pe5HDPMkn0HtlFKZk3GXhcZf8EJPEmSAe?=
 =?us-ascii?Q?AvGa9+8vr++ack2XZPHhuxBMnT8Yo1P5upsjb//ECrEkXJnatsf+h0TpjD1S?=
 =?us-ascii?Q?809heonGkx9SszBaRae3Z3sZAzk+hvE2GZSvcYdhdQqMVMCMXruUbBwQ9KOb?=
 =?us-ascii?Q?rgOJG9HsMysL7AkIe17/IfcOGAb+eEW15nS/mKE0zwZnGthUerUKr0RxvCdU?=
 =?us-ascii?Q?pOoSPjUjFZ/GEMZ8V3DdgA/pTWiLzCxE9MrKUgT5QdBNFkjICyWKNeE35t92?=
 =?us-ascii?Q?1IBOzNgV4jM8yMmT9pGCUFP144Xp7DHNYz1yfhgN6Jvv0ZJB5aG1Ob/1Uhny?=
 =?us-ascii?Q?F/VfFGxdnyODyH4GTVrBiHjG8pPY20VAeKFJs5BliQ9AIV1isWLp5icklsLo?=
 =?us-ascii?Q?THfV4RrftUiDBKMEzODpR4lmChA69+3b/w34oFpTV7PiLateuMJMiLgqhNwt?=
 =?us-ascii?Q?L66/ClTzfeTIv5RRiOtncGNhIOs7RfFW2IGjlf3PrecjkOqAMN5P8rybm0+r?=
 =?us-ascii?Q?XKsvM90s098cAnqVcviadXlQZ/MGEz85rqpYjkgZt1UmzokjV+bvRuWH4wiy?=
 =?us-ascii?Q?GG71dsInUNzpOetNf0iM7Bd+X3o1bcP3UmIdm5CTZHPZnt0KTl3Nkce83AGx?=
 =?us-ascii?Q?DvRSODfMq80I4gbP9IzFq64oryGeYn1sU5u5i9VhyiCZvd5FhTUug+VEm6Pj?=
 =?us-ascii?Q?fQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17e39974-82bc-410e-6d52-08da6396d54c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 23:41:10.2864
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SW4reE4B1goP1cqvQNsgsQkbPu6NO474Q1QcWnLaMh+Rxei9ygENRDHXPAmQj9cTg5OeLMtM6P0L+vucOy+XzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3725
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-11_25:2022-07-08,2022-07-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxscore=0
 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207110096
X-Proofpoint-GUID: 3rIlU-EAeEyhCnBFBxRbMxrOm87UMv8f
X-Proofpoint-ORIG-GUID: 3rIlU-EAeEyhCnBFBxRbMxrOm87UMv8f
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/24/22 17:36, James Houghton wrote:
> This allows fork() to work with high-granularity mappings. The page
> table structure is copied such that partially mapped regions will remain
> partially mapped in the same way for the new process.
> 
> Signed-off-by: James Houghton <jthoughton@google.com>
> ---
>  mm/hugetlb.c | 74 +++++++++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 59 insertions(+), 15 deletions(-)

FYI -
With https://lore.kernel.org/linux-mm/20220621235620.291305-5-mike.kravetz@oracle.com/
copy_hugetlb_page_range() should never be called for shared mappings.
Since HGM only works on shared mappings, code in this patch will never
be executed.

I have a TODO to remove shared mapping support from copy_hugetlb_page_range.
-- 
Mike Kravetz