Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1657556229.git.jhpark1013@gmail.com>
In-Reply-To: <cover.1657556229.git.jhpark1013@gmail.com>
From:   Jaehee <jhpark1013@gmail.com>
Date:   Mon, 11 Jul 2022 16:42:06 -0700
Message-ID: <CAA1TwFDoA2ZbjAY2Z2hmweJs1bnemSH2SSmj-9AeE74zmqJ8xw@mail.gmail.com>
Subject: Re: [PATCH net-next 0/3] net: ipv4/ipv6: new option to accept
 garp/untracked na only if in-network
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>, yoshfuji@linux-ipv6.org,
        dsahern@kernel.org, edumazet@google.com,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, shuah@kernel.org,
        linux-kernel@vger.kernel.org, aajith@arista.com,
        Roopa Prabhu <roopa@nvidia.com>,
        Andy Roulin <aroulin@nvidia.com>,
        Stefano Brivio <sbrivio@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jul 11, 2022 at 10:51 AM Jaehee Park <jhpark1013@gmail.com> wrote:
>
> The first patch adds an option to learn a neighbor from garp only if
> the src ip is in the same subnet of addresses configured on the
> interface. The option has been added to arp_accept in ipv4.
>
> The same feature has been added to ndisc (patch 2). For ipv6, the
> subnet filtering knob is an extension of the accept_untracked_na
> option introduced in these patches:
> https://lore.kernel.org/all/642672cb-8b11-c78f-8975-f287ece9e89e@gmail.com/t/
> https://lore.kernel.org/netdev/20220530101414.65439-1-aajith@arista.com/T/
>
> The third patch contains selftests for testing the different options
> for accepting arp and neighbor advertisements.
>
> Jaehee Park (3):
>   net: ipv4: new arp_accept option to accept garp only if in-network
>   net: ipv6: new accept_untracked_na option to accept na only if
>     in-network
>   selftests: net: arp_ndisc_untracked_subnets: test for arp_accept and
>     accept_untracked_na
>
>  Documentation/networking/ip-sysctl.rst        |  48 +--
>  include/linux/inetdevice.h                    |   2 +-
>  net/ipv4/arp.c                                |  24 +-
>  net/ipv6/addrconf.c                           |   2 +-
>  net/ipv6/ndisc.c                              |  29 +-
>  tools/testing/selftests/net/Makefile          |   1 +
>  .../net/arp_ndisc_untracked_subnets.sh        | 281 ++++++++++++++++++
>  7 files changed, 360 insertions(+), 27 deletions(-)
>  create mode 100755 tools/testing/selftests/net/arp_ndisc_untracked_subnets.sh
>
> --
> 2.30.2
>


I forgot a few cleanups. I will post a v2 soon.
Sorry about that!

Thanks,
Jaehee