Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 16:32:40 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     James Houghton <jthoughton@google.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Jue Wang <juew@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 07/26] hugetlb: add hugetlb_pte to track HugeTLB page
 table entries
Message-ID: <YsyzGMS+MS0kZoP8@monkey>
References: <20220624173656.2033256-1-jthoughton@google.com>
 <20220624173656.2033256-8-jthoughton@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220624173656.2033256-8-jthoughton@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sa9iTAjWopxYQUUFrfs15yfFR3rXkGPfgvtXuQ8lvvSfZPrRXKDociDygGVk?=
 =?us-ascii?Q?6IqxX52Jsfk1jlgqxRtRUALc5WwOqEcPwnwb8HZ7Gjc9zfqqhfQqhubbqSYr?=
 =?us-ascii?Q?c+f+1tE/QtQyJI460teOY5WDyanAjLyc3UKjv6hJjxL27RB7DZjJU1VNOjCH?=
 =?us-ascii?Q?ClerVJr0qRHk5tRIMaXDFUZxxc0IrnO0aTCbBIhHnVT6kuMLOamQgCi503uQ?=
 =?us-ascii?Q?Zl/GPL86FBWGB0HLJQRSelhA7ysUhvzc/AeNKBa3dLxAD4c1WKCHl3S277tp?=
 =?us-ascii?Q?DlmwYj5EJgpY5yOk2lNT98023NbUK/srAXFIpIpmXIjQUnrn9+IbVcUq4DNf?=
 =?us-ascii?Q?QR6n6/IYaQxs9t7bie+6lKkH553+qrag80yzUEhcKaCtoIpC9+PyWhn8XFnt?=
 =?us-ascii?Q?plrwPTnufGPvyj+L7fuoMysGXdO9Gf+2ytQ39Vc5RhWbPFY6XF6ZtwPLJUZc?=
 =?us-ascii?Q?iMNTLuIOk2F9BwZdydFLT1A3NK0+O1vI+Sj2+Bbqb/kODGBwjvbLE7VRPjmP?=
 =?us-ascii?Q?FUqjPgmzS4B4hioJ15cAXEvsLdofF3sB7RtSwqQW2JnRFIcj2cLwJrhXkiGB?=
 =?us-ascii?Q?upXLURnzu3S4Ww7eK7N118Ov6iByhMylRQA200Cd0tQcjhb+UWcidgScmuxh?=
 =?us-ascii?Q?uWv1HRMkfL2u5IY91td4hBxnhVfaTXXmL3EufsQgX40xtmje0jIiAcaf6pC0?=
 =?us-ascii?Q?g1UCad0MJQdQt+vcGZv7MxkBZuhnlky4YGWSrJa6SIu+gdOJV1yw1LbAOZXw?=
 =?us-ascii?Q?ELqPIxzxo/QGLrQlaWYhCWF4Jv3He0VNHoTfAyXqD7CDtfGhN6XtBODlMSg/?=
 =?us-ascii?Q?d/H8XzOfsfFwj+7Z+CsMH2YS7x1uZ5Dl1HLJqTq3avpRKcd17MHK5fjg7Eb1?=
 =?us-ascii?Q?CttzyHvq2rGKQYOIPtlplmeLHd7EAfcO6DECG0oJcxzlAluCd43MIfW4HiHJ?=
 =?us-ascii?Q?1FIqhX8n0UvJwCNWOA+fu7018RWAHCn/5tepf1NVlihWIj/qedhVyf1Pod0e?=
 =?us-ascii?Q?h5LU1+0xN0iF1ozD7eWG4divY4kijDDabOjHtdvDo6+qsnnbpDuRh6qBwt9v?=
 =?us-ascii?Q?lVxzNcxpjI3ryDDXS+MVRNnnpTyo5l6CtlcBPau3gSDnLZSviokZtMY2KDRn?=
 =?us-ascii?Q?8IhqhTbjPPUfHc9pXs9wpCnjZPE9HwFoypblASip0ZUp87bMnWO5yVsOWmek?=
 =?us-ascii?Q?WSYSRZ4rmaGvZIh5COceBiYpToe4xF/2FccFp+F8DU8EnqHZL538i2SA/DkB?=
 =?us-ascii?Q?fD06KuAqf59sghcKo54Jnd04NfUkY99fbtja89eByydchlULlVM0mx/k8XJJ?=
 =?us-ascii?Q?QI44iKtY2XFqjhuEXbw8EdBTim187cfklXwkmwVKMhQ5H/klZQy+qtD1BAe2?=
 =?us-ascii?Q?wbzCGPMXsxfr4WyACznxRnU6Y6lPng4oMkPS7ATXrs4a0DnFk/19W+BUILN3?=
 =?us-ascii?Q?MJrK2O47/jb9H7XFyYVGwG0ZdvOeoXcQcHGqPcOYKWsq8U8s52gh0gO/4MRy?=
 =?us-ascii?Q?nFrf2QWS4vFWR2LDqA2+MIK7JeG9SR+Z0GinXrBeeiFR4zXIKeg/9If4cXUr?=
 =?us-ascii?Q?KxVKMy9LvgywpoWDMCkdHv3srKdbpNM2l6urB/OKt21yeB2tHKegBwJ0gWmC?=
 =?us-ascii?Q?EA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41477d43-230b-4dee-6a09-08da6395a741
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 23:32:43.5579
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LcUhMUfFPRu1rdM9LAVHey0fU36wFn+0kwRk4wjD8Tq5AayCLojSy1EFmnr1v4fN0gcq+hu5FXtM4X1FvxnfWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1838
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-11_25:2022-07-08,2022-07-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=802 mlxscore=0 spamscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207110095
X-Proofpoint-GUID: 4S8zlA8R_Ii-n4t9_tJzcJY4-GGDiyUo
X-Proofpoint-ORIG-GUID: 4S8zlA8R_Ii-n4t9_tJzcJY4-GGDiyUo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/24/22 17:36, James Houghton wrote:
> After high-granularity mapping, page table entries for HugeTLB pages can
> be of any size/type. (For example, we can have a 1G page mapped with a
> mix of PMDs and PTEs.) This struct is to help keep track of a HugeTLB
> PTE after we have done a page table walk.

This has been rolling around in my head.

Will this first use case (live migration) actually make use of this
'mixed mapping' model where hugetlb pages could be mapped at the PUD,
PMD and PTE level all within the same vma?  I only understand the use
case from a high level.  But, it seems that we would want to only want
to migrate PTE (or PMD) sized pages and not necessarily a mix.

The only reason I ask is because the code might be much simpler if all
mappings within a vma were of the same size.  Of course, the
performance/latency of converting a large mapping may be prohibitively
expensive.

Looking to the future when supporting memory error handling/page poisoning
it seems like we would certainly want multiple size mappings.

Just a thought.
-- 
Mike Kravetz