Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7fb06e9c-6405-9bee-5eda-7dbd56511e2c@gmail.com>
Date:   Mon, 11 Jul 2022 17:02:51 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.1
Subject: Re: [PATCH] MIPS: Fixed __debug_virt_addr_valid()
Content-Language: en-US
To:     Serge Semin <fancer.lancer@gmail.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     linux-mips@vger.kernel.org, gerg@kernel.org,
        open list <linux-kernel@vger.kernel.org>
References: <20220707215237.1730283-1-f.fainelli@gmail.com>
 <20220711083848.GE6084@alpha.franken.de>
 <20220711104052.ddefbgd34xbbjykg@mobilestation>
 <20220711112740.GA12918@alpha.franken.de>
 <20220711112953.j4dwany3i77df4xe@mobilestation>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20220711112953.j4dwany3i77df4xe@mobilestation>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/11/2022 4:29 AM, Serge Semin wrote:
> On Mon, Jul 11, 2022 at 01:27:40PM +0200, Thomas Bogendoerfer wrote:
>> On Mon, Jul 11, 2022 at 01:40:52PM +0300, Serge Semin wrote:
>>> On Mon, Jul 11, 2022 at 10:38:48AM +0200, Thomas Bogendoerfer wrote:
>>>> On Thu, Jul 07, 2022 at 02:52:36PM -0700, Florian Fainelli wrote:
>>>>> It is permissible for kernel code to call virt_to_phys() against virtual
>>>>> addresses that are in KSEG0 or KSEG1 and we need to be dealing with both
>>>>> types. Add a final condition that ensures that the virtual address is
>>>>> below KSEG2.
>>>>>
>>>>> Fixes: dfad83cb7193 ("MIPS: Add support for CONFIG_DEBUG_VIRTUAL")
>>>>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>>>>> ---
>>>>>   arch/mips/mm/physaddr.c | 3 ++-
>>>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/mips/mm/physaddr.c b/arch/mips/mm/physaddr.c
>>>>> index a1ced5e44951..a82f8f57a652 100644
>>>>> --- a/arch/mips/mm/physaddr.c
>>>>> +++ b/arch/mips/mm/physaddr.c
>>>>> @@ -5,6 +5,7 @@
>>>>>   #include <linux/mmdebug.h>
>>>>>   #include <linux/mm.h>
>>>>>   
>>>>> +#include <asm/addrspace.h>
>>>>>   #include <asm/sections.h>
>>>>>   #include <asm/io.h>
>>>>>   #include <asm/page.h>
>>>>> @@ -30,7 +31,7 @@ static inline bool __debug_virt_addr_valid(unsigned long x)
>>>>>   	if (x == MAX_DMA_ADDRESS)
>>>>>   		return true;
>>>>>   
>>>>> -	return false;
>>>>> +	return KSEGX(x) < KSEG2;
>>>>>   }
>>>>>   
>>>>>   phys_addr_t __virt_to_phys(volatile const void *x)
>>>>> -- 
>>>>> 2.25.1
>>>>
>>>
>>>> applied to mips-next.
>>>
>>> Are you sure it was ready to be applied?
>>> Link: https://lore.kernel.org/linux-mips/20220708115851.ejsooiilxcopkoei@mobilestation/
>>
> 
>> your comment sounded like optimizing, which can be done later on, so
>> I assumed it ready.
> 
> What about Malta and EVA?

Sergey's comment definitively need to be addressed, and I would not see 
the point in making an incremental change to a wrong fix. Can you drop 
that patch for now? Thanks!
-- 
Florian