Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Seunghui Lee" <sh043.lee@samsung.com>
To:     <ulf.hansson@linaro.org>, <u.kleine-koenig@pengutronix.de>,
        <gregkh@linuxfoundation.org>, <linux@dominikbrodowski.net>,
        <alexandre.belloni@bootlin.com>, <linux-mmc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Cc:     <grant.jung@samsung.com>, <jt77.jang@samsung.com>,
        <dh0421.hwang@samsung.com>, <junwoo80.lee@samsung.com>,
        <jangsub.yi@samsung.com>, <cw9316.lee@samsung.com>,
        <sh8267.baek@samsung.com>, <wkon.kim@samsung.com>,
        <seunghwan.hyun@samsung.com>
In-Reply-To: <20220705005035.14195-1-sh043.lee@samsung.com>
Subject: RE: [PATCH] mmc: print clock frequency with recognization
Date:   Tue, 12 Jul 2022 09:08:14 +0900
Message-ID: <013f01d89583$7b320640$719612c0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Language: ko
Thread-Index: AQGudEnl4+ePR7A4svMh0q0LRTjrCwLdAL9lrbc0OcA=
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20220705001814epcas1p40a4eadbf8429f01a98bdb56f00ba3310@epcas1p4.samsung.com>
        <20220705005035.14195-1-sh043.lee@samsung.com>
Precedence: bulk

> -----Original Message-----
> From: Seunghui Lee <sh043.lee=40samsung.com>
> Sent: Tuesday, July 5, 2022 9:51 AM
> To: ulf.hansson=40linaro.org; u.kleine-koenig=40pengutronix.de;
> gregkh=40linuxfoundation.org; linux=40dominikbrodowski.net;
> alexandre.belloni=40bootlin.com; linux-mmc=40vger.kernel.org; linux-
> kernel=40vger.kernel.org
> Cc: grant.jung=40samsung.com; jt77.jang=40samsung.com;
> dh0421.hwang=40samsung.com; junwoo80.lee=40samsung.com; jangsub.yi=40sams=
ung.com;
> cw9316.lee=40samsung.com; sh8267.baek=40samsung.com; wkon.kim=40samsung.c=
om;
> seunghwan.hyun=40samsung.com; Seunghui Lee <sh043.lee=40samsung.com>
> Subject: =5BPATCH=5D mmc: print clock frequency with recognization
>=20
> It's easy to figure out how fast frequency it has from the log.
> e.g. mmc0: new ultra high speed SDR104 SDXC card at address aaaa(clk
> 202000000)
>=20
> Signed-off-by: Seunghui Lee <sh043.lee=40samsung.com>
> ---
>  drivers/mmc/core/bus.c =7C 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index
> 58a60afa650b..3623cc27a61c 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> =40=40 -348,7 +348,7 =40=40 int mmc_add_card(struct mmc_card *card)
>  			mmc_card_ddr52(card) ? =22DDR =22 : =22=22,
>  			type);
>  	=7D else =7B
> -		pr_info(=22%s: new %s%s%s%s%s%s card at address %04x=5Cn=22,
> +		pr_info(=22%s: new %s%s%s%s%s%s card at
> address %04x(clk %u)=5Cn=22,
>  			mmc_hostname(card->host),
>  			mmc_card_uhs(card) ? =22ultra high speed =22 :
>  			(mmc_card_hs(card) ? =22high speed =22 : =22=22), =40=40 -356,7
> +356,8 =40=40 int mmc_add_card(struct mmc_card *card)
>  			(mmc_card_hs200(card) ? =22HS200 =22 : =22=22),
>  			mmc_card_hs400es(card) ? =22Enhanced strobe =22 : =22=22,
>  			mmc_card_ddr52(card) ? =22DDR =22 : =22=22,
> -			uhs_bus_speed_mode, type, card->rca);
> +			uhs_bus_speed_mode, type, card->rca,
> +			card->host->ios.clock);
>  	=7D
>=20
>  =23ifdef CONFIG_DEBUG_FS
> --
> 2.29.0
Please give me any opinion or suggestion about this commit.
Normally, the SD card's bus speed depends on both host controller and inter=
nal PLL.
There are lots of host controller vendor in the market as well.
So, we can guess the exact clock speed from this commit.