Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
Subject: Re: [PATCH] x86/mm/tlb: Skip tracing when flush is not done
From:   Nadav Amit <nadav.amit@gmail.com>
In-Reply-To: <1c58c7e1-2c21-e0d2-34c7-252074ecc70d@kernel.org>
Date:   Mon, 11 Jul 2022 16:42:14 -0700
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        X86 ML <x86@kernel.org>, Linux MM <linux-mm@kvack.org>,
        Peter Zijlstra <peterz@infradead.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <798B000F-043A-4C5A-82C0-D7CF1BCDEDE1@gmail.com>
References: <20220710233355.4066-1-namit@vmware.com>
 <1c58c7e1-2c21-e0d2-34c7-252074ecc70d@kernel.org>
To:     Andy Lutomirski <luto@kernel.org>
Precedence: bulk

On Jul 11, 2022, at 3:50 PM, Andy Lutomirski <luto@kernel.org> wrote:

> On 7/10/22 16:33, Nadav Amit wrote:
>> From: Nadav Amit <namit@vmware.com>
>> Currently, if flush_tlb_func() does not flush for some reason, the
>> tracing of the flush will be done only in certain cases, depending on
>> the reason of the flush. Be consistent and just do not trace in all
>> cases when the flush was eventually not done.
>> Suggested-by: Dave Hansen <dave.hansen@linux.intel.com>
>> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
>> Cc: Andy Lutomirski <luto@kernel.org>
>> Signed-off-by: Nadav Amit <namit@vmware.com>
>=20
>=20
> Can you remove this comment, too?
>=20
>>  	/* Tracing is done in a unified manner to reduce the code size =
*/

Yes. I will send v2.

=E2=80=A6 And if you have time, can you please review the other TLB =
patch that I
sent? It is a really urgent one.

Thanks,
Nadav