Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220708211755.73637-1-schspa@gmail.com>
 <20220708172614.14191089@gandalf.local.home> <m2v8s7mg78.fsf@gmail.com>
 <20220711161037.06b8c1ea@gandalf.local.home> <m2edyrnny9.fsf@gmail.com>
 <20220711211639.6c714635@gandalf.local.home>
User-agent: mu4e 1.7.5; emacs 28.1
From:   Schspa Shi <schspa@gmail.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
        vschneid@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] sched/rt: fix bad task migration for rt tasks
Date:   Tue, 12 Jul 2022 09:33:58 +0800
In-reply-to: <20220711211639.6c714635@gandalf.local.home>
Message-ID: <m2sfn7glkk.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Steven Rostedt <rostedt@goodmis.org> writes:

> On Tue, 12 Jul 2022 08:53:56 +0800
> Schspa Shi <schspa@gmail.com> wrote:
>
>> How about to change this to 
>> 
>> 			/*
>> 			 * We had to unlock the run queue. In
>> 			 * the mean time, task could have
>> 			 * migrated already or had its affinity changed.
>> 			 * Also make sure that it wasn't scheduled on its rq.
>> 			 * It is possible the task was scheduled, set
>>              * "migrate_disabled" and then got preempted, And we
>>              * check task migration disable flag here too.
>> 			 */
>
> That's better. But of course it needs better formatting ;-)
>
> -- Steve

I have upload a v5 patch for this comment change, please review it. ;-)
Link: https://lore.kernel.org/all/20220712013125.623338-1-schspa@gmail.com/T/#t

-- 
BRs
Schspa Shi