Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Huang, Ying" <ying.huang@intel.com>
To:     Oscar Salvador <osalvador@suse.de>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Zi Yan <ziy@nvidia.com>, Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH -V2 1/7] migrate: fix syscall move_pages() return value
 for failure
In-Reply-To: <YswPApwvAjvX1VEd@localhost.localdomain> (Oscar Salvador's
        message of "Mon, 11 Jul 2022 13:52:34 +0200")
References: <20220711084948.274787-1-ying.huang@intel.com>
        <20220711084948.274787-2-ying.huang@intel.com>
        <YswPApwvAjvX1VEd@localhost.localdomain>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Date:   Tue, 12 Jul 2022 08:59:12 +0800
Message-ID: <87zghf5eov.fsf@yhuang6-desk2.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Precedence: bulk

Oscar Salvador <osalvador@suse.de> writes:

> On Mon, Jul 11, 2022 at 04:49:42PM +0800, Huang Ying wrote:
>>  	return store_status(status, start, node, i - start);
>> @@ -1768,8 +1768,12 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
>>  
>>  		err = move_pages_and_store_status(mm, current_node, &pagelist,
>>  				status, start, i, nr_pages);
>> -		if (err)
>> +		if (err) {
>> +			/* We have stored status of page i */
>
> IMHO, "We have accounted for page i" gives a more clear statement.

Sure.  Will change this.

> Reviewed-by: Oscar Salvador <osalvador@suse.de>

Thanks!

Best Regards,
Huang, Ying

>> +			if (err > 0)
>> +				err--;
>>  			goto out;
>> +		}
>>  		current_node = NUMA_NO_NODE;
>>  	}
>>  out_flush:
>> -- 
>> 2.30.2
>> 
>>