Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 09:28:23 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Georgi Djakov <djakov@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Rob Herring <robh+dt@kernel.org>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/5] interconnect: qcom: icc-rpm: Set bandwidth and
 clock for bucket values
Message-ID: <20220712012823.GA10379@leoy-ThinkPad-X240s>
References: <20220711115240.806236-1-leo.yan@linaro.org>
 <20220711115240.806236-6-leo.yan@linaro.org>
 <480d38db-3114-29d1-8b81-b35a07623060@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <480d38db-3114-29d1-8b81-b35a07623060@kernel.org>
Precedence: bulk

Hi Georgi,

On Mon, Jul 11, 2022 at 04:53:47PM +0300, Georgi Djakov wrote:

[...]

> >   static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
> >   {
> >   	struct qcom_icc_provider *qp;
> >   	struct qcom_icc_node *src_qn = NULL, *dst_qn = NULL;
> >   	struct icc_provider *provider;
> > -	struct icc_node *n;
> >   	u64 sum_bw;
> > -	u64 max_peak_bw;
> >   	u64 rate;
> > -	u32 agg_avg = 0;
> > -	u32 agg_peak = 0;
> > +	u64 agg_avg[QCOM_ICC_NUM_BUCKETS], agg_peak[QCOM_ICC_NUM_BUCKETS];
> > +	u64 max_agg_avg, max_agg_peak;
> 
> Now max_agg_peak is unused?

Sorry for this mistake.  Will send new patch series soon.

Thanks,
Leo