Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alexander Gordeev <agordeev@linux.ibm.com>
Subject: [PATCH] maple_tree: Fix mas_empty_area_rev() search exhaustion at
 root node
Thread-Topic: [PATCH] maple_tree: Fix mas_empty_area_rev() search exhaustion
 at root node
Thread-Index: AQHYlZHHZk0mGqDhCkmeguxOWUt84w==
Date:   Tue, 12 Jul 2022 01:50:36 +0000
Message-ID: <20220712014957.4064879-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?+CHfyr7eqoa5svK0jnRoyQvz8SZrA5Qrmiwxma3SqE1d7NaFd1+MkmignW?=
 =?iso-8859-1?Q?Wr0cZY1F7MYdHXK/sG/t8N1gn2x/amL5o9BQlHZqbkbsMYsEqEvX2KRME1?=
 =?iso-8859-1?Q?BVT6NQG6BWwcz6AKLNkCe9dGJDMVw/3QjQ1ywQj17Qi2XzP9Uf6FRGoxDY?=
 =?iso-8859-1?Q?5bGYPsuAnny+tNElcnGiBjjbsVrGKdlwNLHHjtbj6v29cdnjI/XkLZsNwM?=
 =?iso-8859-1?Q?06q0Bl/3RhfP1N8RpAe02ql9OpFGhhE+xncwZ9n7On4AgrfuC6jNooF+xh?=
 =?iso-8859-1?Q?HessIwA9M+7C8qBSC1FJmsLchiFELSuc+DmIyU+NdnVNLILeWdKycbiNwc?=
 =?iso-8859-1?Q?f93ZzumlnMGq0wVXw9ifB6ctSRoh9sE5gzwxUrwFIU7Be7qO5UhI2OfiTA?=
 =?iso-8859-1?Q?tjeqwKFuZZ4GwwbnJkmsJgFZFe2jsFKaiC4naw/Z90nJUNkGzR/qfuApND?=
 =?iso-8859-1?Q?uaRoEKV8K5+Tn56JkRSlZI1DUbAER0tqmwrxGXodNDgnxTnA9q4YLsd1OK?=
 =?iso-8859-1?Q?Q6lMHGe/z0F3utJkTXt+rE2WNcfDyCeoeRXzOkUPn3J63YKYqxbvbvZLPz?=
 =?iso-8859-1?Q?OPMHtmIxEfDfzPnMTSyI1XzeppTsgMQh5vsXV3qhXmRctQMN9fXAmoQlz8?=
 =?iso-8859-1?Q?7CpAQaVvMZwM3PAGhrqeVFP9HR0KnyeGAlspQTC9idUek6SKOHsMv3y4BO?=
 =?iso-8859-1?Q?/fPNiEDTZ+lCKQYM5nXwb/Ze0iUX++cksvNknzizMub8r2c9JQjI73rALQ?=
 =?iso-8859-1?Q?SACl+G2nFx7ZSmQdCrgJlwzEvxENt5J4ePZgSzTojsSB8cE6xRfsbr4MOS?=
 =?iso-8859-1?Q?cSIg0OTM6tZfQZBqWK5MRPHrWi0ETDVBwDDGi2/BJQWtfPfEOWSItemMwn?=
 =?iso-8859-1?Q?e2cY4vJKHOwjBd/DstFO06xh1RYVsMxZpQgW1uk6XXudW23+ssuOH3XS/M?=
 =?iso-8859-1?Q?Qw5zSgsdg52BkbjXRCAUtX3g3D7ssJ3cOOG6+hlphhVa8zwaHH+Mr4Cp4T?=
 =?iso-8859-1?Q?XRNVLLpQPFdQh/ql+nQVJ1/Xd3ZvR0aumGKE19DAyyo9+XQQtPN+EQH027?=
 =?iso-8859-1?Q?2i1i+oleeY1iluSLYHXol8zGPyKocmRTVGYeYi0MRqGIDq3k3cmiLCaofi?=
 =?iso-8859-1?Q?jRHS6gaLOacieAT14G67Qxdjd9lr+LOEiAhx4nWJ7A2pmfVjPYap4CQnf2?=
 =?iso-8859-1?Q?tu7Ihbc3PbEK+MWHgLvcBGYBG5mPq285xRgBPDY1OCep6S1fMInGiPp5KB?=
 =?iso-8859-1?Q?yLDaaLs5Skvw45QKQzX7b/jKlGz8F2lA5Fk+KEp0yEWhbmqWdRV5Hva9iR?=
 =?iso-8859-1?Q?75yIDbV6QyfcusRzu8Lw6bHoVlyZldmw2lWJCQJJ4mZ6WJWQw+5EZyg6ey?=
 =?iso-8859-1?Q?8ICgT2s9WeVKSWD0ELV8RtWYI0B2P5msYDv5uBFsWXUwMrZsk1+cw/+Sxl?=
 =?iso-8859-1?Q?xCngyp/cSM3/nq8wcrm8FgaRqrjNuYqLVPaEAVpHYdqIjVLHkIQ3hXBhqO?=
 =?iso-8859-1?Q?xnEsNCkiNShHxlYttIOUDsJhmvAjdB+uSUpyy3vgL3IZLZKkomMK2Khjek?=
 =?iso-8859-1?Q?lE4dUFQXVtJF/qdb2T3Xj4EdiVkd5dfYA+2k82mOvozsGwIZKFbVCyXaJm?=
 =?iso-8859-1?Q?60lCDtsSFVFILbgCSYCXAX1I8yYMb2lUsyNlCGNm0RWPbHGT+Bn48TVA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99f9ebe0-f462-47e9-729e-08da63a8ea84
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2022 01:50:36.5925
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UlQbe55q9czlkkuxJi9fT6IjSNHkj2aKlphcd6rigNURWDb7nOk8muTfDOWIJjWzy7edr66ltuSBSdG+rQCA0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6267
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-12_01:2022-07-08,2022-07-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 malwarescore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207120006
X-Proofpoint-GUID: j2zh3dGQQwaCP6MSyrZ-Sm_xCcyuMf98
X-Proofpoint-ORIG-GUID: j2zh3dGQQwaCP6MSyrZ-Sm_xCcyuMf98
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When the possibilities of finding a gap are exhausted at the root node,
the error code was not returned which results in returning a range that
is currently occupied.  Add the necessary check for the error code and
return to the caller.

Reported-by: Alexander Gordeev <agordeev@linux.ibm.com>
Fixes: d0aac5e48048 (Maple Tree: add new data structure)
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 lib/maple_tree.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 9dc4ffff18d0..14e9ab14c1da 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5287,6 +5287,9 @@ int mas_empty_area_rev(struct ma_state *mas, unsigned=
 long min,
 		}
 	}
=20
+	if (mas_is_err(mas))
+		return xa_err(mas->node);
+
 	if (unlikely(mas->offset =3D=3D MAPLE_NODE_SLOTS))
 		return -EBUSY;
=20
--=20
2.35.1