Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 10:37:14 +0800
From:   Kent Gibson <warthog618@gmail.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] gpio: sim: fix the chip_name configfs item
Message-ID: <20220712023714.GA9406@sol>
References: <20220711173418.91709-1-brgl@bgdev.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220711173418.91709-1-brgl@bgdev.pl>
Precedence: bulk

On Mon, Jul 11, 2022 at 07:34:18PM +0200, Bartosz Golaszewski wrote:
> The chip_name configs attribute always displays the device name of the
> first GPIO bank because the logic of the relevant function is simply
> wrong.
> 
> Fix it by correctly comparing the bank's swnode against the GPIO
> device's children.
> 

That works for me, so thanks for that.

Not totally convinced by Andy's suggestion to rename swnode to fwnode.
Variables should be named for what they represent, not their type, and
you use swnode extensively elsewhere in the module, so either change it
everywhere or not at all, and such a sweeping change is beyond the scope
this patch.

Though it may make his other suggestion to use device_match_fwnode()
read a little better.  No issue with that suggestion.

Cheers,
Kent.