Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3977562imw; Mon, 11 Jul 2022 21:47:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uebmdyD3w8TBnxatl5+M/bASLoBvnIuOp3m8df9N3Rzcsl1yMeAOpQ9WUxCx+YMqJcH/Gl X-Received: by 2002:a17:907:3ea6:b0:72b:4a06:989a with SMTP id hs38-20020a1709073ea600b0072b4a06989amr11669873ejc.168.1657601265815; Mon, 11 Jul 2022 21:47:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657601265; cv=none; d=google.com; s=arc-20160816; b=U+48286URGC4Q7WF3yFZ20Z+cb0Rnf1sE2GqqDlMtcvw1lJRwoBx7s6+YC7hfUTUcx sn+Vs/NAZci66//d1H7rHs0XjTpmB7jYDmpYUWZUCdGK5qu3Q7CmFqn7FZLttpbHwbMA Pr3a4eVYejHEdvicRIayVmRIstjV5Mfvn9Kfno+64cNd3IF4iRSR/SlL9+TOZ1S3TvZk f6Y8glxizzrnXQWxDu78m5jj3pv9BxtO4MT/OAg9PkBU0+DMt8HWAjH9Q11bPQkbAgvp ZyUJkwraSSqjaKx1a2ks5pJcCnJEg0QrfbIJySrXnXOs0qa+6Ubu77G2dL9Q1oN5XdDF gugw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=X1H4iTaGBABhmn8tOuCBSLbmPwsiUysDxHfqz4KTFB0=; b=HlBhQpIxquu6qdR/AwZbr9dn/KWWSIqp3Slp09dsjYSCZ5banUJiMeKhmZt8I287cx Ybi5s3cHWK75iBuoqKWkRvylVpoOPerLtcn/BIxeYs8G2i2wYJnqwGh7DEolDP6SvxsJ U05JNUX0eZsyJ6HaGULCU03u2oIfiBm5YnanxWJ4yrgmIuJXRRFW/FY/hNlo5z9RjiKD UeOv7Togsfl3XSS6F4Ek7h10UTeVOGq4Y3JsgG5E8xxWf6AHFtLTgPwebgr5mvkAJnT4 6nBmf+/Jbv40Fha3u1QknUgfqIuGEj/tcqzFamuaWA5+yiCiSSmibWoDROvUCrx2fzDe Hcag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=0M+SICsZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp11-20020a1709071b0b00b007296e194403si14236681ejc.273.2022.07.11.21.47.19; Mon, 11 Jul 2022 21:47:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=0M+SICsZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231145AbiGLEYa (ORCPT + 99 others); Tue, 12 Jul 2022 00:24:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231228AbiGLEYU (ORCPT ); Tue, 12 Jul 2022 00:24:20 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B806220E3; Mon, 11 Jul 2022 21:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X1H4iTaGBABhmn8tOuCBSLbmPwsiUysDxHfqz4KTFB0=; b=0M+SICsZdr6b34t1NTp14Vgb/L fpyen0doQO+i4tp+rZWBTPlHpvI5stRkmD0+5/Axt2gkOHZ5pLDEI7tep9nlJtVnTq6Lx6sONVc+L 7cbzob8jbqoBZhLKwZkZ7UDv9dPplq34qHrqWvLcglh1f7r5LOPBLmR8BCHPTWb6U4fAskUphOGeN JCACIktUx2K23iBO8kBGut0FhsaMlWFyAb8392pDCMkYzlKbR1byslNj+WYrUrdMDxO9NgWX1ahn+ +FyqjpLqDRoB8eECI5Ly5NZx20RzYhAQIiko0AiCHJt51k+LcmRj2Kn55gzC5oyQDlq+3qNX8wYnd nKRGVp2Q==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oB7RM-007J5x-1f; Tue, 12 Jul 2022 04:24:04 +0000 Date: Mon, 11 Jul 2022 21:24:04 -0700 From: Luis Chamberlain To: Song Liu , Peter Zijlstra , Steven Rostedt , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Masami Hiramatsu , "Naveen N. Rao" , "David S. Miller" , Anil S Keshavamurthy , Kees Cook Cc: Song Liu , bpf , Christoph Hellwig , Davidlohr Bueso , lkml , Linux-MM , Daniel Borkmann , Kernel Team , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "rick.p.edgecombe@intel.com" , "linux-modules@vger.kernel.org" Subject: Re: [PATCH v6 bpf-next 0/5] bpf_prog_pack followup Message-ID: References: <20220707223546.4124919-1-song@kernel.org> <863A2D5B-976D-4724-AEB1-B2A494AD2BDB@fb.com> <6214B9C9-557B-4DC0-BFDE-77EAC425E577@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2022 at 09:18:53PM -0700, Luis Chamberlain wrote: > A vmalloc_ro_exec() by definition would imply a text_poke(). > > Can kprobes, ftrace and modules use it too? It would be nice > so to not have to deal with the loose semantics on the user to > have to use set_vm_flush_reset_perms() on ro+x later, but > I think this can be addressed separately on a case by case basis. And who knows, if they can, and can also share a huge page allocator then they may also share similar performance improvements. Luis