Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 13:00:51 +0800
From:   Zhenyu Wang <zhenyuw@linux.intel.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     Jani Nikula <jani.nikula@linux.intel.com>,
        Lucas De Marchi <lucas.demarchi@intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/32] drm/i915: gvt: fix kernel-doc trivial warnings
Message-ID: <20220712050051.GW1089@zhen-hp.sh.intel.com>
Reply-To: Zhenyu Wang <zhenyuw@linux.intel.com>
References: <cover.1657565224.git.mchehab@kernel.org>
 <15fc6317ef5eb4ad7123d627c58c4aa04a4eae87.1657565224.git.mchehab@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="BYl/BInBdgsQr4gH"
Content-Disposition: inline
In-Reply-To: <15fc6317ef5eb4ad7123d627c58c4aa04a4eae87.1657565224.git.mchehab@kernel.org>
Precedence: bulk


--BYl/BInBdgsQr4gH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2022.07.11 21:24:49 +0100, Mauro Carvalho Chehab wrote:
> Some functions seem to have been renamed without updating the kernel-doc
> markup causing warnings. Also, struct intel_vgpu_dmabuf_obj is not
> properly documented, but has a kerneld-doc markup.
>=20
> Fix those warnings:
> 	drivers/gpu/drm/i915/gvt/aperture_gm.c:308: warning: expecting prototype=
 for inte_gvt_free_vgpu_resource(). Prototype was for intel_vgpu_free_resou=
rce() instead
> 	drivers/gpu/drm/i915/gvt/aperture_gm.c:344: warning: expecting prototype=
 for intel_alloc_vgpu_resource(). Prototype was for intel_vgpu_alloc_resour=
ce() instead
> 	drivers/gpu/drm/i915/gvt/cfg_space.c:257: warning: expecting prototype f=
or intel_vgpu_emulate_cfg_read(). Prototype was for intel_vgpu_emulate_cfg_=
write() instead
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or mem=
ber 'vgpu' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or mem=
ber 'info' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or mem=
ber 'dmabuf_id' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or mem=
ber 'kref' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or mem=
ber 'initref' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or mem=
ber 'list' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/handlers.c:3066: warning: expecting prototype f=
or intel_t_default_mmio_write(). Prototype was for intel_vgpu_default_mmio_=
write() instead
> 	drivers/gpu/drm/i915/gvt/mmio_context.c:560: warning: expecting prototyp=
e for intel_gvt_switch_render_mmio(). Prototype was for intel_gvt_switch_mm=
io() instead
> 	drivers/gpu/drm/i915/gvt/page_track.c:131: warning: expecting prototype =
for intel_vgpu_enable_page_track(). Prototype was for intel_vgpu_disable_pa=
ge_track() instead
> 	drivers/gpu/drm/i915/gvt/vgpu.c:215: warning: expecting prototype for in=
tel_gvt_active_vgpu(). Prototype was for intel_gvt_activate_vgpu() instead
> 	drivers/gpu/drm/i915/gvt/vgpu.c:230: warning: expecting prototype for in=
tel_gvt_deactive_vgpu(). Prototype was for intel_gvt_deactivate_vgpu() inst=
ead
> 	drivers/gpu/drm/i915/gvt/vgpu.c:358: warning: expecting prototype for in=
tel_gvt_destroy_vgpu(). Prototype was for intel_gvt_destroy_idle_vgpu() ins=
tead
>=20
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---

Hi, thanks for this, but there're already several fixes in queue right now,=
 e.g
https://patchwork.freedesktop.org/series/104302/ and
https://patchwork.freedesktop.org/series/104640/, but looks there're other =
uncaught issues.
I'd like to submit current in queue first, then maybe you could update for =
others?


--BYl/BInBdgsQr4gH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCYsz/+gAKCRCxBBozTXgY
J4vQAKCMH46gTKH1fklSj9leE4TwPisR4QCeO3K7++guiaV79LrJuEyXo9VDYGI=
=vaK2
-----END PGP SIGNATURE-----

--BYl/BInBdgsQr4gH--