Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b2a6c5f0bf0123a936ffac4f669488bf70d8c490.camel@icenowy.me>
Subject: Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS
 compatibles
From:   Icenowy Zheng <uwu@icenowy.me>
To:     Samuel Holland <samuel@sholland.org>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>
Cc:     Chanwoo Choi <cw00.choi@samsung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Maxime Ripard <maxime@cerno.tech>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-sunxi@lists.linux.dev
Date:   Tue, 12 Jul 2022 13:52:45 +0800
In-Reply-To: <20220702042447.26734-2-samuel@sholland.org>
References: <20220702042447.26734-1-samuel@sholland.org>
         <20220702042447.26734-2-samuel@sholland.org>
Organization: Anthon Open-Source Community
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

=E5=9C=A8 2022-07-01=E6=98=9F=E6=9C=9F=E4=BA=94=E7=9A=84 23:24 -0500=EF=BC=
=8CSamuel Holland=E5=86=99=E9=81=93=EF=BC=9A
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences
> in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.

Should this kind of assignment be described in DT instead?

>=20
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>=20
> =C2=A0.../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml=C2=A0=C2=A0 | =
10
> ++++++++++
> =C2=A01 file changed, 10 insertions(+)
>=20
> diff --git
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-
> mbus.yaml
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-
> mbus.yaml
> index 2b018feb56df..99566688d033 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-
> a10-mbus.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-
> a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
> =C2=A0=C2=A0 compatible:
> =C2=A0=C2=A0=C2=A0=C2=A0 enum:
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun5i-a13-mbus
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun8i-a33-mbus
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun8i-a50-mbus
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun8i-a83t-mbus
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun8i-h3-mbus
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun8i-r40-mbus
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun8i-v3s-mbus
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun8i-v536-mbus
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun20i-d1-mbus
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun50i-a64-mbus
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun50i-a100-mbus
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun50i-h5-mbus
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun50i-h6-mbus
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun50i-h616-mbus
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - allwinner,sun50i-r329-mbus
> =C2=A0
> =C2=A0=C2=A0 reg:
> =C2=A0=C2=A0=C2=A0=C2=A0 minItems: 1