Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Chanho Park" <chanho61.park@samsung.com>
To:     "'Arnd Bergmann'" <arnd@arndb.de>,
        "'Youngmin Nam'" <youngmin.nam@samsung.com>
Cc:     "'John Stultz'" <jstultz@google.com>,
        "'Thomas Gleixner'" <tglx@linutronix.de>,
        "'Stephen Boyd'" <sboyd@kernel.org>,
        "'Linux Kernel Mailing List'" <linux-kernel@vger.kernel.org>,
        <hajun.sung@samsung.com>, <hosung0.kim@samsung.com>,
        <d7271.choe@samsung.com>
In-Reply-To: <CAK8P3a0pCov7ZiNhG+by7PpxMdBbBpUa7TKNc9e0p-zXvqg-7g@mail.gmail.com>
Subject: RE: [PATCH] time: remove useless "const" keyword in
 ns_to_kernel_old_timeval() and ns_to_timespec64()
Date:   Tue, 12 Jul 2022 16:49:46 +0900
Message-ID: <01a201d895c3$f4955ba0$ddc012e0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJDeDvkkBXeDou4pRSMa+nAkmZkTQMAn7SBAeYw4mOsfV+nQA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20220712071941epcas2p2faa87d8efe182e9c28a924ea3de15209@epcas2p2.samsung.com>
        <20220712074705.420399-1-youngmin.nam@samsung.com>
        <CAK8P3a0pCov7ZiNhG+by7PpxMdBbBpUa7TKNc9e0p-zXvqg-7g@mail.gmail.com>
Precedence: bulk

> > As mentioned below,
> >
> https://lore.kernel.org/lkml/CAK8P3a3nknJgEDESGdJH91jMj6R_xydFqWASd8r5Bbe=
s
> dvMBgA=40mail.gmail.com/

I'm not sure why you drop my originality but please use my commit message a=
nd put this link between --- and include/linux/time32.h if you need additio=
nal comments.
https://lore.kernel.org/all/20220531064346.51677-1-chanho61.park=40samsung.=
com/T/

Indeed you should put Fixes tag for stable tree.

Best Regards,
Chanho Park

> >
> > The =22const=22 keyword is useless, so we drop it from the function
> definition and declaration.
> >
> > Change-Id: If35bba78aa7757476e22be42afc719c27fb0f527
> > Signed-off-by: Youngmin Nam <youngmin.nam=40samsung.com>
>=20
> The patch looks good, but the description can be improved:
>=20
> - drop the useless Change-Id field
> - move the URL into a 'Link: field'
> - wrap the lines to fit into the normal width of an email (under 80
> characters,
>   ideally 70)
> - explain why the change helps, rather than just stating the keyword is
> useless.
>   In your description, it's not clear if one is better than the other, it
> sounds
>   like it should make no difference.
>=20
> With that done:
>=20
> Reviewed-by: Arnd Bergmann <arnd=40arndb.de>