Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <13c5ca05-a366-2751-4f26-d978d074f748@amd.com>
Date:   Tue, 12 Jul 2022 09:40:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [RFC][PATCH 1/3] drm: drm_syncobj: Add note in DOC about absolute
 timeout values
Content-Language: en-US
To:     John Stultz <jstultz@google.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jason Ekstrand <jason@jlekstrand.net>,
        Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
        Chunming Zhou <david1.zhou@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org
References: <20220712042258.293010-1-jstultz@google.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220712042258.293010-1-jstultz@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEdPaVpGK2E5b3Z5c04xS0lqOVFvcXRZSzVCMHY5K3UvQjltZDE4bnhKYkJy?=
 =?utf-8?B?YXJZVENWekowcUFuWXlXQWhVNTZjeE5ONXBhSGxPTTkyTFk4bmVLclpBdXlS?=
 =?utf-8?B?RjFnaGpGRGM1QmJZMUp4eVJBT0hTMlA3ekdEOHlUZWIzUjcyOCsvS05MRW0v?=
 =?utf-8?B?NkxqK2JWbmVCMm5CdnhlSDdlTytFZ1p5VmVudDNKcUxEZjJINzJybDJRRjBa?=
 =?utf-8?B?OFFCK29zZjEwTFJSRXRMSkptRDRYeGw1czFWNSt4Z1dCRlFCa2tKV0wydkR0?=
 =?utf-8?B?cjRpeGc5cXZ2MXgxSmdLbXBjQnJkY3VsK282eWZodGcrTGF1a2k4eGZJVEJw?=
 =?utf-8?B?MThKTkRMaVBvNm0rY1dSOURUUzk1cjRXbWF3RkU4NHB1Ylp1dFdRS3B3ODdW?=
 =?utf-8?B?TlVnMHBWTW4wTGlsVFVxWktmNlFCd3FtckhiSXV6bUJQRmo3MUdKVlZyU20v?=
 =?utf-8?B?T2o4M0pQdVJRWktaM3NFME4vSU1USHI1dTM3THBpdmozb0FndjRqVzd3NzN2?=
 =?utf-8?B?TnZkNlI5d09kVWhmeTFPQ2lzUjExb2RBZkZBT2tLREtxbVZlOW5MZGc4ZzZ1?=
 =?utf-8?B?UnhSQXR5NHdFZ3VncVViK05McWZVZ0pQNDFoclBwa24wNmR5MmlaRXBQc0ZW?=
 =?utf-8?B?bkhiSVR0UEVvVXQrVk1GVGJTWWtkMk5TSzZOV0RYNVkxUWlyOGdSSlNJcDZr?=
 =?utf-8?B?TFFmbi9KWUgzOUllUjhGS3F4UERFMHY4ZVI0NHFaQjJXR2NhazdXbE5ML1Vz?=
 =?utf-8?B?em9hTnRqM3UranNyWldlbUQ0Mk15ZWRaRzAxaGhza3R5QkMwRXpGUVBLY3BR?=
 =?utf-8?B?NUp5OXE2RGdvdy9XOGVjNjdlYlo4eDdtTlZoT3ZSTFE2SXkzeEp1cW1hRXhG?=
 =?utf-8?B?TkxMZ3U1TEpsU0pyVis5Z0hLSExZMjJLN0JXaE0wK091ZWZ6Uk05WURraEQ0?=
 =?utf-8?B?T2dDemlIblRtNnF0Qm5KaTd0Wllvd09nZU5Qb1Q2QXR1d1J6RWdURjZPeTJm?=
 =?utf-8?B?RE1ZeGdxMUlRVHpGeDliZzFYOXA3Q3VURUZ2QlQ2QktmaHhJOTFRUjJRN3du?=
 =?utf-8?B?VlBDVy9xWXJvZHdYYk1lQTlsdmFMVno5VldoTnZ3TjVSNldNRkNwQnhMQllu?=
 =?utf-8?B?aGZEOHBtbmV1OXdhM3JKRTdEcUZEajJWNTU4Zy9wU2g5WHhmZmlwcVh1K3l4?=
 =?utf-8?B?WTBUOWwrWmpWMEdldVJsNGlKUTQzWVJaYlJNR3hTbTJvQUVnQkJ1TGdWNWF4?=
 =?utf-8?B?c1o1aGZxS0JzMDFBS0dSc0k5bnFhQkV4N1ZUV003NHZTNHlaN3FQSW5lRXRn?=
 =?utf-8?B?UzBxRWV2di93UVlBMlNEbEtMUUlacUg3cy9KRlZKLzlQek45V1gzZ1lQeHZa?=
 =?utf-8?B?N1pUZnE3Z2hFcGxPRlA4S0kvQ1gxdldrS25kVHplcjQxRWY3ZEp2Ui9laVJM?=
 =?utf-8?B?TVlTWUZKK3FsWVZZV1FRNWtWVlRvWHpTbkpBR2xqbXZ5WVZlMHkxNUVaTE4x?=
 =?utf-8?B?OXRuY2lYS0Q3TlliYktvQmZOOFMya3N3cHhIbXVtTlc5bC90QXVuVUMwLzJ4?=
 =?utf-8?B?ZWQrcUU5TUFBSVA2NUVCQjJYUzJuTGg4cUw0dlFRWmRmVktSenhoY1FQU0gv?=
 =?utf-8?B?cTl2Mi9zcE9iaUpUcStGdUJmQjFPNUNGRFEyTGt2NDZGaWpzYm80YnVHdEZJ?=
 =?utf-8?B?d3FLVXVEZHBIZExucjd1NndsVXBUTHR1VlE2aWoxeU83N25jd2hBT3dUWURB?=
 =?utf-8?B?MlZOR3BqTkpIK1VJeVRMdW1uaUNtT1p6bzNpZnk5Ri9VVkh4eko1NDhBYTVl?=
 =?utf-8?B?ckJlU2NnNHFVbnZvQko0RS81MFVuMnFUcndmbVYrQ2NxUWtuRHpMWW1xZVIv?=
 =?utf-8?B?cDZtOWJXVTlwMGZ5K3dGaFgramtIVk4yaUxCZzZMR3FpQlQ2Q0J6cXhJKzhI?=
 =?utf-8?B?a1Q0TUdQcEVHYmIxNS9DSHc4bmRVVXNGNzE4aVE4ZHIvVG9BdnpERERQc2Vt?=
 =?utf-8?B?dG5DK0hNYWhMTXJDak82Z0RFY1RCSFBBbVpxYlJRcjBVdkV2enZSNU83ZkF4?=
 =?utf-8?B?TzBWSDkxVTZyaUpMdDlRWTVvbnJNVUFaUHMwTGw5bkhKZnVteWY1S3lYTWRm?=
 =?utf-8?Q?MInFNYQwE/KESIaQ2/X7SO2ag?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32fa93a7-e450-4bca-1546-08da63d9d5c6
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 07:40:47.3178
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SFJAOP2I3m5jhXBWpGfc3mQUArtIX6R7xHpgxxULx4ZVC7POqQbOdT4VVOOrHaTr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB4685
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 12.07.22 um 06:22 schrieb John Stultz:
> After having to debug down through the kernel to figure out
> why my _WAIT calls were always timing out, I realized its
> an absolute timeout value instead of the more common relative
> timeouts.
>
> This detail should be called out in the documentation, as while
> the absolute value makes sense here, its not as common for timeout
> values.

Well absolute timeout values are mandatory for making -ERESTARTSYS work 
without any additional handling.

So using them is recommended for ~20 years now and IIRC even documented 
somewhere.

See here as well https://lwn.net/Articles/17744/ how much trouble system 
calls with relative timeouts are.

Regards,
Christian.

>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: Chunming Zhou <david1.zhou@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: John Stultz <jstultz@google.com>
> ---
>   drivers/gpu/drm/drm_syncobj.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 7e48dcd1bee4..b84d842a1c21 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -136,6 +136,10 @@
>    * requirement is inherited from the wait-before-signal behavior required by
>    * the Vulkan timeline semaphore API.
>    *
> + * It should be noted, that both &DRM_IOCTL_SYNCOBJ_WAIT and
> + * &DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT takes an *absolute* CLOCK_MONOTONIC
> + * nanosecond value for the timeout value. Accidentally passing relative time
> + * values will likely result in an immediate -ETIME return.
>    *
>    * Import/export of syncobjs
>    * -------------------------