Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CGME20220712071941epcas2p2faa87d8efe182e9c28a924ea3de15209@epcas2p2.samsung.com>
 <20220712074705.420399-1-youngmin.nam@samsung.com>
In-Reply-To: <20220712074705.420399-1-youngmin.nam@samsung.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 12 Jul 2022 09:41:43 +0200
Message-ID: <CAK8P3a0pCov7ZiNhG+by7PpxMdBbBpUa7TKNc9e0p-zXvqg-7g@mail.gmail.com>
Subject: Re: [PATCH] time: remove useless "const" keyword in
 ns_to_kernel_old_timeval() and ns_to_timespec64()
To:     Youngmin Nam <youngmin.nam@samsung.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, John Stultz <jstultz@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Chanho Park <chanho61.park@samsung.com>,
        hajun.sung@samsung.com, hosung0.kim@samsung.com,
        d7271.choe@samsung.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 12, 2022 at 9:47 AM Youngmin Nam <youngmin.nam@samsung.com> wrote:
>
> As mentioned below,
> https://lore.kernel.org/lkml/CAK8P3a3nknJgEDESGdJH91jMj6R_xydFqWASd8r5BbesdvMBgA@mail.gmail.com/
>
> The "const" keyword is useless, so we drop it from the function definition and declaration.
>
> Change-Id: If35bba78aa7757476e22be42afc719c27fb0f527
> Signed-off-by: Youngmin Nam <youngmin.nam@samsung.com>

The patch looks good, but the description can be improved:

- drop the useless Change-Id field
- move the URL into a 'Link: field'
- wrap the lines to fit into the normal width of an email (under 80 characters,
  ideally 70)
- explain why the change helps, rather than just stating the keyword is useless.
  In your description, it's not clear if one is better than the other, it sounds
  like it should make no difference.

With that done:

Reviewed-by: Arnd Bergmann <arnd@arndb.de>