Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4091451imw; Tue, 12 Jul 2022 01:21:15 -0700 (PDT) X-Google-Smtp-Source: AGRyM1syUva/k+pbIbCj+iXaQ8BRvbO6iVgetBSYA0GXdejyu9/BJJc2JSH8GHeQnt0LyalIl+P1 X-Received: by 2002:a17:907:2bd6:b0:72a:3f51:8093 with SMTP id gv22-20020a1709072bd600b0072a3f518093mr22476132ejc.134.1657614075323; Tue, 12 Jul 2022 01:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657614075; cv=none; d=google.com; s=arc-20160816; b=CGQibi41pB1KRVgvQLjNClUzwSofNQeF2JwPHEq6vSwK5eO0OsUun8vgcRh8ND0ycO x4DpdNK5n10oClJlnR+9U4LWQ8uqZOh+kb7S1FJIL4BFAnTBoPh3lFvWN6bMWheCE3CU 1gapthdhlHynWF5EGzj3Dk6Fh9c8Itk8NZAcJJOibu5x0/U4R6iPujSYFB31vo4TCrit NpkZ1w3lNuf9hzweXSDxrijGHgnozUFIGArvR/h7WcqUerg7tz60RcbyknyjR3Cfg999 7NuwAnk2fuN65576+75e1dxhrYh+GpI/u9N965aZ9gbL0lTiklZASArPfZgMEU/THdxL 4A8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=57p8jLa0c05OK0xNuu/2mL1lh+0o8RXQIwfVr2PrDEY=; b=Waj8YvhPr8FcFJ6xlu+ynXMLDXpmuQAZNsNCNeB45wtumlgst9Wa45+Bb/Yqaq2N4H yc+o2JR4zcaHRyb1ACG1JnmBz2c2i7DQZjrV1bL1rh9+8FJcOBNjXzxOwAM60ODUJf7F nlkJKGUVjeqXfh/hjgWuDJZ40Q/mhh4/TKGdd8J7QiPDBtkPoUb1Yb5W3ZOCdAxTxf/r h3U/SuUx9GUTTVI/pZ/gIrFH7MtroIQbqCTpH90fCnaPDTsh/qzzjcxJTNIM8TjY9Iuo ui8g95s16ZskBL57te1hSYUR5d9verXcktySvHiLmZaIYlG8SsJDNjDqeU/i/M7LyFZo TYdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cs16-20020a170906dc9000b00715790f718dsi10724382ejc.318.2022.07.12.01.20.49; Tue, 12 Jul 2022 01:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232020AbiGLHzJ (ORCPT + 99 others); Tue, 12 Jul 2022 03:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232527AbiGLHyr (ORCPT ); Tue, 12 Jul 2022 03:54:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A22822BCD; Tue, 12 Jul 2022 00:54:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19616612B8; Tue, 12 Jul 2022 07:54:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C8EFC341CA; Tue, 12 Jul 2022 07:54:36 +0000 (UTC) From: Huacai Chen To: Arnd Bergmann , Thomas Bogendoerfer , Geert Uytterhoeven , Michal Simek , Yoshinori Sato , Rich Felker , Jeff Dike , Richard Weinberger , Anton Ivanov Cc: loongarch@lists.linux.dev, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Huacai Chen , Guo Ren , Xuerui Wang , Jiaxun Yang , linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Huacai Chen , stable@vger.kernel.org Subject: [PATCH 5/6] SH: cpuinfo: Fix a warning for CONFIG_CPUMASK_OFFSTACK Date: Tue, 12 Jul 2022 15:52:54 +0800 Message-Id: <20220712075255.1345991-5-chenhuacai@loongson.cn> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220712075255.1345991-1-chenhuacai@loongson.cn> References: <20220712075255.1345991-1-chenhuacai@loongson.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_CPUMASK_OFFSTACK and CONFIG_DEBUG_PER_CPU_MAPS is selected, cpu_max_bits_warn() generates a runtime warning similar as below while we show /proc/cpuinfo. Fix this by using nr_cpu_ids (the runtime limit) instead of NR_CPUS to iterate CPUs. [ 3.052463] ------------[ cut here ]------------ [ 3.059679] WARNING: CPU: 3 PID: 1 at include/linux/cpumask.h:108 show_cpuinfo+0x5e8/0x5f0 [ 3.070072] Modules linked in: efivarfs autofs4 [ 3.076257] CPU: 0 PID: 1 Comm: systemd Not tainted 5.19-rc5+ #1052 [ 3.099465] Stack : 9000000100157b08 9000000000f18530 9000000000cf846c 9000000100154000 [ 3.109127] 9000000100157a50 0000000000000000 9000000100157a58 9000000000ef7430 [ 3.118774] 90000001001578e8 0000000000000040 0000000000000020 ffffffffffffffff [ 3.128412] 0000000000aaaaaa 1ab25f00eec96a37 900000010021de80 900000000101c890 [ 3.138056] 0000000000000000 0000000000000000 0000000000000000 0000000000aaaaaa [ 3.147711] ffff8000339dc220 0000000000000001 0000000006ab4000 0000000000000000 [ 3.157364] 900000000101c998 0000000000000004 9000000000ef7430 0000000000000000 [ 3.167012] 0000000000000009 000000000000006c 0000000000000000 0000000000000000 [ 3.176641] 9000000000d3de08 9000000001639390 90000000002086d8 00007ffff0080286 [ 3.186260] 00000000000000b0 0000000000000004 0000000000000000 0000000000071c1c [ 3.195868] ... [ 3.199917] Call Trace: [ 3.203941] [<90000000002086d8>] show_stack+0x38/0x14c [ 3.210666] [<9000000000cf846c>] dump_stack_lvl+0x60/0x88 [ 3.217625] [<900000000023d268>] __warn+0xd0/0x100 [ 3.223958] [<9000000000cf3c90>] warn_slowpath_fmt+0x7c/0xcc [ 3.231150] [<9000000000210220>] show_cpuinfo+0x5e8/0x5f0 [ 3.238080] [<90000000004f578c>] seq_read_iter+0x354/0x4b4 [ 3.245098] [<90000000004c2e90>] new_sync_read+0x17c/0x1c4 [ 3.252114] [<90000000004c5174>] vfs_read+0x138/0x1d0 [ 3.258694] [<90000000004c55f8>] ksys_read+0x70/0x100 [ 3.265265] [<9000000000cfde9c>] do_syscall+0x7c/0x94 [ 3.271820] [<9000000000202fe4>] handle_syscall+0xc4/0x160 [ 3.281824] ---[ end trace 8b484262b4b8c24c ]--- Cc: stable@vger.kernel.org Signed-off-by: Huacai Chen --- arch/sh/kernel/cpu/proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sh/kernel/cpu/proc.c b/arch/sh/kernel/cpu/proc.c index a306bcd6b341..5f6d0e827bae 100644 --- a/arch/sh/kernel/cpu/proc.c +++ b/arch/sh/kernel/cpu/proc.c @@ -132,7 +132,7 @@ static int show_cpuinfo(struct seq_file *m, void *v) static void *c_start(struct seq_file *m, loff_t *pos) { - return *pos < NR_CPUS ? cpu_data + *pos : NULL; + return *pos < nr_cpu_ids ? cpu_data + *pos : NULL; } static void *c_next(struct seq_file *m, void *v, loff_t *pos) { -- 2.31.1