Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6e490429-e34c-fa51-c6d9-3315c4639d9d@amd.com>
Date:   Tue, 12 Jul 2022 09:45:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [RFC][PATCH 2/3] drm: vgem: Enable SYNCOBJ and SYNCOBJ_TIMELINE
 on vgem driver
Content-Language: en-US
To:     John Stultz <jstultz@google.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jason Ekstrand <jason@jlekstrand.net>,
        Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
        Chunming Zhou <david1.zhou@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org
References: <20220712042258.293010-1-jstultz@google.com>
 <20220712042258.293010-2-jstultz@google.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220712042258.293010-2-jstultz@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGpVRjE3ZlhEWG0xdkJXVHg5Um1DbW80bFdNSEQwRFVXR2gvbVBvdU5KM0Jq?=
 =?utf-8?B?N1VMS0pxb2RPdkJRKzFyT0t6UlJjVHZ5YmI2dEpzZ2J3N0o5bFN3TUI5eEdG?=
 =?utf-8?B?UHN3eVpFQ3psZlg5N2pSNTRoc2dSYjVLQStZYjZUMDBrNE5sUlFWRUxLVWI4?=
 =?utf-8?B?dStUSzFFTll3SFpnSzVpNDBVYXFpdVBZY2xlV3o4blRCb0tVckRMRTF2bzNN?=
 =?utf-8?B?ZlplSkY2cUZZVHR0WHVkVTU4L2pXK0Zwc2lWR3hjKzZKa3BpYkNHem0vK3RT?=
 =?utf-8?B?WWgydnZqcWdUaGZtK281aUZxSTUxUld6NzE1OEg2MDRPZWo5UWg1VjhTL0Yy?=
 =?utf-8?B?SkdzbHBqNTF4Y1Z2OStXVTR1bDN3WEFEa0dtOVhHMEJvRk5wZ1JxcTNleGdB?=
 =?utf-8?B?ZXdCdW4zMkMvNitaNHVoMzBqVENhK3BLT01GM1ZvdWhHMEtBVDFqdEozNmJr?=
 =?utf-8?B?UHRjWXNzVU4vOHFhdk1CREdxSFJObEFoTW1iMkcxQ2x1UmVTa2E1WisvOVVR?=
 =?utf-8?B?bWszbGRjV1doREgvRlA4V1p0K2x0bnhPbWJkVGl0ZTd6WmN5NkF2VTdDNDF6?=
 =?utf-8?B?T2h5U282akM4K2tFWDRPbWYzenpkMXRLSndxejNOZGhlb0srZEd3dUkwTG1P?=
 =?utf-8?B?cDFLVkJ5R2NoU0djNWZWMFJNWFk2V3lzRTVBVXRpVGR3RkN5T2dvK2VVa1Fy?=
 =?utf-8?B?TlJxcFpaQklUTkV6dnhkTHhPR3Rzb3JxRTJUOUxNOEFpa0ZidWdmQThjbmht?=
 =?utf-8?B?ZklIWTdhNnFMYVpwTU50Ty9wVmNMRUQ1N2p5aXRtNWJsNWU1ZUZGTzdtTk1n?=
 =?utf-8?B?UTI0L3NpaVFZWDFRZ21KVXpYdEoyaXU2VjNFRTM3VUxHT3FpbzdGZVFjWHpt?=
 =?utf-8?B?a0o5RkladEg5R0M4Y2ViUURWNVNhdUs5cWN3NHJ4MVNqZ3dvQmllQ2hPd1Y2?=
 =?utf-8?B?SUEzeHpmM3lta2JDUDF3enVSRVh2QjQ3T0orOGRHZE9rWXBvczdleVd5Ry8x?=
 =?utf-8?B?c0pZV2FGaDdWN0lBWGFVeERySG1BVHF1RU5hdHY1UWIyNTY5TExBVnFnTlln?=
 =?utf-8?B?OXNIUGMxZnMvVGRkZVoxcmJXWVlieVEwWEd0aVN5ZWxuZkhoaWpNdlhYK1Fa?=
 =?utf-8?B?QVlHN3NMSHR4dUxVdnRnUmU0MDl4ZzhJV1I0cDdPUmdsUGJ0bkxna3hvSWdW?=
 =?utf-8?B?cFJMTHNPUUpuOExQS0tHSU1rWW9kemh1R3FTTTRVUGNtOE5HdXRNL1V1REpk?=
 =?utf-8?B?eTRFQ0lmbVp1M0hzR3hkeFJzMTJlQjBOaUNaRCtjVWRiMmhUSXZJRnFrK3Q0?=
 =?utf-8?B?bnc4WktlWmcxSUcwTCtIWnVKVEF4UGR3c1pXV2ttdVdpVC9aUUowYTV5eE85?=
 =?utf-8?B?Mm1mdGw2S1YwTG9rSkpJOTdkS05MY0tvTGdoYnB4WllXbk8vQXJXdjdjSTJr?=
 =?utf-8?B?R1pLZkhSZnVqYXpDRG9TWkY0ZnFBb1NwSUNUS3AzbXJKK2JRZndkeUIrZmtS?=
 =?utf-8?B?QmxJcHlHbVp3cjlINUpMb21YNHdCR3djbkd5SG5BdTVnQkFKdS9HekFlYmZk?=
 =?utf-8?B?dmJxS1VQZmRXamRNUmVFVE5jMS9lWXVWQlg5RlVrQlIxOUloU2VQRlNKTm1j?=
 =?utf-8?B?OGhaeFpJalV1cXIycXMyYkhmQzZkU3lpSTVVWjFrVml3NTd1c3FvOVIwOFF6?=
 =?utf-8?B?ZkFTdXRETTlid2FNeUJrMnptNHVpRVlQNWhWb1JyQ3N4cG5MUVRGU1pjTTFO?=
 =?utf-8?B?ZXVQcmhVTTA5MXJjY05uQkNJMzZFWTRyM2h3cy9GRGJXc0Z1NldJRHNIbzl2?=
 =?utf-8?B?RWhTczQwczlGT0wwTjllS2I2dy9Ib21VWGppOFo3c3gyc09GLzFsWHYxSWFa?=
 =?utf-8?B?eFpSUHNBOEJvSVdUL3NRMDZhdmFFeTRpbWFMUThHaWtpdHpyRmNHOWFMN0RF?=
 =?utf-8?B?OFRrWUtPYUpySlF0QUhTZGt4NllGUFdtemJCaE9JSXhIcXliNkd6azExVDBk?=
 =?utf-8?B?Rnd2MnJlcGRsYjZuaUZQa0ZNeHY3aEdPSm16ODhyaXFObDAxZ0g2djhoMHJW?=
 =?utf-8?B?SVlzR0pmbHpQSUJFWTN5ZENpbi95SmZSNE1EZFpSSEtCMG90M1J0MzZYRUl1?=
 =?utf-8?Q?drRmOwMzONg25bFivHFmMqsiK?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9177020f-c08a-46c9-953c-08da63da90df
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 07:46:01.3438
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P1aYTjNSjqCBY7W5pXm1A/2IBlPalN5r0ddh/a4v5U4gAAzgqcCZH1GC7OFI34n8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4435
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 12.07.22 um 06:22 schrieb John Stultz:
> Allows for basic SYNCOBJ api testing, in environments
> like VMs where there may not be a supported drm driver.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: Chunming Zhou <david1.zhou@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: John Stultz <jstultz@google.com>
> ---
>   drivers/gpu/drm/vgem/vgem_drv.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index c5e3e5457737..e5427d7399da 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -109,7 +109,8 @@ static struct drm_gem_object *vgem_gem_create_object(struct drm_device *dev, siz
>   }
>   
>   static const struct drm_driver vgem_driver = {
> -	.driver_features		= DRIVER_GEM | DRIVER_RENDER,
> +	.driver_features		= DRIVER_GEM | DRIVER_RENDER |
> +					  DRIVER_SYNCOBJ | DRIVER_SYNCOBJ_TIMELINE,

Well that's rather surprising. I'm not an export on VGEM, but AFAIK you 
need to adjust the CS interface to support that stuff as well.

Christian.

>   	.open				= vgem_open,
>   	.postclose			= vgem_postclose,
>   	.ioctls				= vgem_ioctls,