Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4093649imw; Tue, 12 Jul 2022 01:25:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s7aSlWEwXtWHEvBlB3ghGIEyD3TLMIst1G+aWLVSJ0Wg20hZ6dnuGexW1wMbYBSybJORbj X-Received: by 2002:a17:907:1623:b0:72b:64e3:878a with SMTP id hb35-20020a170907162300b0072b64e3878amr6656083ejc.185.1657614311848; Tue, 12 Jul 2022 01:25:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657614311; cv=none; d=google.com; s=arc-20160816; b=0ikKwaDz7N56HbY1tYPWJoDXpZzM0vxoLh8mfQWhCboJbbDqIIDhPUf+29bqBxtkKT 9BejXEmaCZmMMG9rqdT1vANtqz7Z3/+QxJs+ojsWanDS3dpi3zLHGTrMLV0NuLUPK/5G NmGHW80qd/JdYdapHaecAZxPmBNlUZx/jTLb8X3fIgbFRh+TjzTjmKPhdSwp/uQFeQcX Fbc5SRPnPXhPET49qDj3PL+J3yD9PX3wZbORIl5kjsY+Dxdx/0mFjDPZMugtytFzEMyz U3d04JO87ADiilcld/EADjgh4jXZawWQVjG4y/MhFPCY8sFby3VAJqrxZoJnElesmV+g BiUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jB0/sBewzpAG176RgBmVCEhPfPoNVC+csgcU/c7Q6og=; b=HQxxzE8+NqNSKPngF8BXexE2295AIczK0jnrDEocEjY29546FoBUjlaXHIKR8SeNyc rIgBP5PTuWWL5C4NY+J1m/nlZN6IlyXTOcA05HbPl20Bh9doe9nMqj4yldCEw6MxMrnm ZkeAhJLlSnyVKHW6y8OKa0vqOh45cbHMprK/TlV0gl3eNKdsNUMWYmkL0OX0khAz49J+ RvHyTAUsl//+7tQ/LOVagF9d2ihHyaVmvRWleyKhnDTAfuvvgvlJBdsqbGxzFgF7JMXc oREoDQeDwJAytGoIcu8DoSlO71I1LqWakeTM2mv1nTzvy6aMmrCi+b/qKlHSfjsXz5jT bypw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=IRoSMJWb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s6-20020a056402520600b0043ac5aa9baasi13827775edd.616.2022.07.12.01.24.45; Tue, 12 Jul 2022 01:25:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=IRoSMJWb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232425AbiGLHz3 (ORCPT + 99 others); Tue, 12 Jul 2022 03:55:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232519AbiGLHzY (ORCPT ); Tue, 12 Jul 2022 03:55:24 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D95BC9D502; Tue, 12 Jul 2022 00:55:23 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id a15so6800500pfv.13; Tue, 12 Jul 2022 00:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jB0/sBewzpAG176RgBmVCEhPfPoNVC+csgcU/c7Q6og=; b=IRoSMJWbprULskG7mdeaOOmkltqpld0mdJe52BBdf4hD/lxcPWweBCqOpxoRSj3Ye1 QEkZXSnZLxNnwjWz1F1scbwAMHncxgphl3kngkzvsNIoYOz43RAEfRnB1ajveSdLYi9Y n0Eft1Nm3zNWZyYSqieS/NqwmgWvuPmpd1fMnNEXeBj6yQKxz1ksKZdOZ7hWHF2f+c5X PrQ2VP/MfufZzl0bThMhX0HuRLgYMGgYASqSPG0g3hDbDzLg/7sLV4KhOagh7JcqmsNR sZOtrnTID3W/cL07uzXsUtQ1zwjlTOcs3a6+/Fo/juf7CMA2QdNnUQB1a81FIgI7F4EJ VcIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jB0/sBewzpAG176RgBmVCEhPfPoNVC+csgcU/c7Q6og=; b=QTva4428mzBOx6gSyZbO3MMkrZK9IcyXevGlrLotfQ8vnjz9m7u22d0boskHT64EQx 2TS+PIbDwa7Uycn3IC3ABnKiABykSNjJLDxHyg8x8LLkMxUeqQg4ij3wMQO+Su4eh6+P /veYQpUwNSZq/kvHkRztXj+8kbyVPrC2+4ZIuMgZqMwyzwPkloCEUiUClfMqCNX/Joa/ bUCCuxyymce4ZuWatHcs2GyF74yGqUanE2IqyvtjqGZojB6jZNlueFP1G/Ytvcl0/boF 6HdWcZyRZpsxVtNYp5VJmluE8oHR5X0j1jn8ozRtVBw+DAdr5UeiVb8TVrQlMhtzQ0lH NTqQ== X-Gm-Message-State: AJIora9StDcfj1minMyEmW73D6SnsssHMleWCtdvXZQUrAd1hphkV5AK idAYjuM6T/mfzqrPcvVf5hE= X-Received: by 2002:a05:6a00:2410:b0:528:be6e:8c2e with SMTP id z16-20020a056a00241000b00528be6e8c2emr22496038pfh.31.1657612523274; Tue, 12 Jul 2022 00:55:23 -0700 (PDT) Received: from localhost (fmdmzpr02-ext.fm.intel.com. [192.55.54.37]) by smtp.gmail.com with ESMTPSA id q5-20020a170902a3c500b00163f8eb7eb3sm6069166plb.196.2022.07.12.00.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 00:55:22 -0700 (PDT) Date: Tue, 12 Jul 2022 00:55:21 -0700 From: Isaku Yamahata To: Kai Huang Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Paolo Bonzini Subject: Re: [PATCH v7 029/102] KVM: TDX: allocate/free TDX vcpu structure Message-ID: <20220712075521.GI1379820@ls.amr.corp.intel.com> References: <2ecd255ac85fac7ffa1b90975c9e08f11ddee149.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2ecd255ac85fac7ffa1b90975c9e08f11ddee149.camel@intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022 at 11:34:55PM +1200, Kai Huang wrote: > On Mon, 2022-06-27 at 14:53 -0700, isaku.yamahata@intel.com wrote: > > From: Isaku Yamahata > > > > The next step of TDX guest creation is to create vcpu. Allocate TDX vcpu > > structures, initialize it. Allocate pages of TDX vcpu for the TDX module. > > > > In the case of the conventional case, cpuid is empty at the initialization. > > and cpuid is configured after the vcpu initialization. Because TDX > > supports only X2APIC mode, cpuid is forcibly initialized to support X2APIC > > on the vcpu initialization. > > The patch title and commit message of this patch are identical to the previous > patch. > > What happened? Did you forget to squash two patches together? Forgot to squash this patch into the previous patch. Will fix it. -- Isaku Yamahata