Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0d60aa42-a519-12ad-3c69-72ed12398865@intel.com>
Date:   Tue, 12 Jul 2022 16:06:54 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [LKP] Re: [io_uring] 584b0180f0:
 phoronix-test-suite.fio.SequentialWrite.IO_uring.Yes.Yes.1MB.DefaultTestDirectory.mb_s
 -10.2% regression
Content-Language: en-US
To:     Jens Axboe <axboe@kernel.dk>,
        kernel test robot <oliver.sang@intel.com>
CC:     LKML <linux-kernel@vger.kernel.org>, <io-uring@vger.kernel.org>,
        <lkp@lists.01.org>, <lkp@intel.com>
References: <20220527092432.GE11731@xsang-OptiPlex-9020>
 <2085bfef-a91c-8adb-402b-242e8c5d5c55@kernel.dk>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <2085bfef-a91c-8adb-402b-242e8c5d5c55@kernel.dk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TStpcFl4ZU9KSGJEZ3Vid2pzdmQxN0xPcHJ1OVRYcEczbExSdjA0TFEwVkky?=
 =?utf-8?B?V1R6cERZZHdkMkNvcHUwYklLajljdllFUWg0VDZ3cko0WFp4dmZLNmZnbFJG?=
 =?utf-8?B?VXFqcUNDeGlNejhPN1ZBdmRwRm0rWFNNYTltTnNZYzQ4ci9PcEMyYWk1bXh6?=
 =?utf-8?B?cVpZcGI5b1JwUGpzVXNadWU1dHRxRG9ybWUrT0tHZjRyOXJ2L0FPWFQ5aktv?=
 =?utf-8?B?MHJ5VkQwaXFoTTc0RUUvRkRIV3FtMmNsUmNyeFpMSGEvQi9wS0k1KzRZVFQ2?=
 =?utf-8?B?RmRra0k3U0JJSjdscHROUEJyL21MNTBFQWhFWkRzNUVKQkdmVFlaY1hwNHB2?=
 =?utf-8?B?UmROT1BBQmQ0RzJ1MUZpeWhvYnBSRVFoWEwyRG9TSElBdnFTdmN6SlI4cmhm?=
 =?utf-8?B?aEoyanZFOXJFdFZTcDRjek9OWUlXK2d3bzNBaWFSNXF3ZHpJTjEwNWFMR3py?=
 =?utf-8?B?T1dyL1RKWXhpNjdIWDVjeWlqZUNSSGlWYi9iakNwMnZuRVduTUp1YWtmMWQr?=
 =?utf-8?B?ZEhidHpRbzl1aEo3MWlCVzJWQ0hFVVY4ZllwU3lERWx4QmZMankzYzlocytv?=
 =?utf-8?B?VklybVk0dVZzOHhQazQ2VCtoTzRVNGtDc3lvc1phNGhiU1M4TlBLOE1jL2Fj?=
 =?utf-8?B?M1BGNFNucFFGNWUvc2lzMllYMVFWNWlFa1U1ZDBnR2RCOGlGNitzSDdUbDJy?=
 =?utf-8?B?YTN2dktwTzMzRFVPcFRXdFVTcUVXdDNTVzFtVk0zaExzb3JkSHlVZHY1bm52?=
 =?utf-8?B?UUt5bjZaZktTSUV3eVdMVzBLallyNThHZFdiT2RBS21rOFZxUmFiU1d1VEpN?=
 =?utf-8?B?L2hXU2dvakRYYndxMWxmZGhkZzhabkRybk5oblJyWUgvcUM3d0oyQVZ2NE5Z?=
 =?utf-8?B?cHNURUZYZVQ3NDB0YnpWa2NaM1R2alR6aldQcFRLM0g0YTRaL3NFdG16ZXFk?=
 =?utf-8?B?dExVcWRPZXNSZG55dm5PZWxyMzErSkREZlZxUVNkQ2U0UGtKV3JJYktiR3lh?=
 =?utf-8?B?b3VQQXU5dFFnYUxtU29WUHdMUHhoVHR4Snphb2tFWUwvZ3l3RmZCS25ac3JL?=
 =?utf-8?B?UVV0V0ZRcjVmbTdmNUlRbURzbEZPNWtqYVB5OEs2M3NuWmM1RDllSVl4M0x2?=
 =?utf-8?B?T25QQ1BPc0doVEUrVUdTa0RIZ3U4eG9OK1JWeWg2N21nRDd6Z28xVWNpd2ZW?=
 =?utf-8?B?ak8rY1R5WDlSclhMYXhTZHpFQnJEUi9EWVJycHU0Q1phSktHTXZXc3VCZGl2?=
 =?utf-8?B?cDRtVEs0YmZtU2dGNjZ0RXdkQisyZjFTUzg4bFR1aWNpV0xZRWlMU2tOYjZZ?=
 =?utf-8?B?T1h0cEZiQmNLbkxYWkRVTXM5cDJLa0FQZnczOE1aYXlqVkVlcjZuVnhLNmlu?=
 =?utf-8?B?OTVCT3NJc05BVEF3cFU4VDVKTDRITWtyR2RtMThvK2UxWEZITmFxb0YzMGJo?=
 =?utf-8?B?Sk5JdTZmbGlxTVpOWXJEaFN4bVBnZGhqbzR4eVlmOTc1L2ZkTXZYWDM1Y2hh?=
 =?utf-8?B?ZmNNTjNWK2l3UStoUy9OdSsyd0E4emMyNEpnTVZnc3BUdjJUSnZkZ3QxNkR5?=
 =?utf-8?B?WWpzckMvWTBnc2N0OU9TNm55aEs5dVcyU1p4SjFwZ2psK1NxRzc2dkU4cDR1?=
 =?utf-8?B?T3ZhR1FRalVJaU1TbWlsOEtROS9hWXY0Wml2V1lVK0djSk8wL0Ridkc2K2JL?=
 =?utf-8?B?MGhTYkxtendrZ3pPRDBXb2dPWTN5ZC9ONG9MY3h5cEJNQU5VRW1YRGRveE1s?=
 =?utf-8?B?YzJoRnhyaFp1UEVJb2t3aUNvQldGWmhFT1NWMnJJRXJTU3N1UEtmY2NLM1Bx?=
 =?utf-8?B?VU5BeW5UejZud041NUplVUdJdEVOTmlOajQ2VEtFMDBYMzdaZ2YwYzFpM2F0?=
 =?utf-8?B?OVBrY2pJR1VZY05DeEw1OU5WRkJxd2UrOENjRFpoYjNGYkROUjVpRjFaTS9h?=
 =?utf-8?B?bkEwRDlkaHFlMFpqZERUOWhGeVZ3Zi80SGlYWkZqVWV5MVBLYVB4ZndkY2NF?=
 =?utf-8?B?S0JFOWdrNEVUZWRWM2FFTUpHcVRIL21zMG1ySmhINFV6dTJiM2d4aHEya0lP?=
 =?utf-8?B?bzJ2bG1JZmZoUHJDbFJLTjBOUmdtZTNwRjBvYjEvcWVmOTNmTk1iUmQ3SXpN?=
 =?utf-8?Q?KC/ei36Q89iPZhBfPWUIoHe+q?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 694331db-91fe-4fc2-a7d3-08da63dd80a2
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 08:07:02.5912
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KgoFhFHG3QqJ1sgt3NRGs4ZiJ+3qPxvi8vC67lQoYn+T2whjf1BJHzAt/Mwi5oeiKEN0M4oBgzF74b1LAzOFQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1750
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jens,

On 5/27/2022 9:50 PM, Jens Axboe wrote:
> I'm a bit skeptical on this, but I'd like to try and run the test case.
> Since it's just a fio test case, why can't I find it somewhere? Seems
> very convoluted to have to setup lkp-tests just for this. Besides, I
> tried, but it doesn't work on aarch64...
Recheck this regression report. The regression could be reproduced if
the following config file is used with fio (tag: fio-3.25) :

	[global]
	rw=write
	ioengine=io_uring
	iodepth=64
	size=1g
	direct=1
	buffered=1
	startdelay=5
	force_async=4
	ramp_time=5
	runtime=20
	time_based
	clat_percentiles=0
	disable_lat=1
	disable_clat=1
	disable_slat=1
	filename=test_fiofile
	[test]
	name=test
	bs=1M
	stonewall

Just FYI, a small change to commit: 584b0180f0f4d67d7145950fe68c625f06c88b10:

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 969f65de9972..616d857f8fc6 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -3181,8 +3181,13 @@ static int io_prep_rw(struct io_kiocb *req, const struct io_uring_sqe *sqe)
 {
        struct kiocb *kiocb = &req->rw.kiocb;
        unsigned ioprio;
+       struct file *file = req->file;
        int ret;

+       if (likely(file && (file->f_mode & FMODE_WRITE)))
+               if (!io_req_ffs_set(req))
+                       req->flags |= io_file_get_flags(file) << REQ_F_SUPPORT_NOWAIT_BIT;
+
        kiocb->ki_pos = READ_ONCE(sqe->off);

        ioprio = READ_ONCE(sqe->ioprio);

could make regression gone. No idea how req->flags impact the write performance. Thanks.


Regards
Yin, Fengwei