Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 12:01:10 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Cheng Xu <chengyou@linux.alibaba.com>
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Kai Shen <kaishen@linux.alibaba.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/2] RDMA/erdma: Use the bitmap API to allocate bitmaps
Message-ID: <20220712090110.GL2338@kadam>
References: <2764b6e204b32ef8c198a5efaf6c6bc4119f7665.1657301795.git.christophe.jaillet@wanadoo.fr>
 <670c57a2-6432-80c9-cdc0-496d836d7bf0@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <670c57a2-6432-80c9-cdc0-496d836d7bf0@linux.alibaba.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v5f6JUwPd1MhKB7Wy5NSD0tEZXxoNI5zjFHkXt/CI7P3qI+8SHjWRjxvl7vy?=
 =?us-ascii?Q?us4BJn9N4jiDQKR55P1NQlHU6V93h4qR2NupoF9pW704b/0MI7YEz36Z2XtY?=
 =?us-ascii?Q?ph10epmR7X4eljZQvscdf98ElBElDXsVSAwnb6oSMEhNZHimz/73rsMIPEOe?=
 =?us-ascii?Q?L5qou85XFoQrK4CPzTAUAVwRw5oImcPpIb7/k7HYt9Y7gGnwpF1XVyQoKtTE?=
 =?us-ascii?Q?CD+2Xb533Dy9nAwDIZoiXORYMmmjd/EDt+TcHLV/2HDVF0ve0s0U/Lu6Yh7i?=
 =?us-ascii?Q?oPA1lFCiCM33ERnzX6YUc66YUpSyi7LJdG9jXrhZXfvCzLyd0w0vJL+G4acp?=
 =?us-ascii?Q?K1ujfNiYsjHP3RccjU/o8eHPJAyTegJydo3upkGFOjYH5D6UmTpeGpRs7L9U?=
 =?us-ascii?Q?Iuz9t6o8rNEANcx/UdSzOAur0dSR9EFKxXb+6kKYwVVQPWL5JNvCkFrQfnxz?=
 =?us-ascii?Q?oceUM5SN3r4+2Hgkct0YzvWvzxCpfLVqJ3wNQWTasx/fIq0YOBb4jHGVXWY3?=
 =?us-ascii?Q?FBcTlpohkXz+rXKiMJ4kZlAQKUGcCq1pmUBXlHx+K4o5e+oPQkBFph20AQO+?=
 =?us-ascii?Q?uAktItFJaxCxWYl++gT14hpCwzdeIt+3rnuUfIYE4qFiUp/j5sY29Kd58NHz?=
 =?us-ascii?Q?bhZGaJ+fS0ryMkOO+UrqPGjLewYklPilVducwV8xlEbx4dS9fNxHGdXq0NwC?=
 =?us-ascii?Q?HdFBjxu7tU+GN5TPxIssWkceXzvNeGY3w968wSv6bVM1//yzyU3kisTgoOfV?=
 =?us-ascii?Q?xiU+gdpUDIVAf6eRSWr9gjR+h1qpodXnuGW+7aZVPI2g6EqFKwIcDz6InC55?=
 =?us-ascii?Q?AMPqwfu9aVbYwwRvQ+3mT+92ou8MypYN//SueyVBc0hnMEbhochDZkd+o/Px?=
 =?us-ascii?Q?FKImSCjErtOSgkMR5Ccdy/URRECIIM8FL4Athnz9iSFZAY/d4COc5vvE4phe?=
 =?us-ascii?Q?AdEB7/YMqNCh0qhLCkKibvaCqbWagD55wLeraUpDkABVLbRsbhSMiaIbRG7k?=
 =?us-ascii?Q?R6NXlc7fqlHw7d1RO7e7wdl2t2yLbN7m24Z02udDUpnb+dWjO4IEf0MAptjM?=
 =?us-ascii?Q?M+OkhVAc8/Y0oySNieVRq9Xro1uXoZqhotvljAyTxW0lCXnwV+ZU1vBi666m?=
 =?us-ascii?Q?2H9aF6z2h1WLLhQbienequf+f9ns/sHrF0k5qaO91T4hLAmrRpgLVBdjjQbs?=
 =?us-ascii?Q?w2Rhgxs9pOrhJz3wheaHmRFVkmeiYaAIdYVygBWwSIrOTrVLUGQIHQRMvSK0?=
 =?us-ascii?Q?HZ4WPpoS3HRsx2KfhmHKWFiv3Gw2ofcEN0TJP4BqSPlAr9mR9nsZh7RNRr10?=
 =?us-ascii?Q?BvYHwNVcJXjYcizS71VEy4rMCcgJKYAuyz18QvC/PqtNq3uMjzdTNP0tUY9q?=
 =?us-ascii?Q?/InzEVskupC6t710gfC1VRNLHDr5f7zBh5A/VWnJZXsd8jdHGB6LQPuZHVBT?=
 =?us-ascii?Q?SCSHJHkFigrkrgOmQp43OrUeYACzTC7itIOiehSpKqOcR6XIp65BQ5ghzYAe?=
 =?us-ascii?Q?EyahMvCq4nu/SfEReCQ4kesrzfzImT8/Ib7YGPEd4VcNtLRS8A9EFAUAhs1B?=
 =?us-ascii?Q?bQWke6ivEWLWWhOmR0FMGSI6mzUErOb5A/foUm6JIkQWGQvjngY9M6RgGgcn?=
 =?us-ascii?Q?Pw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff11958b-fc14-4dbb-be38-08da63e51e2c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 09:01:33.8442
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v44Jh3CBC+P+FO0K+gfbszM/9VLqnEf+1zM5ywzu9gDtlcGSWpiz6wDJQ9SGnCbmswBv4LCRhc1jKQbPzdP6G6klDzF2lNsoWg2J6Zhfl5c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4240
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-12_05:2022-07-08,2022-07-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxscore=0
 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207120034
X-Proofpoint-ORIG-GUID: TU12ZJjBmdCu18RucbBVg2EmobNmWHHJ
X-Proofpoint-GUID: TU12ZJjBmdCu18RucbBVg2EmobNmWHHJ
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 11, 2022 at 03:34:56PM +0800, Cheng Xu wrote:
> 
> 
> On 7/9/22 1:37 AM, Christophe JAILLET wrote:
> > Use [devm_]bitmap_zalloc()/bitmap_free() instead of hand-writing them.
> > 
> > It is less verbose and it improves the semantic.
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> >  drivers/infiniband/hw/erdma/erdma_cmdq.c | 7 +++----
> >  drivers/infiniband/hw/erdma/erdma_main.c | 9 ++++-----
> >  2 files changed, 7 insertions(+), 9 deletions(-)
> > 
> 
> Hi Christophe,
> 
> Thanks for your two patches of erdma.
> 
> The erdma code your got is our first upstreaming code, so I would like to squash your
> changes into the relevant commit in our next patchset to make the commit history cleaner.
> 
> BTW, the coding style in the patches is OK, but has a little differences with clang-format's
> result. I will use the format from clang-format to minimize manual adjustments.
>  

Best not to use any auto-formatting tools.  They are all bad.

regards,
dan carpenter